From: Yu Zhe <yuzhe@nfschina.com>
To: rafal@milecki.pl, bcm-kernel-feedback-list@broadcom.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, liqiong@nfschina.com,
Yu Zhe <yuzhe@nfschina.com>
Subject: [PATCH] net: broadcom: bcm4908enet: add platform_get_irq_byname error checking
Date: Fri, 9 Sep 2022 14:25:45 +0800 [thread overview]
Message-ID: <20220909062545.16696-1-yuzhe@nfschina.com> (raw)
The platform_get_irq_byname() function returns negative error codes on error,
check it.
Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
---
drivers/net/ethernet/broadcom/bcm4908_enet.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bcm4908_enet.c b/drivers/net/ethernet/broadcom/bcm4908_enet.c
index c131d8118489..d985056db6c2 100644
--- a/drivers/net/ethernet/broadcom/bcm4908_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm4908_enet.c
@@ -705,6 +705,8 @@ static int bcm4908_enet_probe(struct platform_device *pdev)
return netdev->irq;
enet->irq_tx = platform_get_irq_byname(pdev, "tx");
+ if (enet->irq_tx < 0)
+ return enet->irq_tx;
err = dma_set_coherent_mask(dev, DMA_BIT_MASK(32));
if (err)
--
2.11.0
next reply other threads:[~2022-09-09 6:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 6:25 Yu Zhe [this message]
2022-09-12 11:29 ` [PATCH] net: broadcom: bcm4908enet: add platform_get_irq_byname error checking Dan Carpenter
2022-09-12 18:14 ` Florian Fainelli
2022-09-13 10:51 ` Dan Carpenter
2022-09-15 9:49 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220909062545.16696-1-yuzhe@nfschina.com \
--to=yuzhe@nfschina.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liqiong@nfschina.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafal@milecki.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox