* [PATCH net] net: dsa: fix wrong pointer passed to PTR_ERR() in dsa_port_phylink_create()
@ 2022-10-08 8:39 Yang Yingliang
2022-10-08 13:06 ` Vladimir Oltean
2022-10-09 19:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2022-10-08 8:39 UTC (permalink / raw)
To: netdev; +Cc: vladimir.oltean, jiri, kuba
Fix wrong pointer passed to PTR_ERR() in dsa_port_phylink_create() to print
error message.
Fixes: cf5ca4ddc37a ("net: dsa: don't leave dangling pointers in dp->pl when failing")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
net/dsa/port.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/dsa/port.c b/net/dsa/port.c
index e4a0513816bb..208168276995 100644
--- a/net/dsa/port.c
+++ b/net/dsa/port.c
@@ -1681,7 +1681,7 @@ int dsa_port_phylink_create(struct dsa_port *dp)
pl = phylink_create(&dp->pl_config, of_fwnode_handle(dp->dn),
mode, &dsa_port_phylink_mac_ops);
if (IS_ERR(pl)) {
- pr_err("error creating PHYLINK: %ld\n", PTR_ERR(dp->pl));
+ pr_err("error creating PHYLINK: %ld\n", PTR_ERR(pl));
return PTR_ERR(pl);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] net: dsa: fix wrong pointer passed to PTR_ERR() in dsa_port_phylink_create()
2022-10-08 8:39 [PATCH net] net: dsa: fix wrong pointer passed to PTR_ERR() in dsa_port_phylink_create() Yang Yingliang
@ 2022-10-08 13:06 ` Vladimir Oltean
2022-10-09 19:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Vladimir Oltean @ 2022-10-08 13:06 UTC (permalink / raw)
To: Yang Yingliang
Cc: netdev@vger.kernel.org, jiri@nvidia.com, kuba@kernel.org,
Florian Fainelli, Vivien Didelot, Andrew Lunn
On Sat, Oct 08, 2022 at 04:39:42PM +0800, Yang Yingliang wrote:
> Fix wrong pointer passed to PTR_ERR() in dsa_port_phylink_create() to print
> error message.
>
> Fixes: cf5ca4ddc37a ("net: dsa: don't leave dangling pointers in dp->pl when failing")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Thanks!
> net/dsa/port.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/dsa/port.c b/net/dsa/port.c
> index e4a0513816bb..208168276995 100644
> --- a/net/dsa/port.c
> +++ b/net/dsa/port.c
> @@ -1681,7 +1681,7 @@ int dsa_port_phylink_create(struct dsa_port *dp)
> pl = phylink_create(&dp->pl_config, of_fwnode_handle(dp->dn),
> mode, &dsa_port_phylink_mac_ops);
> if (IS_ERR(pl)) {
> - pr_err("error creating PHYLINK: %ld\n", PTR_ERR(dp->pl));
> + pr_err("error creating PHYLINK: %ld\n", PTR_ERR(pl));
> return PTR_ERR(pl);
> }
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] net: dsa: fix wrong pointer passed to PTR_ERR() in dsa_port_phylink_create()
2022-10-08 8:39 [PATCH net] net: dsa: fix wrong pointer passed to PTR_ERR() in dsa_port_phylink_create() Yang Yingliang
2022-10-08 13:06 ` Vladimir Oltean
@ 2022-10-09 19:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-10-09 19:10 UTC (permalink / raw)
To: Yang Yingliang; +Cc: netdev, vladimir.oltean, jiri, kuba
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Sat, 8 Oct 2022 16:39:42 +0800 you wrote:
> Fix wrong pointer passed to PTR_ERR() in dsa_port_phylink_create() to print
> error message.
>
> Fixes: cf5ca4ddc37a ("net: dsa: don't leave dangling pointers in dp->pl when failing")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> net/dsa/port.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net] net: dsa: fix wrong pointer passed to PTR_ERR() in dsa_port_phylink_create()
https://git.kernel.org/netdev/net/c/557f050166e5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-09 19:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-08 8:39 [PATCH net] net: dsa: fix wrong pointer passed to PTR_ERR() in dsa_port_phylink_create() Yang Yingliang
2022-10-08 13:06 ` Vladimir Oltean
2022-10-09 19:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox