* [PATCH] maketable: clean up resources
@ 2022-10-12 9:35 gaoxingwang
2022-10-18 3:29 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: gaoxingwang @ 2022-10-12 9:35 UTC (permalink / raw)
To: netdev; +Cc: dsahern, gnault, stephen, liaichun, yanan
Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com>
---
netem/maketable.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/netem/maketable.c b/netem/maketable.c
index ccb8f0c6..f91ce221 100644
--- a/netem/maketable.c
+++ b/netem/maketable.c
@@ -230,5 +230,8 @@ main(int argc, char **argv)
inverse = inverttable(table, TABLESIZE, DISTTABLESIZE, total);
interpolatetable(inverse, TABLESIZE);
printtable(inverse, TABLESIZE);
+ free(table);
+ free(inverse)
+ close(fp);
return 0;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] maketable: clean up resources
2022-10-12 9:35 [PATCH] maketable: clean up resources gaoxingwang
@ 2022-10-18 3:29 ` Stephen Hemminger
2022-10-20 9:36 ` gaoxingwang
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2022-10-18 3:29 UTC (permalink / raw)
To: gaoxingwang; +Cc: netdev, dsahern, gnault, liaichun, yanan
On Wed, 12 Oct 2022 17:35:34 +0800
gaoxingwang <gaoxingwang1@huawei.com> wrote:
> Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com>
> ---
> netem/maketable.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/netem/maketable.c b/netem/maketable.c
> index ccb8f0c6..f91ce221 100644
> --- a/netem/maketable.c
> +++ b/netem/maketable.c
> @@ -230,5 +230,8 @@ main(int argc, char **argv)
> inverse = inverttable(table, TABLESIZE, DISTTABLESIZE, total);
> interpolatetable(inverse, TABLESIZE);
> printtable(inverse, TABLESIZE);
> + free(table);
> + free(inverse)
> + close(fp);
> return 0;
> }
Why bother. This is a tool only used during builds and this the end
of the main program so all resources will disappear after return.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] maketable: clean up resources
2022-10-18 3:29 ` Stephen Hemminger
@ 2022-10-20 9:36 ` gaoxingwang
0 siblings, 0 replies; 3+ messages in thread
From: gaoxingwang @ 2022-10-20 9:36 UTC (permalink / raw)
To: stephen; +Cc: dsahern, gaoxingwang1, gnault, liaichun, netdev, yanan
On Mon, 17 Oct 2022 20:29:14 -0700 [thread overview]
>On Wed, 12 Oct 2022 17:35:34 +0800
>gaoxingwang <gaoxingwang1@huawei.com> wrote:
>
>> Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com>
>> ---
>> netem/maketable.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/netem/maketable.c b/netem/maketable.c
>> index ccb8f0c6..f91ce221 100644
>> --- a/netem/maketable.c
>> +++ b/netem/maketable.c
>> @@ -230,5 +230,8 @@ main(int argc, char **argv)
>> inverse = inverttable(table, TABLESIZE, DISTTABLESIZE, total);
>> interpolatetable(inverse, TABLESIZE);
>> printtable(inverse, TABLESIZE);
>> + free(table);
>> + free(inverse)
>> + close(fp);
>> return 0;
>> }
>
>Why bother. This is a tool only used during builds and this the end
>of the main program so all resources will disappear after return.
I found this issue because a white box scan of the code. Maybe fixing this will save us from the effort to explain it.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-20 9:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-12 9:35 [PATCH] maketable: clean up resources gaoxingwang
2022-10-18 3:29 ` Stephen Hemminger
2022-10-20 9:36 ` gaoxingwang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox