[PATCH net-next v6 0/4] Implement devlink-rate API and extend it

[PATCH net-next v6 0/4] Implement devlink-rate API and extend it

[Michal Wilczynski]

This is a follow up on:
https://lore.kernel.org/netdev/20220915134239.1935604-1-michal.wilczynski@intel.com/

This patch series implements devlink-rate for ice driver. Unfortunately
current API isn't flexible enough for our use case, so there is a need to
extend it. Some functions have been introduced to enable the driver to
export current Tx scheduling configuration.

In the previous submission I've made a mistake and didn't remove
internal review comments. To avoid confusion I don't go backwards
in my versioning and submit it as v6.

This is a re-send, because I've send the previous patch during the time
that net-next was closed.
https://lore.kernel.org/netdev/20221011090113.445485-1-michal.wilczynski@intel.com/


V6:
- replaced strncpy with strscpy
- renamed rate_vport -> rate_leaf

V5:
- removed queue support per community request
- fix division of 64bit variable with 32bit divisor by using div_u64()
- remove RDMA, ADQ exlusion as it's not necessary anymore
- changed how driver exports configuration, as queues are not supported
  anymore
- changed IDA to Xarray for unique node identification


V4:
- changed static variable counter to per port IDA to
  uniquely identify nodes

V3:
- removed shift macros, since FIELD_PREP is used
- added static_assert for struct
- removed unnecessary functions
- used tab instead of space in define

V2:
- fixed Alexandr comments
- refactored code to fix checkpatch issues
- added mutual exclusion for RDMA, DCB


Michal Wilczynski (4):
  devlink: Extend devlink-rate api with export functions and new params
  ice: Introduce new parameters in ice_sched_node
  ice: Implement devlink-rate API
  ice: Prevent DCB coexistence with Custom Tx scheduler

 .../net/ethernet/intel/ice/ice_adminq_cmd.h   |   4 +-
 drivers/net/ethernet/intel/ice/ice_common.c   |   3 +
 drivers/net/ethernet/intel/ice/ice_dcb_lib.c  |   4 +
 drivers/net/ethernet/intel/ice/ice_devlink.c  | 467 ++++++++++++++++++
 drivers/net/ethernet/intel/ice/ice_devlink.h  |   2 +
 drivers/net/ethernet/intel/ice/ice_idc.c      |   5 +
 drivers/net/ethernet/intel/ice/ice_repr.c     |  13 +
 drivers/net/ethernet/intel/ice/ice_sched.c    |  79 ++-
 drivers/net/ethernet/intel/ice/ice_sched.h    |  25 +
 drivers/net/ethernet/intel/ice/ice_type.h     |   8 +
 .../mellanox/mlx5/core/esw/devlink_port.c     |   4 +-
 .../net/ethernet/mellanox/mlx5/core/esw/qos.c |   4 +-
 .../net/ethernet/mellanox/mlx5/core/esw/qos.h |   2 +-
 drivers/net/netdevsim/dev.c                   |  10 +-
 include/net/devlink.h                         |  21 +-
 include/uapi/linux/devlink.h                  |   3 +
 net/core/devlink.c                            | 145 +++++-
 17 files changed, 767 insertions(+), 32 deletions(-)

-- 
2.37.2

[PATCH net-next v6 0/4] Implement devlink-rate API and extend it

[Michal Wilczynski]

This is a follow up on:
https://lore.kernel.org/netdev/20220915134239.1935604-1-michal.wilczynski@intel.com/

This patch series implements devlink-rate for ice driver. Unfortunately
current API isn't flexible enough for our use case, so there is a need to
extend it. Some functions have been introduced to enable the driver to
export current Tx scheduling configuration.

In the previous submission I've made a mistake and didn't remove
internal review comments. To avoid confusion I don't go backwards
in my versioning and submit it as v6.

This is a re-send, because I've send the previous patch during the time
that net-next was closed.
https://lore.kernel.org/netdev/20221011090113.445485-1-michal.wilczynski@intel.com/


V6:
- replaced strncpy with strscpy
- renamed rate_vport -> rate_leaf

V5:
- removed queue support per community request
- fix division of 64bit variable with 32bit divisor by using div_u64()
- remove RDMA, ADQ exlusion as it's not necessary anymore
- changed how driver exports configuration, as queues are not supported
  anymore
- changed IDA to Xarray for unique node identification


V4:
- changed static variable counter to per port IDA to
  uniquely identify nodes

V3:
- removed shift macros, since FIELD_PREP is used
- added static_assert for struct
- removed unnecessary functions
- used tab instead of space in define

V2:
- fixed Alexandr comments
- refactored code to fix checkpatch issues
- added mutual exclusion for RDMA, DCB


Michal Wilczynski (4):
  devlink: Extend devlink-rate api with export functions and new params
  ice: Introduce new parameters in ice_sched_node
  ice: Implement devlink-rate API
  ice: Prevent DCB coexistence with Custom Tx scheduler

 .../net/ethernet/intel/ice/ice_adminq_cmd.h   |   4 +-
 drivers/net/ethernet/intel/ice/ice_common.c   |   3 +
 drivers/net/ethernet/intel/ice/ice_dcb_lib.c  |   4 +
 drivers/net/ethernet/intel/ice/ice_devlink.c  | 467 ++++++++++++++++++
 drivers/net/ethernet/intel/ice/ice_devlink.h  |   2 +
 drivers/net/ethernet/intel/ice/ice_idc.c      |   5 +
 drivers/net/ethernet/intel/ice/ice_repr.c     |  13 +
 drivers/net/ethernet/intel/ice/ice_sched.c    |  79 ++-
 drivers/net/ethernet/intel/ice/ice_sched.h    |  25 +
 drivers/net/ethernet/intel/ice/ice_type.h     |   8 +
 .../mellanox/mlx5/core/esw/devlink_port.c     |   4 +-
 .../net/ethernet/mellanox/mlx5/core/esw/qos.c |   4 +-
 .../net/ethernet/mellanox/mlx5/core/esw/qos.h |   2 +-
 drivers/net/netdevsim/dev.c                   |  10 +-
 include/net/devlink.h                         |  21 +-
 include/uapi/linux/devlink.h                  |   3 +
 net/core/devlink.c                            | 145 +++++-
 17 files changed, 767 insertions(+), 32 deletions(-)

-- 
2.37.2

Re: [PATCH net-next v6 0/4] Implement devlink-rate API and extend it

[Jiri Pirko]

Tue, Oct 18, 2022 at 02:35:38PM CEST, michal.wilczynski@intel.com wrote:
>This is a follow up on:
>https://lore.kernel.org/netdev/20220915134239.1935604-1-michal.wilczynski@intel.com/
>
>This patch series implements devlink-rate for ice driver. Unfortunately
>current API isn't flexible enough for our use case, so there is a need to
>extend it. Some functions have been introduced to enable the driver to
>export current Tx scheduling configuration.

This is not enough to be said in the cover letter. You need to clearly
explain the motivation, what is the problem you are trying to solve and
describe the solution. Also, provide example commands and outputs here.

Re: [PATCH net-next v6 0/4] Implement devlink-rate API and extend it

[Wilczynski, Michal]

On 10/18/2022 4:16 PM, Jiri Pirko wrote:
> Tue, Oct 18, 2022 at 02:35:38PM CEST, michal.wilczynski@intel.com wrote:
>> This is a follow up on:
>> https://lore.kernel.org/netdev/20220915134239.1935604-1-michal.wilczynski@intel.com/
>>
>> This patch series implements devlink-rate for ice driver. Unfortunately
>> current API isn't flexible enough for our use case, so there is a need to
>> extend it. Some functions have been introduced to enable the driver to
>> export current Tx scheduling configuration.
> This is not enough to be said in the cover letter. You need to clearly
> explain the motivation, what is the problem you are trying to solve and
> describe the solution. Also, provide example commands and outputs here.


Sure I will update the cover letter.
Maybe I'll paste some info from the third commit of this patch series.
It contains examples and more justification. Didn't want to
duplicate this, but maybe it'll help.

Thanks,
Michał