From: Vladimir Oltean <olteanv@gmail.com>
To: Christian Eggers <ceggers@arri.de>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Arun Ramadoss <arun.ramadoss@microchip.com>,
woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, linux@armlinux.org.uk,
Tristram.Ha@microchip.com, richardcochran@gmail.com
Subject: Re: [Patch net-next v2 01/13] net: dsa: microchip: ptp: add the posix clock support
Date: Tue, 6 Dec 2022 12:48:27 +0200 [thread overview]
Message-ID: <20221206104827.corkkthxmypegja7@skbuf> (raw)
In-Reply-To: <5892889.lOV4Wx5bFT@n95hx1g2>
On Tue, Dec 06, 2022 at 11:37:26AM +0100, Christian Eggers wrote:
> > v1 -> v2
> > - Deleted setting 8021_1as bit and added P2P bit in ksz_ptp_clock_register()
>
> did I miss the discussion about this change? I thought that the first goal is
> to use KSZ switches as a boundary clock which implies using the 802.1AS feature.
>
> Using the KSZ in P2P transparent clock mode IMHO requires writing the peer delays
> into switch registers (which needs to be implemented in a companion
> application/script for ptp4p).
>
> As far as I remember, there is also no support using ptp4l with 1-step transparent
> clock switches.
If it was in response to something I said, I just asked to add a comment
as to what the 802.1AS bit does, not to delete it...
next prev parent reply other threads:[~2022-12-06 10:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 9:14 [Patch net-next v2 00/13] net: dsa: microchip: add PTP support for KSZ9563/KSZ8563 and LAN937x Arun Ramadoss
2022-12-06 9:14 ` [Patch net-next v2 01/13] net: dsa: microchip: ptp: add the posix clock support Arun Ramadoss
2022-12-06 10:37 ` Christian Eggers
2022-12-06 10:48 ` Vladimir Oltean [this message]
2022-12-07 4:26 ` Arun.Ramadoss
2022-12-06 9:14 ` [Patch net-next v2 02/13] net: dsa: microchip: ptp: Initial hardware time stamping support Arun Ramadoss
2022-12-06 9:14 ` [Patch net-next v2 03/13] net: dsa: microchip: ptp: add 4 bytes in tail tag when ptp enabled Arun Ramadoss
2022-12-06 9:14 ` [Patch net-next v2 04/13] net: dsa: microchip: ptp: manipulating absolute time using ptp hw clock Arun Ramadoss
2022-12-06 9:14 ` [Patch net-next v2 05/13] net: dsa: microchip: ptp: enable interrupt for timestamping Arun Ramadoss
2022-12-06 9:14 ` [Patch net-next v2 06/13] net: ptp: add helper for one-step P2P clocks Arun Ramadoss
2022-12-06 16:38 ` Richard Cochran
2022-12-07 4:15 ` Arun.Ramadoss
2022-12-07 10:33 ` Vladimir Oltean
2022-12-06 9:14 ` [Patch net-next v2 07/13] net: dsa: microchip: ptp: add packet reception timestamping Arun Ramadoss
2022-12-06 12:53 ` Vladimir Oltean
2022-12-07 6:00 ` Arun.Ramadoss
2022-12-07 10:38 ` Vladimir Oltean
2022-12-06 9:14 ` [Patch net-next v2 08/13] net: dsa: microchip: ptp: add packet transmission timestamping Arun Ramadoss
2022-12-06 9:14 ` [Patch net-next v2 09/13] net: dsa: microchip: ptp: move pdelay_rsp correction field to tail tag Arun Ramadoss
2022-12-06 9:14 ` [Patch net-next v2 10/13] net: dsa: microchip: ptp: add periodic output signal Arun Ramadoss
2022-12-06 9:14 ` [Patch net-next v2 11/13] net: dsa: microchip: ptp: add support for perout programmable pins Arun Ramadoss
2022-12-06 9:14 ` [Patch net-next v2 12/13] net: dsa: microchip: ptp: lan937x: add 2 step timestamping Arun Ramadoss
2022-12-06 9:14 ` [Patch net-next v2 13/13] net: dsa: microchip: ptp: lan937x: Enable periodic output in LED pins Arun Ramadoss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221206104827.corkkthxmypegja7@skbuf \
--to=olteanv@gmail.com \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arun.ramadoss@microchip.com \
--cc=ceggers@arri.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox