From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com
Cc: Vinicius Costa Gomes <vinicius.gomes@intel.com>,
netdev@vger.kernel.org, anthony.l.nguyen@intel.com,
sasha.neftin@intel.com,
Aravindhan Gunasekaran <aravindhan.gunasekaran@intel.com>,
Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
Naama Meir <naamax.meir@linux.intel.com>
Subject: [PATCH net 2/6] igc: Use strict cycles for Qbv scheduling
Date: Thu, 15 Dec 2022 15:07:54 -0800 [thread overview]
Message-ID: <20221215230758.3595578-3-anthony.l.nguyen@intel.com> (raw)
In-Reply-To: <20221215230758.3595578-1-anthony.l.nguyen@intel.com>
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Configuring strict cycle mode in the controller forces more well
behaved transmissions when taprio is offloaded.
When set this strict_cycle and strict_end, transmission is not
enabled if the whole packet cannot be completed before end of
the Qbv cycle.
Fixes: 82faa9b79950 ("igc: Add support for ETF offloading")
Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Signed-off-by: Aravindhan Gunasekaran <aravindhan.gunasekaran@intel.com>
Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
drivers/net/ethernet/intel/igc/igc_tsn.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.c b/drivers/net/ethernet/intel/igc/igc_tsn.c
index f975ed807da1..684aedd4d088 100644
--- a/drivers/net/ethernet/intel/igc/igc_tsn.c
+++ b/drivers/net/ethernet/intel/igc/igc_tsn.c
@@ -140,15 +140,8 @@ static int igc_tsn_enable_offload(struct igc_adapter *adapter)
wr32(IGC_STQT(i), ring->start_time);
wr32(IGC_ENDQT(i), ring->end_time);
- if (adapter->base_time) {
- /* If we have a base_time we are in "taprio"
- * mode and we need to be strict about the
- * cycles: only transmit a packet if it can be
- * completed during that cycle.
- */
- txqctl |= IGC_TXQCTL_STRICT_CYCLE |
- IGC_TXQCTL_STRICT_END;
- }
+ txqctl |= IGC_TXQCTL_STRICT_CYCLE |
+ IGC_TXQCTL_STRICT_END;
if (ring->launchtime_enable)
txqctl |= IGC_TXQCTL_QUEUE_MODE_LAUNCHT;
--
2.35.1
next prev parent reply other threads:[~2022-12-15 23:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 23:07 [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2022-12-15 (igc) Tony Nguyen
2022-12-15 23:07 ` [PATCH net 1/6] igc: Enhance Qbv scheduling by using first flag bit Tony Nguyen
2022-12-15 23:07 ` Tony Nguyen [this message]
2022-12-15 23:07 ` [PATCH net 3/6] igc: Add checking for basetime less than zero Tony Nguyen
2022-12-15 23:07 ` [PATCH net 4/6] igc: allow BaseTime 0 enrollment for Qbv Tony Nguyen
2022-12-15 23:07 ` [PATCH net 5/6] igc: recalculate Qbv end_time by considering cycle time Tony Nguyen
2022-12-15 23:07 ` [PATCH net 6/6] igc: Set Qbv start_time and end_time to end_time if not being configured in GCL Tony Nguyen
2022-12-18 21:10 ` [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2022-12-15 (igc) patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221215230758.3595578-3-anthony.l.nguyen@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=aravindhan.gunasekaran@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=naamax.meir@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sasha.neftin@intel.com \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox