From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com
Cc: Tan Tee Min <tee.min.tan@linux.intel.com>,
netdev@vger.kernel.org, anthony.l.nguyen@intel.com,
sasha.neftin@intel.com,
Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
Naama Meir <naamax.meir@linux.intel.com>
Subject: [PATCH net 6/6] igc: Set Qbv start_time and end_time to end_time if not being configured in GCL
Date: Thu, 15 Dec 2022 15:07:58 -0800 [thread overview]
Message-ID: <20221215230758.3595578-7-anthony.l.nguyen@intel.com> (raw)
In-Reply-To: <20221215230758.3595578-1-anthony.l.nguyen@intel.com>
From: Tan Tee Min <tee.min.tan@linux.intel.com>
The default setting of end_time minus start_time is whole 1 second.
Thus, if it's not being configured in any GCL entry then it will be
staying at original 1 second.
This patch is changing the start_time and end_time to be end_time as
if setting zero will be having weird HW behavior where the gate will
not be fully closed.
Fixes: ec50a9d437f0 ("igc: Add support for taprio offloading")
Signed-off-by: Tan Tee Min <tee.min.tan@linux.intel.com>
Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
drivers/net/ethernet/intel/igc/igc_main.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index 86e46208d95c..44b1740dc098 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -6043,6 +6043,7 @@ static int igc_save_qbv_schedule(struct igc_adapter *adapter,
bool queue_configured[IGC_MAX_TX_QUEUES] = { };
u32 start_time = 0, end_time = 0;
size_t n;
+ int i;
adapter->qbv_enable = qopt->enable;
@@ -6063,7 +6064,6 @@ static int igc_save_qbv_schedule(struct igc_adapter *adapter,
for (n = 0; n < qopt->num_entries; n++) {
struct tc_taprio_sched_entry *e = &qopt->entries[n];
- int i;
end_time += e->interval;
@@ -6102,6 +6102,18 @@ static int igc_save_qbv_schedule(struct igc_adapter *adapter,
start_time += e->interval;
}
+ /* Check whether a queue gets configured.
+ * If not, set the start and end time to be end time.
+ */
+ for (i = 0; i < adapter->num_tx_queues; i++) {
+ if (!queue_configured[i]) {
+ struct igc_ring *ring = adapter->tx_ring[i];
+
+ ring->start_time = end_time;
+ ring->end_time = end_time;
+ }
+ }
+
return 0;
}
--
2.35.1
next prev parent reply other threads:[~2022-12-15 23:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 23:07 [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2022-12-15 (igc) Tony Nguyen
2022-12-15 23:07 ` [PATCH net 1/6] igc: Enhance Qbv scheduling by using first flag bit Tony Nguyen
2022-12-15 23:07 ` [PATCH net 2/6] igc: Use strict cycles for Qbv scheduling Tony Nguyen
2022-12-15 23:07 ` [PATCH net 3/6] igc: Add checking for basetime less than zero Tony Nguyen
2022-12-15 23:07 ` [PATCH net 4/6] igc: allow BaseTime 0 enrollment for Qbv Tony Nguyen
2022-12-15 23:07 ` [PATCH net 5/6] igc: recalculate Qbv end_time by considering cycle time Tony Nguyen
2022-12-15 23:07 ` Tony Nguyen [this message]
2022-12-18 21:10 ` [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2022-12-15 (igc) patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221215230758.3595578-7-anthony.l.nguyen@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=naamax.meir@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sasha.neftin@intel.com \
--cc=tee.min.tan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox