From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Dominique Martinet <asmadeus@codewreck.org>
Cc: James Chapman <jchapman@katalix.com>,
tparkin@katalix.com, edumazet@google.com, davem@davemloft.net,
kuba@kernel.org, pabeni@redhat.com, corbet@lwn.net,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PPPoL2TP: Add more code snippets
Date: Mon, 17 Apr 2023 00:43:16 +0200 [thread overview]
Message-ID: <20230416224316.xlvgjor65nejldwh@begin> (raw)
In-Reply-To: <ZDx2IUYTmLSdzU6D@codewreck.org>
Dominique Martinet, le lun. 17 avril 2023 07:26:41 +0900, a ecrit:
> > +The ppp<ifunit> interface can then be configured as usual with SIOCSIFMTU,
> > +SIOCSIFADDR, SIOCSIFDSTADDR, SIOCSIFNETMASK, and activated by setting IFF_UP
> > +with SIOCSIFFLAGS
>
> (That somewhat makes it sounds like the "new" netlink interface cannot
> be used (e.g. ip command);
Ah, right...
> although I guess sommeone implementing this would be more likely to
> use the ioctls than not so having the names can be a timesaver?)
It's indeed a timesaver to have the ioctl names, but perhaps we can
replace this part with a pointer to a if-configuration documentation?
> Also, this got me wondering if the 'if' fd can be closed immediately or
> if the interface will be removed when the fd is closed (probably not?)
Closing the fd would close the if, yes. AIUI one really has to keep the
pppox socket (for stats), the ppp chan (for non-data ppp packets), and
the ppp if (for the if).
Samuel
next prev parent reply other threads:[~2023-04-16 22:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-16 22:07 [PATCH] PPPoL2TP: Add more code snippets Samuel Thibault
2023-04-16 22:26 ` Dominique Martinet
2023-04-16 22:43 ` Samuel Thibault [this message]
2023-04-18 8:03 ` Guillaume Nault
2023-04-18 8:14 ` Guillaume Nault
2023-04-18 8:34 ` Guillaume Nault
2023-04-18 8:53 ` Samuel Thibault
2023-04-18 9:06 ` Guillaume Nault
2023-04-18 9:11 ` Samuel Thibault
2023-04-18 10:17 ` Guillaume Nault
2023-04-18 10:31 ` Samuel Thibault
2023-04-18 11:25 ` Guillaume Nault
2023-04-18 11:54 ` Samuel Thibault
2023-04-18 13:38 ` Guillaume Nault
2023-04-18 14:18 ` Samuel Thibault
2023-04-19 10:49 ` Tom Parkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230416224316.xlvgjor65nejldwh@begin \
--to=samuel.thibault@ens-lyon.org \
--cc=asmadeus@codewreck.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jchapman@katalix.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tparkin@katalix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox