From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 5/5] net: optimize napi_threaded_poll() vs RPS/RFS
Date: Fri, 21 Apr 2023 07:05:59 -0700 [thread overview]
Message-ID: <20230421070559.36a3e6a0@kernel.org> (raw)
In-Reply-To: <d84e9f5056c4945cb4cfcc68c89986d3094b95b7.camel@redhat.com>
On Fri, 21 Apr 2023 15:09:58 +0200 Paolo Abeni wrote:
> > #endif
> > +
> > bool in_net_rx_action;
> > + bool in_napi_threaded_poll;
>
> If I'm correct only one of the above 2 flags can be set to true at any
> give time. I'm wondering if could use a single flag (possibly with a
> rename - say 'in_napi_polling')?
>
> Otherwise LGTM, many thanks!
No strong feelings either way but FWIW my intuition would be that it's
less confusing to keep the two separate (there seems to be no cost to
it at this point) 🤷️
next prev parent reply other threads:[~2023-04-21 14:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 9:43 [PATCH net-next 0/5] net: give napi_threaded_poll() some love Eric Dumazet
2023-04-21 9:43 ` [PATCH net-next 1/5] net: add debugging checks in skb_attempt_defer_free() Eric Dumazet
2023-04-21 9:43 ` [PATCH net-next 2/5] net: do not provide hard irq safety for sd->defer_lock Eric Dumazet
2023-04-21 9:43 ` [PATCH net-next 3/5] net: move skb_defer_free_flush() up Eric Dumazet
2023-04-21 9:43 ` [PATCH net-next 4/5] net: make napi_threaded_poll() aware of sd->defer_list Eric Dumazet
2023-04-21 9:43 ` [PATCH net-next 5/5] net: optimize napi_threaded_poll() vs RPS/RFS Eric Dumazet
2023-04-21 13:09 ` Paolo Abeni
2023-04-21 14:05 ` Jakub Kicinski [this message]
2023-04-21 14:06 ` Eric Dumazet
2023-04-21 15:21 ` Paolo Abeni
2023-04-23 12:50 ` [PATCH net-next 0/5] net: give napi_threaded_poll() some love patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230421070559.36a3e6a0@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox