* dsa: mv88e6xxx: mv88e6321 rsvd2cpu
@ 2023-04-26 8:12 Angelo Dureghello
2023-04-26 13:23 ` Vladimir Oltean
2023-04-26 13:35 ` Andrew Lunn
0 siblings, 2 replies; 5+ messages in thread
From: Angelo Dureghello @ 2023-04-26 8:12 UTC (permalink / raw)
To: netdev; +Cc: Vladimir Oltean, Andrew Lunn
Hi all,
working on some rstp stuff at userspace level, (kernel stp
disabled), i have seen bpdu packets was forwarded over bridge
ports generating chaos and loops. As far as i know, 802.1d asks
bpdus are not forwarded.
Finally found a solution, adding mv88e6185_g2_mgmt_rsvd2cpu()
for mv88e6321.
Is it a proper solution ? Is there any specific reason why
rsvd2cpu was not implemented for my 6321 ?
I can send the patch i am using actually. in case.
Thanks a lot.
Regards,
--
angelo dureghello
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: dsa: mv88e6xxx: mv88e6321 rsvd2cpu
2023-04-26 8:12 dsa: mv88e6xxx: mv88e6321 rsvd2cpu Angelo Dureghello
@ 2023-04-26 13:23 ` Vladimir Oltean
2023-04-26 13:35 ` Andrew Lunn
1 sibling, 0 replies; 5+ messages in thread
From: Vladimir Oltean @ 2023-04-26 13:23 UTC (permalink / raw)
To: Angelo Dureghello; +Cc: netdev, Andrew Lunn
Hi Angelo,
On Wed, Apr 26, 2023 at 10:12:28AM +0200, Angelo Dureghello wrote:
> Hi all,
>
> working on some rstp stuff at userspace level, (kernel stp
> disabled), i have seen bpdu packets was forwarded over bridge
> ports generating chaos and loops. As far as i know, 802.1d asks
> bpdus are not forwarded.
>
> Finally found a solution, adding mv88e6185_g2_mgmt_rsvd2cpu()
> for mv88e6321.
> Is it a proper solution ? Is there any specific reason why
> rsvd2cpu was not implemented for my 6321 ?
> I can send the patch i am using actually. in case.
I don't know why mv88e6321_ops doesn't define a mgmt_rsvd2cpu()
implementation. I would agree that it is necessary, if available.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: dsa: mv88e6xxx: mv88e6321 rsvd2cpu
2023-04-26 8:12 dsa: mv88e6xxx: mv88e6321 rsvd2cpu Angelo Dureghello
2023-04-26 13:23 ` Vladimir Oltean
@ 2023-04-26 13:35 ` Andrew Lunn
2023-04-26 13:59 ` Angelo Dureghello
1 sibling, 1 reply; 5+ messages in thread
From: Andrew Lunn @ 2023-04-26 13:35 UTC (permalink / raw)
To: Angelo Dureghello; +Cc: netdev, Vladimir Oltean
On Wed, Apr 26, 2023 at 10:12:28AM +0200, Angelo Dureghello wrote:
> Hi all,
>
> working on some rstp stuff at userspace level, (kernel stp
> disabled), i have seen bpdu packets was forwarded over bridge
> ports generating chaos and loops. As far as i know, 802.1d asks
> bpdus are not forwarded.
>
> Finally found a solution, adding mv88e6185_g2_mgmt_rsvd2cpu()
> for mv88e6321.
> Is it a proper solution ? Is there any specific reason why
> rsvd2cpu was not implemented for my 6321 ?
> I can send the patch i am using actually. in case.
Should it be mv88e6185_g2_mgmt_rsvd2cpu() or
mv88e6352_g2_mgmt_rsvd2cpu()? Does the 6321 only support
01:80:c2:00:00:0x or does it have 01:80:c2:00:00:2x as well?
Please do send a patch, and include a Fixes: tag.
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: dsa: mv88e6xxx: mv88e6321 rsvd2cpu
2023-04-26 13:35 ` Andrew Lunn
@ 2023-04-26 13:59 ` Angelo Dureghello
2023-04-26 14:46 ` Vladimir Oltean
0 siblings, 1 reply; 5+ messages in thread
From: Angelo Dureghello @ 2023-04-26 13:59 UTC (permalink / raw)
To: Andrew Lunn; +Cc: netdev, Vladimir Oltean
Hi Andrew,
On 26/04/23 3:35 PM, Andrew Lunn wrote:
> On Wed, Apr 26, 2023 at 10:12:28AM +0200, Angelo Dureghello wrote:
>> Hi all,
>>
>> working on some rstp stuff at userspace level, (kernel stp
>> disabled), i have seen bpdu packets was forwarded over bridge
>> ports generating chaos and loops. As far as i know, 802.1d asks
>> bpdus are not forwarded.
>>
>> Finally found a solution, adding mv88e6185_g2_mgmt_rsvd2cpu()
>> for mv88e6321.
>> Is it a proper solution ? Is there any specific reason why
>> rsvd2cpu was not implemented for my 6321 ?
>> I can send the patch i am using actually. in case.
>
> Should it be mv88e6185_g2_mgmt_rsvd2cpu() or
> mv88e6352_g2_mgmt_rsvd2cpu()? Does the 6321 only support
> 01:80:c2:00:00:0x or does it have 01:80:c2:00:00:2x as well?
>
> Please do send a patch, and include a Fixes: tag.
>
you are right, it supports also the 01:80:c2:00:00:2x,
will test that too, and will send patch v2.
> Andrew
Thanks,
angelo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-04-26 14:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-26 8:12 dsa: mv88e6xxx: mv88e6321 rsvd2cpu Angelo Dureghello
2023-04-26 13:23 ` Vladimir Oltean
2023-04-26 13:35 ` Andrew Lunn
2023-04-26 13:59 ` Angelo Dureghello
2023-04-26 14:46 ` Vladimir Oltean
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox