Netdev List
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: arinc9.unal@gmail.com
Cc: "Arınç ÜNAL" <arinc.unal@arinc9.com>,
	"Daniel Golle" <daniel@makrotopia.org>,
	"Landen Chao" <Landen.Chao@mediatek.com>,
	"DENG Qingfang" <dqfext@gmail.com>,
	"Sean Wang" <sean.wang@mediatek.com>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Frank Wunderlich" <frank-w@public-files.de>,
	"Bartel Eerdekens" <bartel.eerdekens@constell8.be>,
	mithat.guner@xeront.com, erkin.bozoglu@xeront.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net v4 4/7] net: dsa: mt7530: fix handling of BPDUs on MT7530 switch
Date: Wed, 14 Jun 2023 23:50:08 +0300	[thread overview]
Message-ID: <20230614205008.czro45ogsc4c6sb5@skbuf> (raw)
In-Reply-To: <20230612075945.16330-5-arinc.unal@arinc9.com>

On Mon, Jun 12, 2023 at 10:59:42AM +0300, arinc9.unal@gmail.com wrote:
> From: Arınç ÜNAL <arinc.unal@arinc9.com>
> 
> BPDUs are link-local frames, therefore they must be trapped to the CPU
> port. Currently, the MT7530 switch treats BPDUs as regular multicast
> frames, therefore flooding them to user ports. To fix this, set BPDUs to be
> trapped to the CPU port.
> 
> BPDUs received from a user port will be trapped to the numerically smallest
> CPU port which is affine to the DSA conduit interface that is up.
> 
> Fixes: b8f126a8d543 ("net-next: dsa: add dsa support for Mediatek MT7530 switch")
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
>  drivers/net/dsa/mt7530.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
> index 2bde2fdb5fba..e4c169843f2e 100644
> --- a/drivers/net/dsa/mt7530.c
> +++ b/drivers/net/dsa/mt7530.c
> @@ -2259,6 +2259,10 @@ mt7530_setup(struct dsa_switch *ds)
>  
>  	priv->p6_interface = PHY_INTERFACE_MODE_NA;
>  
> +	/* Trap BPDUs to the CPU port */
> +	mt7530_rmw(priv, MT753X_BPC, MT753X_BPDU_PORT_FW_MASK,
> +		   MT753X_BPDU_CPU_ONLY);
> +
>  	/* Enable and reset MIB counters */
>  	mt7530_mib_reset(ds);
>  
> -- 
> 2.39.2
> 

Where have you seen the BPC register in the memory map of MT7530 or MT7621?

  reply	other threads:[~2023-06-14 20:50 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-12  7:59 [PATCH net v4 0/7] net: dsa: mt7530: fix multiple CPU ports, BPDU and LLDP handling arinc9.unal
2023-06-12  7:59 ` [PATCH net v4 1/7] net: dsa: mt7530: fix trapping frames with multiple CPU ports on MT7531 arinc9.unal
2023-06-14 19:43   ` Vladimir Oltean
2023-06-14 20:56     ` Arınç ÜNAL
2023-06-14 21:13       ` Vladimir Oltean
2023-06-14 21:40         ` Arınç ÜNAL
2023-06-12  7:59 ` [PATCH net v4 2/7] net: dsa: mt7530: fix trapping frames with multiple CPU ports on MT7530 arinc9.unal
2023-06-12 21:09   ` Russell King (Oracle)
2023-06-12 21:11     ` Russell King (Oracle)
2023-06-13 17:16     ` Arınç ÜNAL
2023-06-12  7:59 ` [PATCH net v4 3/7] net: dsa: mt7530: fix trapping frames on non-MT7621 SoC MT7530 switch arinc9.unal
2023-06-12 21:14   ` Russell King (Oracle)
2023-06-13 17:20     ` Arınç ÜNAL
2023-06-14 20:13   ` Vladimir Oltean
2023-06-14 20:59     ` Arınç ÜNAL
2023-06-14 21:19       ` Vladimir Oltean
2023-06-12  7:59 ` [PATCH net v4 4/7] net: dsa: mt7530: fix handling of BPDUs on " arinc9.unal
2023-06-14 20:50   ` Vladimir Oltean [this message]
2023-06-14 21:05     ` Arınç ÜNAL
2023-06-14 21:16       ` Vladimir Oltean
2023-06-14 21:43         ` Arınç ÜNAL
2023-06-12  7:59 ` [PATCH net v4 5/7] net: dsa: mt7530: fix handling of LLDP frames arinc9.unal
2023-06-14 16:35   ` Russell King (Oracle)
2023-06-14 20:48     ` Arınç ÜNAL
2023-06-14 16:42   ` Russell King (Oracle)
2023-06-14 20:52     ` Arınç ÜNAL
2023-06-14 21:43       ` Vladimir Oltean
2023-06-14 21:50         ` Arınç ÜNAL
2023-06-15 12:45     ` Bartel Eerdekens
2023-06-16  1:53       ` Arınç ÜNAL
2023-06-16  2:24         ` Arınç ÜNAL
2023-06-12  7:59 ` [PATCH net v4 6/7] net: dsa: introduce preferred_default_local_cpu_port and use on MT7530 arinc9.unal
2023-06-14 21:51   ` Vladimir Oltean
2023-06-12  7:59 ` [PATCH net v4 7/7] MAINTAINERS: add me as maintainer of MEDIATEK SWITCH DRIVER arinc9.unal
2023-06-12 11:37 ` [PATCH net v4 0/7] net: dsa: mt7530: fix multiple CPU ports, BPDU and LLDP handling Russell King (Oracle)
2023-06-12 20:52   ` Russell King (Oracle)
2023-06-12 21:30     ` Andrew Lunn
2023-06-13 16:51       ` Arınç ÜNAL

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230614205008.czro45ogsc4c6sb5@skbuf \
    --to=olteanv@gmail.com \
    --cc=Landen.Chao@mediatek.com \
    --cc=andrew@lunn.ch \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=arinc.unal@arinc9.com \
    --cc=arinc9.unal@gmail.com \
    --cc=bartel.eerdekens@constell8.be \
    --cc=daniel@makrotopia.org \
    --cc=davem@davemloft.net \
    --cc=dqfext@gmail.com \
    --cc=edumazet@google.com \
    --cc=erkin.bozoglu@xeront.com \
    --cc=f.fainelli@gmail.com \
    --cc=frank-w@public-files.de \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=matthias.bgg@gmail.com \
    --cc=mithat.guner@xeront.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sean.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox