Re: [v5,net-next]net: wwan: t7xx : V5 ptach upstream work

Re: [v5,net-next]net: wwan: t7xx : V5 ptach upstream work

[Bjorn Helgaas]

On Mon, Jun 5, 2023 at 7:43 AM Jinjian Song(Jack)
<Jinjian.Song@fibocom.com> wrote:

> I come from Fibocom and we were previously working on the joint development of the t7xx module with our colleagues form Intel and MTK.
>
> Now Fibocom will continue the work for V5 path upstream as bellow links:
>
> https://patchwork.kernel.org/project/netdevbpf/list/?series=714379&state=*

1) Linux development works on mailing lists that only accept
plain-text email; see http://vger.kernel.org/majordomo-info.html

2) I gave some fairly detailed feedback at
https://lore.kernel.org/all/20230127133034.GA1364550@bhelgaas/, but
the conversation stalled then.  I'm happy to answer more questions
about that if needed.

Bjorn

Re: [v5,net-next]net: wwan: t7xx : V5 ptach upstream work

[Jose Ignacio Tornos Martinez]

I have a proposal because at this moment with the current status, t7xx is not
functional due to problems like this if there is no activity:
[   57.370534] mtk_t7xx 0000:72:00.0: [PM] SAP suspend error: -110
[   57.370581] mtk_t7xx 0000:72:00.0: can't suspend
    (t7xx_pci_pm_runtime_suspend [mtk_t7xx] returned -110)
and after this the traffic is not working.

As yu know the situation was stalled and it seems that the final solution for
the complete series can take longer, so in order to have at least the modem
working, it would be enough if just the first commit of the series is
re-applied (d20ef656f994 net: wwan: t7xx: Add AP CLDMA). With that, the
Application Processor would be controlled, correctly suspended and the
commented problems would be fixed (I am testing here like this with no related
issue).

I think the first commit of the series is independent of the others and it can
be re-applied cleanly. Later on, the other commits related to fw flashing and 
coredump collection new features could be added taking into account Bjorn's 
comments (and of course updated doc if needed).

Thanks
Jose Ignacio

Re: [v5,net-next]net: wwan: t7xx : V5 ptach upstream work

[Bjorn Helgaas]

On Fri, Jun 23, 2023 at 05:01:42PM +0200, Jose Ignacio Tornos Martinez wrote:
> I have a proposal because at this moment with the current status, t7xx is not
> functional due to problems like this if there is no activity:
> [   57.370534] mtk_t7xx 0000:72:00.0: [PM] SAP suspend error: -110
> [   57.370581] mtk_t7xx 0000:72:00.0: can't suspend
>     (t7xx_pci_pm_runtime_suspend [mtk_t7xx] returned -110)
> and after this the traffic is not working.
> 
> As yu know the situation was stalled and it seems that the final solution for
> the complete series can take longer, so in order to have at least the modem
> working, it would be enough if just the first commit of the series is
> re-applied (d20ef656f994 net: wwan: t7xx: Add AP CLDMA). With that, the
> Application Processor would be controlled, correctly suspended and the
> commented problems would be fixed (I am testing here like this with no related
> issue).
> 
> I think the first commit of the series is independent of the others and it can
> be re-applied cleanly. Later on, the other commits related to fw flashing and 
> coredump collection new features could be added taking into account Bjorn's 
> comments (and of course updated doc if needed).

Please just post your proposal the usual way: send a patch that can be
directly applied, and send it to the maintainers of the file and the
relevant mailing lists.

Since d20ef656f994 affects drivers/net/wwan, this would be handled by
the WWAN folks.  From get_maintainers.pl:

  Loic Poulain <loic.poulain@linaro.org> (maintainer:WWAN DRIVERS)
  Sergey Ryazanov <ryazanov.s.a@gmail.com> (maintainer:WWAN DRIVERS)
  Johannes Berg <johannes@sipsolutions.net> (reviewer:WWAN DRIVERS)
  "David S. Miller" <davem@davemloft.net> (maintainer:NETWORKING DRIVERS)
  Eric Dumazet <edumazet@google.com> (maintainer:NETWORKING DRIVERS)
  Jakub Kicinski <kuba@kernel.org> (maintainer:NETWORKING DRIVERS)
  Paolo Abeni <pabeni@redhat.com> (maintainer:NETWORKING DRIVERS)
  netdev@vger.kernel.org (open list:WWAN DRIVERS)
  linux-kernel@vger.kernel.org (open list)

I'm confused about what happened with d20ef656f994 [1].  Git claims it
appeared in v6.1, and I don't see a revert of it, but I don't see the
code changes it made, e.g., the changes to t7xx_hw_info_init() [2].

Bjorn

[1] https://git.kernel.org/linus/d20ef656f994
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/wwan/t7xx/t7xx_hif_cldma.c?id=v6.4-rc7#n1063

答复: [v5,net-next]net: wwan: t7xx : V5 ptach upstream work

[Jinjian Song(Jack)]

Hi Bjorn, Jose

Let me send a patch that can be directly applied. 

Thanks.

-----邮件原件-----
发件人: Bjorn Helgaas <helgaas@kernel.org> 
发送时间: 2023年6月23日 23:29
收件人: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
抄送: bjorn.helgaas@gmail.com; Jinjian Song(Jack) <Jinjian.Song@fibocom.com>; Minlin He(Reid) <Reid.he@fibocom.com>; bjorn@helgaas.com; haijun.liu@mediatek.com; kuba@kernel.org; netdev@vger.kernel.org; Chongzhen Wang(Rafael) <rafael.wang@fibocom.com>; somashekhar.puttagangaiah@intel.com
主题: Re: [v5,net-next]net: wwan: t7xx : V5 ptach upstream work

On Fri, Jun 23, 2023 at 05:01:42PM +0200, Jose Ignacio Tornos Martinez wrote:
> I have a proposal because at this moment with the current status, t7xx 
> is not functional due to problems like this if there is no activity:
> [   57.370534] mtk_t7xx 0000:72:00.0: [PM] SAP suspend error: -110
> [   57.370581] mtk_t7xx 0000:72:00.0: can't suspend
>     (t7xx_pci_pm_runtime_suspend [mtk_t7xx] returned -110) and after 
> this the traffic is not working.
> 
> As yu know the situation was stalled and it seems that the final 
> solution for the complete series can take longer, so in order to have 
> at least the modem working, it would be enough if just the first 
> commit of the series is re-applied (d20ef656f994 net: wwan: t7xx: Add 
> AP CLDMA). With that, the Application Processor would be controlled, 
> correctly suspended and the commented problems would be fixed (I am 
> testing here like this with no related issue).
> 
> I think the first commit of the series is independent of the others 
> and it can be re-applied cleanly. Later on, the other commits related 
> to fw flashing and coredump collection new features could be added 
> taking into account Bjorn's comments (and of course updated doc if needed).

Please just post your proposal the usual way: send a patch that can be directly applied, and send it to the maintainers of the file and the relevant mailing lists.

Since d20ef656f994 affects drivers/net/wwan, this would be handled by the WWAN folks.  From get_maintainers.pl:

  Loic Poulain <loic.poulain@linaro.org> (maintainer:WWAN DRIVERS)
  Sergey Ryazanov <ryazanov.s.a@gmail.com> (maintainer:WWAN DRIVERS)
  Johannes Berg <johannes@sipsolutions.net> (reviewer:WWAN DRIVERS)
  "David S. Miller" <davem@davemloft.net> (maintainer:NETWORKING DRIVERS)
  Eric Dumazet <edumazet@google.com> (maintainer:NETWORKING DRIVERS)
  Jakub Kicinski <kuba@kernel.org> (maintainer:NETWORKING DRIVERS)
  Paolo Abeni <pabeni@redhat.com> (maintainer:NETWORKING DRIVERS)
  netdev@vger.kernel.org (open list:WWAN DRIVERS)
  linux-kernel@vger.kernel.org (open list)

I'm confused about what happened with d20ef656f994 [1].  Git claims it appeared in v6.1, and I don't see a revert of it, but I don't see the code changes it made, e.g., the changes to t7xx_hw_info_init() [2].

Bjorn

[1] https://git.kernel.org/linus/d20ef656f994
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/wwan/t7xx/t7xx_hif_cldma.c?id=v6.4-rc7#n1063

Re: [v5,net-next]net: wwan: t7xx : V5 ptach upstream work

[Jose Ignacio Tornos Martinez]

Thanks Bjorn, I will do as you comment.

Jinjian, I had already prepare it, we need to have something working
and then you can complete what you need for the pending features 
(fw flashing and coredump collection).

Thanks
Jose Ignacio

答复: [v5,net-next]net: wwan: t7xx : V5 ptach upstream work

[Jinjian Song(Jack)]

Hi Jose，

Since d20ef656f994 wwan: t7xx: Add AP CLDMA revert, there is V2 patch version about it, I think this patch is newer, as the link
https://patchwork.kernel.org/project/netdevbpf/patch/20230105154215.198828-1-m.chetan.kumar@linux.intel.com/

this patch modify the follow info:

v2:
 * Reuse handshake_wq for AP work.
 * Remove AP trace port tx/rx channel id.
 * Rename t7xx_md_port_conf to t7xx_port_conf.

Thanks

-----邮件原件-----
发件人: Jose Ignacio Tornos Martinez <jtornosm@redhat.com> 
发送时间: 2023年6月26日 16:20
收件人: Jinjian Song(Jack) <Jinjian.Song@fibocom.com>
抄送: Minlin He(Reid) <Reid.he@fibocom.com>; bjorn.helgaas@gmail.com; bjorn@helgaas.com; haijun.liu@mediatek.com; helgaas@kernel.org; jtornosm@redhat.com; kuba@kernel.org; netdev@vger.kernel.org; Chongzhen Wang(Rafael) <rafael.wang@fibocom.com>; somashekhar.puttagangaiah@intel.com
主题: Re: [v5,net-next]net: wwan: t7xx : V5 ptach upstream work

Thanks Bjorn, I will do as you comment.

Jinjian, I had already prepare it, we need to have something working and then you can complete what you need for the pending features (fw flashing and coredump collection).

Thanks
Jose Ignacio

Re: [v5,net-next]net: wwan: t7xx : V5 ptach upstream work

[Jose Ignacio Tornos Martinez]

Thanks Jinjian, you are right.
I will prepare a V2 patch with that update.

Jose Ignacio