Netdev List
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net,
	edumazet@google.com, jacob.e.keller@intel.com,
	johannes@sipsolutions.net
Subject: [patch net-next v3 03/10] tools: ynl-gen: render rsp_parse() helpers if cmd has only dump op
Date: Sat, 21 Oct 2023 13:27:04 +0200	[thread overview]
Message-ID: <20231021112711.660606-4-jiri@resnulli.us> (raw)
In-Reply-To: <20231021112711.660606-1-jiri@resnulli.us>

From: Jiri Pirko <jiri@nvidia.com>

Due to the check in RenderInfo class constructor, type_consistent
flag is set to False to avoid rendering the same response parsing
helper for do and dump ops. However, in case there is no do, the helper
needs to be rendered for dump op. So split check to achieve that.

Signed-off-by: Jiri Pirko <jiri@nvidia.com>
---
v1->v2:
- new patch
---
 tools/net/ynl/ynl-gen-c.py | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/tools/net/ynl/ynl-gen-c.py b/tools/net/ynl/ynl-gen-c.py
index 7d6c318397be..ed35a307c960 100755
--- a/tools/net/ynl/ynl-gen-c.py
+++ b/tools/net/ynl/ynl-gen-c.py
@@ -1112,10 +1112,13 @@ class RenderInfo:
 
         # 'do' and 'dump' response parsing is identical
         self.type_consistent = True
-        if op_mode != 'do' and 'dump' in op and 'do' in op:
-            if ('reply' in op['do']) != ('reply' in op["dump"]):
-                self.type_consistent = False
-            elif 'reply' in op['do'] and op["do"]["reply"] != op["dump"]["reply"]:
+        if op_mode != 'do' and 'dump' in op:
+            if 'do' in op:
+                if ('reply' in op['do']) != ('reply' in op["dump"]):
+                    self.type_consistent = False
+                elif 'reply' in op['do'] and op["do"]["reply"] != op["dump"]["reply"]:
+                    self.type_consistent = False
+            else:
                 self.type_consistent = False
 
         self.attr_set = attr_set
-- 
2.41.0


  parent reply	other threads:[~2023-10-21 11:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-21 11:27 [patch net-next v3 00/10] devlink: finish conversion to generated split_ops Jiri Pirko
2023-10-21 11:27 ` [patch net-next v3 01/10] genetlink: don't merge dumpit split op for different cmds into single iter Jiri Pirko
2023-10-21 11:27 ` [patch net-next v3 02/10] tools: ynl-gen: introduce support for bitfield32 attribute type Jiri Pirko
2023-10-21 11:27 ` Jiri Pirko [this message]
2023-10-21 11:27 ` [patch net-next v3 04/10] netlink: specs: devlink: remove reload-action from devlink-get cmd reply Jiri Pirko
2023-10-21 11:27 ` [patch net-next v3 05/10] netlink: specs: devlink: make dont-validate single line Jiri Pirko
2023-10-21 11:27 ` [patch net-next v3 06/10] devlink: make devlink_flash_overwrite enum named one Jiri Pirko
2023-10-21 11:27 ` [patch net-next v3 07/10] devlink: rename netlink callback to be aligned with the generated ones Jiri Pirko
2023-10-21 11:27 ` [patch net-next v3 08/10] netlink: specs: devlink: add the remaining command to generate complete split_ops Jiri Pirko
2023-10-21 16:04   ` kernel test robot
2023-10-22  9:46     ` Jiri Pirko
2023-10-21 11:27 ` [patch net-next v3 09/10] devlink: remove duplicated netlink callback prototypes Jiri Pirko
2023-10-21 11:27 ` [patch net-next v3 10/10] devlink: remove netlink small_ops Jiri Pirko
2023-10-23 20:23 ` [patch net-next v3 00/10] devlink: finish conversion to generated split_ops Jacob Keller
2023-10-23 23:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231021112711.660606-4-jiri@resnulli.us \
    --to=jiri@resnulli.us \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jacob.e.keller@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox