From: Jacob Keller <jacob.e.keller@intel.com>
To: Jiri Pirko <jiri@resnulli.us>, <netdev@vger.kernel.org>
Cc: <kuba@kernel.org>, <pabeni@redhat.com>, <davem@davemloft.net>,
<edumazet@google.com>, <johannes@sipsolutions.net>
Subject: Re: [patch net-next v3 00/10] devlink: finish conversion to generated split_ops
Date: Mon, 23 Oct 2023 13:23:55 -0700 [thread overview]
Message-ID: <e59c4744-65b7-4dbe-ab63-1eac550a498e@intel.com> (raw)
In-Reply-To: <20231021112711.660606-1-jiri@resnulli.us>
On 10/21/2023 4:27 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@nvidia.com>
>
> This patchset converts the remaining genetlink commands to generated
> split_ops and removes the existing small_ops arrays entirely
> alongside with shared netlink attribute policy.
>
> Patches #1-#6 are just small preparations and small fixes on multiple
> places. Note that couple of patches contain the "Fixes"
> tag but no need to put them into -net tree.
> Patch #7 is a simple rename preparation
> Patch #8 is the main one in this set and adds actual definitions of cmds
> in to yaml file.
> Patches #9-#10 finalize the change removing bits that are no longer in
> use.
>
> ---
Everything in this version looks good to me.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> v2->v3:
> - just small fix and rebase in patch #2
> v1->v2:
> - see individual patches for changelog
> - patch #3 is new
> - patch "netlink: specs: devlink: fix reply command values" was removed
> from the set and sent separately to -net
>
> Jiri Pirko (10):
> genetlink: don't merge dumpit split op for different cmds into single
> iter
> tools: ynl-gen: introduce support for bitfield32 attribute type
> tools: ynl-gen: render rsp_parse() helpers if cmd has only dump op
> netlink: specs: devlink: remove reload-action from devlink-get cmd
> reply
> netlink: specs: devlink: make dont-validate single line
> devlink: make devlink_flash_overwrite enum named one
> devlink: rename netlink callback to be aligned with the generated ones
> netlink: specs: devlink: add the remaining command to generate
> complete split_ops
> devlink: remove duplicated netlink callback prototypes
> devlink: remove netlink small_ops
>
> Documentation/netlink/genetlink-legacy.yaml | 2 +-
> Documentation/netlink/specs/devlink.yaml | 1604 +++++-
> .../netlink/genetlink-legacy.rst | 2 +-
> include/uapi/linux/devlink.h | 2 +-
> net/devlink/dev.c | 10 +-
> net/devlink/devl_internal.h | 64 -
> net/devlink/dpipe.c | 14 +-
> net/devlink/health.c | 24 +-
> net/devlink/linecard.c | 3 +-
> net/devlink/netlink.c | 328 +-
> net/devlink/netlink_gen.c | 757 ++-
> net/devlink/netlink_gen.h | 64 +-
> net/devlink/param.c | 14 +-
> net/devlink/port.c | 11 +-
> net/devlink/rate.c | 6 +-
> net/devlink/region.c | 8 +-
> net/devlink/resource.c | 4 +-
> net/devlink/sb.c | 17 +-
> net/devlink/trap.c | 9 +-
> net/netlink/genetlink.c | 3 +-
> tools/net/ynl/generated/devlink-user.c | 5075 +++++++++++++++--
> tools/net/ynl/generated/devlink-user.h | 4213 ++++++++++++--
> tools/net/ynl/lib/ynl.c | 6 +
> tools/net/ynl/lib/ynl.h | 1 +
> tools/net/ynl/lib/ynl.py | 13 +-
> tools/net/ynl/ynl-gen-c.py | 50 +-
> 26 files changed, 10644 insertions(+), 1660 deletions(-)
>
next prev parent reply other threads:[~2023-10-23 20:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-21 11:27 [patch net-next v3 00/10] devlink: finish conversion to generated split_ops Jiri Pirko
2023-10-21 11:27 ` [patch net-next v3 01/10] genetlink: don't merge dumpit split op for different cmds into single iter Jiri Pirko
2023-10-21 11:27 ` [patch net-next v3 02/10] tools: ynl-gen: introduce support for bitfield32 attribute type Jiri Pirko
2023-10-21 11:27 ` [patch net-next v3 03/10] tools: ynl-gen: render rsp_parse() helpers if cmd has only dump op Jiri Pirko
2023-10-21 11:27 ` [patch net-next v3 04/10] netlink: specs: devlink: remove reload-action from devlink-get cmd reply Jiri Pirko
2023-10-21 11:27 ` [patch net-next v3 05/10] netlink: specs: devlink: make dont-validate single line Jiri Pirko
2023-10-21 11:27 ` [patch net-next v3 06/10] devlink: make devlink_flash_overwrite enum named one Jiri Pirko
2023-10-21 11:27 ` [patch net-next v3 07/10] devlink: rename netlink callback to be aligned with the generated ones Jiri Pirko
2023-10-21 11:27 ` [patch net-next v3 08/10] netlink: specs: devlink: add the remaining command to generate complete split_ops Jiri Pirko
2023-10-21 16:04 ` kernel test robot
2023-10-22 9:46 ` Jiri Pirko
2023-10-21 11:27 ` [patch net-next v3 09/10] devlink: remove duplicated netlink callback prototypes Jiri Pirko
2023-10-21 11:27 ` [patch net-next v3 10/10] devlink: remove netlink small_ops Jiri Pirko
2023-10-23 20:23 ` Jacob Keller [this message]
2023-10-23 23:50 ` [patch net-next v3 00/10] devlink: finish conversion to generated split_ops patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e59c4744-65b7-4dbe-ab63-1eac550a498e@intel.com \
--to=jacob.e.keller@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox