Re: [EXTERNAL] [PATCH v7 net-next 6/8] net: ethernet: ti: am65-cpsw-qos: Add Frame Preemption MAC Merge support

[Vladimir Oltean <vladimir.oltean@nxp.com>]

On Mon, Dec 04, 2023 at 11:30:53AM +0200, Roger Quadros wrote:
> >> Due to Silicon Errata i2208 [2] we set limit min IET fragment size to 124.
> > 
> > Should be 128 not 124
> 
> User space setting is without FCS.

Technically it's called mCRC for preemptible frames, but yes.

> >> +	/* Errata i2208: RX min fragment size cannot be less than 124 */
> >> +	state->rx_min_frag_size = 124;
> > 
> > /* Errata i2208: RX min fragment size cannot be less than 128 */
> > state->rx_min_frag_size = 128;
> 
> ethtool man page says
> "           tx-min-frag-size
>                   Shows the minimum size (in octets) of transmitted non-
>                   final fragments which can be received by the link
>                   partner. Corresponds to the standard addFragSize
>                   variable using the formula:
> 
>                   tx-min-frag-size = 64 * (1 + addFragSize) - 4"
> 
> Which means user needs to put a -4 offset i.e. drop FCS size.
> 
> Drivers show rx-min-frag-size also without the FCS.
> 
> e.g.
> https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/mscc/ocelot_mm.c#L260

Ack.