From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Roger Quadros <rogerq@kernel.org>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, s-vadapalli@ti.com, r-gunasekaran@ti.com,
vigneshr@ti.com, srk@ti.com, horms@kernel.org, p-varis@ti.com,
netdev@vger.kernel.org
Subject: Re: [PATCH v7 net-next 5/8] net: ethernet: ti: am65-cpsw: add mqprio qdisc offload in channel mode
Date: Mon, 4 Dec 2023 15:48:30 +0200 [thread overview]
Message-ID: <20231204134830.uqz5xi7h7utnou7q@skbuf> (raw)
In-Reply-To: <20231201135802.28139-6-rogerq@kernel.org> <20231201135802.28139-6-rogerq@kernel.org>
On Fri, Dec 01, 2023 at 03:57:59PM +0200, Roger Quadros wrote:
> diff --git a/drivers/net/ethernet/ti/am65-cpsw-qos.c b/drivers/net/ethernet/ti/am65-cpsw-qos.c
> index 49ae9d1cd948..2733bac55bfa 100644
> --- a/drivers/net/ethernet/ti/am65-cpsw-qos.c
> +++ b/drivers/net/ethernet/ti/am65-cpsw-qos.c
> @@ -15,6 +15,8 @@
> #include "am65-cpts.h"
> #include "cpsw_ale.h"
>
> +#define TO_MBPS(x) ((x) * 8 / 1000000)
Can be rewritten as ((x) * BITS_PER_BYTE / MEGA)
and further as ((x) / BYTES_PER_MBIT).
Also, I wonder if it wouldn't be better to do a DIV_ROUND_UP(x, BYTES_PER_MBIT)
instead. When user space requests a certain bandwidth, it expects to get it.
If the hardware is not fine grained enough, it should prefer giving it slightly
more rather than slightly less.
next prev parent reply other threads:[~2023-12-04 13:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 13:57 [PATCH v7 net-next 0/8] net: ethernet: am65-cpsw: Add mqprio, frame pre-emption & coalescing Roger Quadros
2023-12-01 13:57 ` [PATCH v7 net-next 1/8] net: ethernet: am65-cpsw: Build am65-cpsw-qos only if required Roger Quadros
2023-12-01 13:57 ` [PATCH v7 net-next 2/8] net: ethernet: am65-cpsw: cleanup TAPRIO handling Roger Quadros
2023-12-04 13:38 ` Vladimir Oltean
2023-12-01 13:57 ` [PATCH v7 net-next 3/8] net: ethernet: ti: am65-cpsw: Move code to avoid forward declaration Roger Quadros
2023-12-01 13:57 ` [PATCH v7 net-next 4/8] net: ethernet: am65-cpsw: Move register definitions to header file Roger Quadros
2023-12-01 13:57 ` [PATCH v7 net-next 5/8] net: ethernet: ti: am65-cpsw: add mqprio qdisc offload in channel mode Roger Quadros
2023-12-04 13:48 ` Vladimir Oltean [this message]
2023-12-01 13:58 ` [PATCH v7 net-next 6/8] net: ethernet: ti: am65-cpsw-qos: Add Frame Preemption MAC Merge support Roger Quadros
2023-12-01 16:01 ` [EXTERNAL] " Varis, Pekka
2023-12-04 9:30 ` Roger Quadros
2023-12-04 11:02 ` Vladimir Oltean
2023-12-04 11:10 ` Vladimir Oltean
2023-12-04 12:35 ` Vladimir Oltean
2023-12-08 10:13 ` Roger Quadros
2023-12-08 10:26 ` Roger Quadros
2023-12-08 12:33 ` Roger Quadros
2023-12-11 12:12 ` Vladimir Oltean
2023-12-11 12:14 ` Roger Quadros
2023-12-11 12:11 ` Vladimir Oltean
2023-12-11 12:25 ` Roger Quadros
2023-12-11 13:26 ` Vladimir Oltean
2023-12-07 15:24 ` Vladimir Oltean
2023-12-08 13:43 ` Roger Quadros
2023-12-11 13:29 ` Vladimir Oltean
2023-12-11 13:59 ` Roger Quadros
2023-12-01 13:58 ` [PATCH v7 net-next 7/8] net: ethernet: ti: am65-cpsw: add sw tx/rx irq coalescing based on hrtimers Roger Quadros
2023-12-01 13:58 ` [PATCH v7 net-next 8/8] selftests: forwarding: ethtool_mm: support devices with higher rx-min-frag-size Roger Quadros
2023-12-04 11:13 ` Vladimir Oltean
2023-12-04 12:36 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204134830.uqz5xi7h7utnou7q@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p-varis@ti.com \
--cc=pabeni@redhat.com \
--cc=r-gunasekaran@ti.com \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox