From: Vladimir Oltean <olteanv@gmail.com>
To: Sean Nyekjaer <sean@geanix.com>
Cc: Arun.Ramadoss@microchip.com, Woojung.Huh@microchip.com,
UNGLinuxDriver@microchip.com, andrew@lunn.ch,
f.fainelli@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define
Date: Wed, 6 Dec 2023 17:58:18 +0200 [thread overview]
Message-ID: <20231206155818.p5ll7au2mwqipvf3@skbuf> (raw)
In-Reply-To: <B0DA4901-0C2F-4D4D-966F-BF89C67219DD@geanix.com>
On Wed, Dec 06, 2023 at 10:00:52AM +0100, Sean Nyekjaer wrote:
> Hi Arun,
>
> > On 6 Dec 2023, at 09.58, <Arun.Ramadoss@microchip.com> <Arun.Ramadoss@microchip.com> wrote:
> >
> > Hi Sean,
> >
> >> -----Original Message-----
> >> Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to
> >> DSA_TAG_PROTO_LAN937X to improve readability.
> >>
> >> Fixes: 99b16df0cd52 ("net: dsa: microchip: lan937x: add dsa_tag_protocol")
> >> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> >
> > Not sure, whether it is a bug fix or not. Since it only improves readability.
> > I believe it should point to net-next.
> >
>
> Agree :)
>
> Feel free to remove the Fixes tag while applying.
>
> /Sean
If you're talking to Arun: he can't do that. Only Jakub, David, Paolo
and Eric can apply patches, and based on history, I don't think that
either of them is keen on editing patches before applying. One way or
another, based on past experience, you might be better off just resending,
with the Fixes tag dropped, and patch retargeted to net-next (and
counter incremented to v2).
The criteria from Documentation/process/stable-kernel-rules.rst still
apply pretty much to net.git as well, since these patches land in stable
trees too. We triage as much as possible, to give users of stable
kernels a worthwhile reason to update, not a change that results in
absolutely the same generated machine code.
prev parent reply other threads:[~2023-12-06 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 7:24 [PATCH net] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define Sean Nyekjaer
2023-12-06 8:58 ` Arun.Ramadoss
2023-12-06 9:00 ` Sean Nyekjaer
2023-12-06 15:58 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206155818.p5ll7au2mwqipvf3@skbuf \
--to=olteanv@gmail.com \
--cc=Arun.Ramadoss@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox