From: Sean Nyekjaer <sean@geanix.com>
To: Arun.Ramadoss@microchip.com
Cc: Woojung.Huh@microchip.com, UNGLinuxDriver@microchip.com,
andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define
Date: Wed, 6 Dec 2023 10:00:52 +0100 [thread overview]
Message-ID: <B0DA4901-0C2F-4D4D-966F-BF89C67219DD@geanix.com> (raw)
In-Reply-To: <DM5PR11MB0076D755B7492A38337A6A7DEF84A@DM5PR11MB0076.namprd11.prod.outlook.com>
Hi Arun,
> On 6 Dec 2023, at 09.58, <Arun.Ramadoss@microchip.com> <Arun.Ramadoss@microchip.com> wrote:
>
> Hi Sean,
>
>> -----Original Message-----
>> From: Sean Nyekjaer <sean@geanix.com>
>> Sent: Wednesday, December 6, 2023 12:55 PM
>> To: Woojung Huh - C21699 <Woojung.Huh@microchip.com>;
>> UNGLinuxDriver <UNGLinuxDriver@microchip.com>; Andrew Lunn
>> <andrew@lunn.ch>; Florian Fainelli <f.fainelli@gmail.com>; Vladimir Oltean
>> <olteanv@gmail.com>; David S. Miller <davem@davemloft.net>; Eric
>> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>;
>> Paolo Abeni <pabeni@redhat.com>; Arun Ramadoss - I17769
>> <Arun.Ramadoss@microchip.com>
>> Cc: Sean Nyekjaer <sean@geanix.com>; netdev@vger.kernel.org; linux-
>> kernel@vger.kernel.org
>> Subject: [PATCH net] net: dsa: microchip: use DSA_TAG_PROTO without
>> _VALUE define
>>
>> [Some people who received this message don't often get email from
>> sean@geanix.com. Learn why this is important at
>> https://aka.ms/LearnAboutSenderIdentification ]
>>
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
>> content is safe
>>
>> Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to
>> DSA_TAG_PROTO_LAN937X to improve readability.
>>
>> Fixes: 99b16df0cd52 ("net: dsa: microchip: lan937x: add dsa_tag_protocol")
>> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
>
> Not sure, whether it is a bug fix or not. Since it only improves readability.
> I believe it should point to net-next.
>
Agree :)
Feel free to remove the Fixes tag while applying.
/Sean
next prev parent reply other threads:[~2023-12-06 9:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 7:24 [PATCH net] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define Sean Nyekjaer
2023-12-06 8:58 ` Arun.Ramadoss
2023-12-06 9:00 ` Sean Nyekjaer [this message]
2023-12-06 15:58 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B0DA4901-0C2F-4D4D-966F-BF89C67219DD@geanix.com \
--to=sean@geanix.com \
--cc=Arun.Ramadoss@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).