From: Vladimir Oltean <olteanv@gmail.com>
To: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Cc: "Alvin Šipraga" <ALSI@bang-olufsen.dk>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"arinc.unal@arinc9.com" <arinc.unal@arinc9.com>
Subject: Re: [net-next 2/2] net: dsa: realtek: load switch variants on demand
Date: Fri, 8 Dec 2023 00:31:43 +0200 [thread overview]
Message-ID: <20231207223143.doivjphfgs4sfvx6@skbuf> (raw)
In-Reply-To: <CAJq09z7j_gNbUcYDWXjzUNAXat-+EyryFJFEqpVG-jPcY4ZmmQ@mail.gmail.com>
On Thu, Dec 07, 2023 at 04:50:12PM -0300, Luiz Angelo Daros de Luca wrote:
> HI Vladmir,
>
> We discussed something about that in the past:
>
> https://lkml.kernel.org/netdev/20220630200423.tieprdu5fpabflj7@bang-olufsen.dk/T/#m04e6cf7d0c1f18b02c2bf40266ada915b1f02f3d
>
> The code is able to handle only a single node and binding docs say it
> should be named "mdio". The compatible string wasn't a requirement
> since the beginning and I don't think it is worth it to rename the
> compatible string. I suggest we simply switch to
> of_get_child_by_name() and look for a node named "mdio". If that node
> is not found, we can still look for the old compatible string
> (backwards compatibility) and probably warn the "user" (targeting not
> the end-user but the one creating the DT for a new device).
>
> I don't know how to handle the binding docs as the compatible string
> is still a requirement for older kernel versions. Is it ok to update
> the device-tree bindings docs in such a way it would break old
> drivers? Or should we keep it there until the last LTS kernel
> requiring it reaches EOL? As device-tree bindings docs should not
> consider how the driver was implemented, I think it would be strange
> to have a note like "required by kernel up to 6.x".
>
> Regards,
>
> Luiz
And did you ever answer this question?
"And why do you even need to remove the compatible string from the MDIO
node, can't you just ignore it, does it bother you in any way?"
I'm very confused as to what you're after.
next prev parent reply other threads:[~2023-12-07 22:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 23:49 [net-next 0/2] net: dsa: realtek: Introduce realtek_common, load variants on demand Luiz Angelo Daros de Luca
2023-11-17 23:50 ` [net-next 1/2] net: dsa: realtek: create realtek-common Luiz Angelo Daros de Luca
2023-11-19 12:13 ` Vladimir Oltean
2023-11-19 12:20 ` Vladimir Oltean
2023-11-17 23:50 ` [net-next 2/2] net: dsa: realtek: load switch variants on demand Luiz Angelo Daros de Luca
2023-11-19 12:19 ` Vladimir Oltean
2023-11-20 9:20 ` Krzysztof Kozlowski
2023-11-20 13:48 ` Vladimir Oltean
2023-11-20 14:07 ` Krzysztof Kozlowski
2023-11-21 14:40 ` Luiz Angelo Daros de Luca
2023-11-21 22:15 ` Krzysztof Kozlowski
2023-11-21 22:35 ` Krzysztof Kozlowski
2023-11-22 22:44 ` Luiz Angelo Daros de Luca
2023-11-23 2:05 ` Alvin Šipraga
2023-11-27 22:24 ` Luiz Angelo Daros de Luca
2023-12-07 17:02 ` Vladimir Oltean
2023-12-07 20:22 ` Luiz Angelo Daros de Luca
2023-12-07 17:19 ` Vladimir Oltean
2023-12-07 19:50 ` Luiz Angelo Daros de Luca
2023-12-07 22:31 ` Vladimir Oltean [this message]
2023-12-08 2:46 ` Luiz Angelo Daros de Luca
2023-12-11 18:01 ` Vladimir Oltean
2023-11-25 7:10 ` Dan Carpenter
2023-11-17 23:57 ` [net-next 0/2] net: dsa: realtek: Introduce realtek_common, load " Luiz Angelo Daros de Luca
2023-11-18 0:44 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207223143.doivjphfgs4sfvx6@skbuf \
--to=olteanv@gmail.com \
--cc=ALSI@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=arinc.unal@arinc9.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=luizluca@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox