From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev,
Luiz Angelo Daros de Luca <luizluca@gmail.com>,
netdev@vger.kernel.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linus.walleij@linaro.org, alsi@bang-olufsen.dk, andrew@lunn.ch,
f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
arinc.unal@arinc9.com,
Luiz Angelo Daros de Luca <luizluca@gmail.com>
Subject: Re: [net-next 2/2] net: dsa: realtek: load switch variants on demand
Date: Sat, 25 Nov 2023 10:10:22 +0300 [thread overview]
Message-ID: <78a4a47d-cde1-4c2c-999c-6f76b5fa9c87@suswa.mountain> (raw)
In-Reply-To: <20231117235140.1178-3-luizluca@gmail.com>
Hi Luiz,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Luiz-Angelo-Daros-de-Luca/net-dsa-realtek-create-realtek-common/20231118-075444
base: net-next/main
patch link: https://lore.kernel.org/r/20231117235140.1178-3-luizluca%40gmail.com
patch subject: [net-next 2/2] net: dsa: realtek: load switch variants on demand
config: mips-randconfig-r081-20231121 (https://download.01.org/0day-ci/archive/20231125/202311251132.QKdGl71R-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231125/202311251132.QKdGl71R-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202311251132.QKdGl71R-lkp@intel.com/
smatch warnings:
drivers/net/dsa/realtek/realtek-smi.c:418 realtek_smi_probe() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +418 drivers/net/dsa/realtek/realtek-smi.c
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 398 static int realtek_smi_probe(struct platform_device *pdev)
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 399 {
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 400 struct device *dev = &pdev->dev;
f5f119077b1cd6 drivers/net/dsa/realtek/realtek-smi-core.c Luiz Angelo Daros de Luca 2022-01-28 401 struct realtek_priv *priv;
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 402 int ret;
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 403
217d45f6e61f5d drivers/net/dsa/realtek/realtek-smi.c Luiz Angelo Daros de Luca 2023-11-17 404 priv = realtek_common_probe(dev, realtek_smi_regmap_config,
217d45f6e61f5d drivers/net/dsa/realtek/realtek-smi.c Luiz Angelo Daros de Luca 2023-11-17 405 realtek_smi_nolock_regmap_config);
217d45f6e61f5d drivers/net/dsa/realtek/realtek-smi.c Luiz Angelo Daros de Luca 2023-11-17 406 if (IS_ERR(priv))
217d45f6e61f5d drivers/net/dsa/realtek/realtek-smi.c Luiz Angelo Daros de Luca 2023-11-17 407 return PTR_ERR(priv);
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 408
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 409 /* Fetch MDIO pins */
f5f119077b1cd6 drivers/net/dsa/realtek/realtek-smi-core.c Luiz Angelo Daros de Luca 2022-01-28 410 priv->mdc = devm_gpiod_get_optional(dev, "mdc", GPIOD_OUT_LOW);
7e61e799f3f92c drivers/net/dsa/realtek/realtek-smi.c Luiz Angelo Daros de Luca 2023-11-17 411 if (IS_ERR(priv->mdc)) {
7e61e799f3f92c drivers/net/dsa/realtek/realtek-smi.c Luiz Angelo Daros de Luca 2023-11-17 412 ret = PTR_ERR(priv->mdc);
7e61e799f3f92c drivers/net/dsa/realtek/realtek-smi.c Luiz Angelo Daros de Luca 2023-11-17 413 goto err_variant_put;
7e61e799f3f92c drivers/net/dsa/realtek/realtek-smi.c Luiz Angelo Daros de Luca 2023-11-17 414 }
217d45f6e61f5d drivers/net/dsa/realtek/realtek-smi.c Luiz Angelo Daros de Luca 2023-11-17 415
f5f119077b1cd6 drivers/net/dsa/realtek/realtek-smi-core.c Luiz Angelo Daros de Luca 2022-01-28 416 priv->mdio = devm_gpiod_get_optional(dev, "mdio", GPIOD_OUT_LOW);
7e61e799f3f92c drivers/net/dsa/realtek/realtek-smi.c Luiz Angelo Daros de Luca 2023-11-17 417 if (IS_ERR(priv->mdio)) {
7e61e799f3f92c drivers/net/dsa/realtek/realtek-smi.c Luiz Angelo Daros de Luca 2023-11-17 @418 ret = PTR_ERR(priv->mdc);
s/mdc/mdio/.
7e61e799f3f92c drivers/net/dsa/realtek/realtek-smi.c Luiz Angelo Daros de Luca 2023-11-17 419 goto err_variant_put;
7e61e799f3f92c drivers/net/dsa/realtek/realtek-smi.c Luiz Angelo Daros de Luca 2023-11-17 420 }
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 421
217d45f6e61f5d drivers/net/dsa/realtek/realtek-smi.c Luiz Angelo Daros de Luca 2023-11-17 422 priv->setup_interface = realtek_smi_setup_mdio;
217d45f6e61f5d drivers/net/dsa/realtek/realtek-smi.c Luiz Angelo Daros de Luca 2023-11-17 423 priv->write_reg_noack = realtek_smi_write_reg_noack;
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 424
f5f119077b1cd6 drivers/net/dsa/realtek/realtek-smi-core.c Luiz Angelo Daros de Luca 2022-01-28 425 ret = priv->ops->detect(priv);
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 426 if (ret) {
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 427 dev_err(dev, "unable to detect switch\n");
7e61e799f3f92c drivers/net/dsa/realtek/realtek-smi.c Luiz Angelo Daros de Luca 2023-11-17 428 goto err_variant_put;
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 429 }
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 430
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-11-25 7:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 23:49 [net-next 0/2] net: dsa: realtek: Introduce realtek_common, load variants on demand Luiz Angelo Daros de Luca
2023-11-17 23:50 ` [net-next 1/2] net: dsa: realtek: create realtek-common Luiz Angelo Daros de Luca
2023-11-19 12:13 ` Vladimir Oltean
2023-11-19 12:20 ` Vladimir Oltean
2023-11-17 23:50 ` [net-next 2/2] net: dsa: realtek: load switch variants on demand Luiz Angelo Daros de Luca
2023-11-19 12:19 ` Vladimir Oltean
2023-11-20 9:20 ` Krzysztof Kozlowski
2023-11-20 13:48 ` Vladimir Oltean
2023-11-20 14:07 ` Krzysztof Kozlowski
2023-11-21 14:40 ` Luiz Angelo Daros de Luca
2023-11-21 22:15 ` Krzysztof Kozlowski
2023-11-21 22:35 ` Krzysztof Kozlowski
2023-11-22 22:44 ` Luiz Angelo Daros de Luca
2023-11-23 2:05 ` Alvin Šipraga
2023-11-27 22:24 ` Luiz Angelo Daros de Luca
2023-12-07 17:02 ` Vladimir Oltean
2023-12-07 20:22 ` Luiz Angelo Daros de Luca
2023-12-07 17:19 ` Vladimir Oltean
2023-12-07 19:50 ` Luiz Angelo Daros de Luca
2023-12-07 22:31 ` Vladimir Oltean
2023-12-08 2:46 ` Luiz Angelo Daros de Luca
2023-12-11 18:01 ` Vladimir Oltean
2023-11-25 7:10 ` Dan Carpenter [this message]
2023-11-17 23:57 ` [net-next 0/2] net: dsa: realtek: Introduce realtek_common, load " Luiz Angelo Daros de Luca
2023-11-18 0:44 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78a4a47d-cde1-4c2c-999c-6f76b5fa9c87@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=arinc.unal@arinc9.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=lkp@intel.com \
--cc=luizluca@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox