From: Vladimir Oltean <olteanv@gmail.com>
To: "Arınç ÜNAL" <arinc.unal@arinc9.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
mithat.guner@xeront.com, erkin.bozoglu@xeront.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: dsa: mt7530: select MEDIATEK_GE_PHY for NET_DSA_MT7530_MDIO
Date: Thu, 25 Jan 2024 11:29:09 +0200 [thread overview]
Message-ID: <20240125092909.exaisdjkkgmc5fue@skbuf> (raw)
In-Reply-To: <20240122053451.8004-1-arinc.unal@arinc9.com>
On Mon, Jan 22, 2024 at 08:34:51AM +0300, Arınç ÜNAL wrote:
> Quoting from commit 4223f8651287 ("net: dsa: mt7530: make NET_DSA_MT7530
> select MEDIATEK_GE_PHY"):
>
> Make MediaTek MT753x DSA driver enable MediaTek Gigabit PHYs driver to
> properly control MT7530 and MT7531 switch PHYs.
>
> A noticeable change is that the behaviour of switchport interfaces going
> up-down-up-down is no longer there.
>
> Now, the switch can be used without the PHYs but, at the moment, every
> hardware design out there that I have seen uses them. For that, it would
> make the most sense to force the selection of MEDIATEK_GE_PHY for the MDIO
> interface which currently controls the MT7530 and MT7531 switches.
>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
I see MEDIATEK_GE_PHY only depends on NETDEVICES && PHYLIB, so it should
have no problem being directly selected by a driver without breaking the
build by causing unmet dependencies.
I also see there is precedent with CONFIG_TXGBE selecting
MARVELL_10G_PHY, CONFIG_R8169 selecting REALTEK_PHY, and others.
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
next prev parent reply other threads:[~2024-01-25 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 5:34 [PATCH net-next] net: dsa: mt7530: select MEDIATEK_GE_PHY for NET_DSA_MT7530_MDIO Arınç ÜNAL
2024-01-25 9:29 ` Vladimir Oltean [this message]
2024-01-27 4:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240125092909.exaisdjkkgmc5fue@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=arinc.unal@arinc9.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=erkin.bozoglu@xeront.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mithat.guner@xeront.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox