* [PATCH] dt-bindings: net: qcom,ipa: do not override firmware-name $ref
@ 2024-01-29 14:21 Krzysztof Kozlowski
2024-01-29 16:51 ` Conor Dooley
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-29 14:21 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Alex Elder, linux-arm-msm, netdev, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
dtschema package defines firmware-name as string-array, so individual
bindings should not make it a string but instead just narrow the number
of expected firmware file names.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/net/qcom,ipa.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
index c30218684cfe..53cae71d9957 100644
--- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
@@ -159,7 +159,7 @@ properties:
when the AP (not the modem) performs early initialization.
firmware-name:
- $ref: /schemas/types.yaml#/definitions/string
+ maxItems: 1
description:
If present, name (or relative path) of the file within the
firmware search path containing the firmware image used when
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: net: qcom,ipa: do not override firmware-name $ref
2024-01-29 14:21 [PATCH] dt-bindings: net: qcom,ipa: do not override firmware-name $ref Krzysztof Kozlowski
@ 2024-01-29 16:51 ` Conor Dooley
2024-01-30 12:18 ` Alex Elder
2024-02-01 9:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2024-01-29 16:51 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, Konrad Dybcio, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Alex Elder, linux-arm-msm, netdev, devicetree,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 403 bytes --]
On Mon, Jan 29, 2024 at 03:21:21PM +0100, Krzysztof Kozlowski wrote:
> dtschema package defines firmware-name as string-array, so individual
> bindings should not make it a string but instead just narrow the number
> of expected firmware file names.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: net: qcom,ipa: do not override firmware-name $ref
2024-01-29 14:21 [PATCH] dt-bindings: net: qcom,ipa: do not override firmware-name $ref Krzysztof Kozlowski
2024-01-29 16:51 ` Conor Dooley
@ 2024-01-30 12:18 ` Alex Elder
2024-02-01 9:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Alex Elder @ 2024-01-30 12:18 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alex Elder,
linux-arm-msm, netdev, devicetree, linux-kernel
On 1/29/24 8:21 AM, Krzysztof Kozlowski wrote:
> dtschema package defines firmware-name as string-array, so individual
> bindings should not make it a string but instead just narrow the number
> of expected firmware file names.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fine with me.
Acked-by: Alex Elder <elder@linaro.org>
> ---
> Documentation/devicetree/bindings/net/qcom,ipa.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> index c30218684cfe..53cae71d9957 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> @@ -159,7 +159,7 @@ properties:
> when the AP (not the modem) performs early initialization.
>
> firmware-name:
> - $ref: /schemas/types.yaml#/definitions/string
> + maxItems: 1
> description:
> If present, name (or relative path) of the file within the
> firmware search path containing the firmware image used when
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: net: qcom,ipa: do not override firmware-name $ref
2024-01-29 14:21 [PATCH] dt-bindings: net: qcom,ipa: do not override firmware-name $ref Krzysztof Kozlowski
2024-01-29 16:51 ` Conor Dooley
2024-01-30 12:18 ` Alex Elder
@ 2024-02-01 9:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-02-01 9:50 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: andersson, konrad.dybcio, davem, edumazet, kuba, pabeni, robh+dt,
krzysztof.kozlowski+dt, conor+dt, elder, linux-arm-msm, netdev,
devicetree, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Mon, 29 Jan 2024 15:21:21 +0100 you wrote:
> dtschema package defines firmware-name as string-array, so individual
> bindings should not make it a string but instead just narrow the number
> of expected firmware file names.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/net/qcom,ipa.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- dt-bindings: net: qcom,ipa: do not override firmware-name $ref
https://git.kernel.org/netdev/net-next/c/b2005bb756e1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-01 9:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-29 14:21 [PATCH] dt-bindings: net: qcom,ipa: do not override firmware-name $ref Krzysztof Kozlowski
2024-01-29 16:51 ` Conor Dooley
2024-01-30 12:18 ` Alex Elder
2024-02-01 9:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox