* [PATCH] ctrl: Add check for result rtnl_dump_filter()
@ 2024-02-18 19:43 Maks Mishin
2024-02-19 17:51 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Maks Mishin @ 2024-02-18 19:43 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Maks Mishin, netdev
Added check for result of rtnl_dump_filter() function
for catch errors linked with dump.
Found by RASU JSC.
Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com>
---
genl/ctrl.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/genl/ctrl.c b/genl/ctrl.c
index aff922a4..467a2830 100644
--- a/genl/ctrl.c
+++ b/genl/ctrl.c
@@ -313,7 +313,10 @@ static int ctrl_list(int cmd, int argc, char **argv)
goto ctrl_done;
}
- rtnl_dump_filter(&rth, print_ctrl2, stdout);
+ if (rtnl_dump_filter(&rth, print_ctrl2, stdout) < 0) {
+ fprintf(stderr, "Dump terminated\n");
+ exit(1);
+ }
}
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ctrl: Add check for result rtnl_dump_filter()
2024-02-18 19:43 [PATCH] ctrl: Add check for result rtnl_dump_filter() Maks Mishin
@ 2024-02-19 17:51 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2024-02-19 17:51 UTC (permalink / raw)
To: Maks Mishin; +Cc: netdev
On Sun, 18 Feb 2024 22:43:09 +0300
Maks Mishin <maks.mishinfz@gmail.com> wrote:
> Added check for result of rtnl_dump_filter() function
> for catch errors linked with dump.
> Found by RASU JSC.
>
> Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com>
> ---
> genl/ctrl.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/genl/ctrl.c b/genl/ctrl.c
> index aff922a4..467a2830 100644
> --- a/genl/ctrl.c
> +++ b/genl/ctrl.c
> @@ -313,7 +313,10 @@ static int ctrl_list(int cmd, int argc, char **argv)
> goto ctrl_done;
> }
>
> - rtnl_dump_filter(&rth, print_ctrl2, stdout);
> + if (rtnl_dump_filter(&rth, print_ctrl2, stdout) < 0) {
> + fprintf(stderr, "Dump terminated\n");
> + exit(1);
Why does this have to be fatal and call exit()?
Other places in same code just return error.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-19 17:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-18 19:43 [PATCH] ctrl: Add check for result rtnl_dump_filter() Maks Mishin
2024-02-19 17:51 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox