[PATCH 1/2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[PATCH 1/2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[Marek Vasut]

CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
This chip is present e.g. on muRata 1YN module. Extend the
binding with its DT compatible.

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-bluetooth@vger.kernel.org
Cc: netdev@vger.kernel.org
---
 Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
index cc70b00c6ce57..670bff0078ed7 100644
--- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
@@ -27,6 +27,7 @@ properties:
       - brcm,bcm4335a0
       - brcm,bcm4349-bt
       - cypress,cyw4373a0-bt
+      - infineon,cyw43439-bt
       - infineon,cyw55572-bt
 
   shutdown-gpios:
-- 
2.43.0

[PATCH 2/2] Bluetooth: hci_bcm: Add CYW43439 support

[Marek Vasut]

CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
This chip is present e.g. on muRata 1YN module. Extend the
driver to bind with it, even though the device binding is
most basic.

Signed-off-by: Marek Vasut <marex@denx.de>
---
NOTE: This comes up as the following, should the binding be
      for 43439 (the chipset per muRata 1YN docs) or 4343A2?
Bluetooth: hci0: BCM: features 0x0e
Bluetooth: hci0: UART 4343A2 wlbga_BU
Bluetooth: hci0: BCM (001.003.016) build 0000
---
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-bluetooth@vger.kernel.org
Cc: netdev@vger.kernel.org
---
 drivers/bluetooth/hci_bcm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index 874d23089b39b..16b64b6ff7b1d 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -1608,6 +1608,7 @@ static const struct of_device_id bcm_bluetooth_of_match[] = {
 	{ .compatible = "brcm,bcm43540-bt", .data = &bcm4354_device_data },
 	{ .compatible = "brcm,bcm4335a0" },
 	{ .compatible = "cypress,cyw4373a0-bt", .data = &cyw4373a0_device_data },
+	{ .compatible = "infineon,cyw43439-bt" },
 	{ .compatible = "infineon,cyw55572-bt", .data = &cyw55572_device_data },
 	{ },
 };
-- 
2.43.0

Re: [PATCH 1/2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[Krzysztof Kozlowski]

On 09/03/2024 04:15, Marek Vasut wrote:
> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
> This chip is present e.g. on muRata 1YN module. Extend the
> binding with its DT compatible.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: "David S. Miller" <davem@davemloft.net>

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1805 bytes --]

On Sat, Mar 09, 2024 at 04:15:12AM +0100, Marek Vasut wrote:
> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
> This chip is present e.g. on muRata 1YN module. Extend the
> binding with its DT compatible.

How come there's no fallback here? Looking at the binding patch there's
no device-specific handling done, what's incompatibly different between
this device and some of the other ones supported by the hci_bcm driver?

> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
> Cc: Marcel Holtmann <marcel@holtmann.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-bluetooth@vger.kernel.org
> Cc: netdev@vger.kernel.org
> ---
>  Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
> index cc70b00c6ce57..670bff0078ed7 100644
> --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
> @@ -27,6 +27,7 @@ properties:
>        - brcm,bcm4335a0
>        - brcm,bcm4349-bt
>        - cypress,cyw4373a0-bt
> +      - infineon,cyw43439-bt
>        - infineon,cyw55572-bt
>  
>    shutdown-gpios:
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 1/2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[Marek Vasut]

On 3/17/24 4:03 PM, Conor Dooley wrote:
> On Sat, Mar 09, 2024 at 04:15:12AM +0100, Marek Vasut wrote:
>> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
>> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
>> This chip is present e.g. on muRata 1YN module. Extend the
>> binding with its DT compatible.
> 
> How come there's no fallback here? Looking at the binding patch there's
> no device-specific handling done, what's incompatibly different between
> this device and some of the other ones supported by the hci_bcm driver?

For posterity, should be addressed in V2.