public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
To: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Louis Peens <louis.peens@corigine.com>,
	Taras Chornyi <taras.chornyi@plvision.eu>,
	Woojung Huh <woojung.huh@microchip.com>,
	UNGLinuxDriver@microchip.com
Cc: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Yanguo Li" <yanguo.li@corigine.com>,
	oss-drivers@corigine.com, "Andrew Lunn" <andrew@lunn.ch>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Vladimir Oltean" <olteanv@gmail.com>,
	"Edward Cree" <ecree.xilinx@gmail.com>,
	"Jamal Hadi Salim" <jhs@mojatatu.com>,
	"Cong Wang" <xiyou.wangcong@gmail.com>,
	"Jiri Pirko" <jiri@resnulli.us>
Subject: [PATCH net-next 1/6] flow_offload: add flow_rule_no_unsupp_control_flags()
Date: Mon,  8 Apr 2024 13:09:19 +0000	[thread overview]
Message-ID: <20240408130927.78594-2-ast@fiberby.net> (raw)
In-Reply-To: <20240408130927.78594-1-ast@fiberby.net>

This helper can be used by drivers to check for the
presence of unsupported control flags.

It mirrors the existing check done in sfc:
  drivers/net/ethernet/sfc/tc.c +276

This is aimed at drivers, which implements some control flags.

This should also be used by drivers that implement all
current flags, so that future flags will be unsupported
by default.

Only compile-tested.

Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
---
 include/net/flow_offload.h | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
index 314087a5e1818..c1317b14da08c 100644
--- a/include/net/flow_offload.h
+++ b/include/net/flow_offload.h
@@ -449,6 +449,28 @@ static inline bool flow_rule_match_key(const struct flow_rule *rule,
 	return dissector_uses_key(rule->match.dissector, key);
 }
 
+/**
+ * flow_rule_no_unsupp_control_flags() - check for unsupported control flags
+ * @supp_flags: flags supported by driver
+ * @flags: flags present in rule
+ * @extack: The netlink extended ACK for reporting errors.
+ *
+ * Returns true if only supported control flags are set, false otherwise.
+ */
+static inline bool flow_rule_no_unsupp_control_flags(const u32 supp_flags,
+						     const u32 flags,
+						     struct netlink_ext_ack *extack)
+{
+	if (likely((flags & ~supp_flags) == 0))
+		return true;
+
+	NL_SET_ERR_MSG_FMT_MOD(extack,
+			       "Unsupported match on control.flags %#x",
+			       flags);
+
+	return false;
+}
+
 struct flow_stats {
 	u64	pkts;
 	u64	bytes;
-- 
2.43.0


  reply	other threads:[~2024-04-08 13:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08 13:09 [PATCH net-next 0/6] flower: validate control flags Asbjørn Sloth Tønnesen
2024-04-08 13:09 ` Asbjørn Sloth Tønnesen [this message]
2024-04-09  1:56   ` [PATCH net-next 1/6] flow_offload: add flow_rule_no_unsupp_control_flags() Baowen Zheng
2024-04-09 11:27     ` Asbjørn Sloth Tønnesen
2024-04-09  2:05   ` Baowen Zheng
2024-04-09  8:40   ` Louis Peens
2024-04-09 11:13     ` Asbjørn Sloth Tønnesen
2024-04-10  5:10       ` Louis Peens
2024-04-08 13:09 ` [PATCH net-next 2/6] nfp: flower: fix check for unsupported control flags Asbjørn Sloth Tønnesen
2024-04-08 13:09 ` [PATCH net-next 3/6] flow_offload: add flow_rule_no_control_flags() Asbjørn Sloth Tønnesen
2024-04-09  2:09   ` Baowen Zheng
2024-04-09 11:31     ` Asbjørn Sloth Tønnesen
2024-04-09 11:35       ` Baowen Zheng
2024-04-08 13:09 ` [PATCH net-next 4/6] net: prestera: flower: validate control flags Asbjørn Sloth Tønnesen
2024-04-08 13:09 ` [PATCH net-next 5/6] flow_offload: add flow_rule_match_no_control_flags() Asbjørn Sloth Tønnesen
2024-04-08 13:09 ` [PATCH net-next 6/6] net: dsa: microchip: ksz9477: flower: validate control flags Asbjørn Sloth Tønnesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240408130927.78594-2-ast@fiberby.net \
    --to=ast@fiberby.net \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=ecree.xilinx@gmail.com \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=louis.peens@corigine.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=oss-drivers@corigine.com \
    --cc=pabeni@redhat.com \
    --cc=taras.chornyi@plvision.eu \
    --cc=woojung.huh@microchip.com \
    --cc=xiyou.wangcong@gmail.com \
    --cc=yanguo.li@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox