From: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Louis Peens <louis.peens@corigine.com>,
Taras Chornyi <taras.chornyi@plvision.eu>,
Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com
Cc: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Yanguo Li" <yanguo.li@corigine.com>,
oss-drivers@corigine.com, "Andrew Lunn" <andrew@lunn.ch>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"Edward Cree" <ecree.xilinx@gmail.com>,
"Jamal Hadi Salim" <jhs@mojatatu.com>,
"Cong Wang" <xiyou.wangcong@gmail.com>,
"Jiri Pirko" <jiri@resnulli.us>
Subject: [PATCH net-next 2/6] nfp: flower: fix check for unsupported control flags
Date: Mon, 8 Apr 2024 13:09:20 +0000 [thread overview]
Message-ID: <20240408130927.78594-3-ast@fiberby.net> (raw)
In-Reply-To: <20240408130927.78594-1-ast@fiberby.net>
Use flow_rule_no_unsupp_control_flags()
Check the mask, not the key, for unsupported control flags.
Only compile-tested, no access to HW
Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
---
drivers/net/ethernet/netronome/nfp/flower/offload.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/netronome/nfp/flower/offload.c b/drivers/net/ethernet/netronome/nfp/flower/offload.c
index 0aceef9fe5826..bc7d7c7e68efb 100644
--- a/drivers/net/ethernet/netronome/nfp/flower/offload.c
+++ b/drivers/net/ethernet/netronome/nfp/flower/offload.c
@@ -527,10 +527,10 @@ nfp_flower_calculate_key_layers(struct nfp_app *app,
struct flow_match_control ctl;
flow_rule_match_control(rule, &ctl);
- if (ctl.key->flags & ~NFP_FLOWER_SUPPORTED_CTLFLAGS) {
- NL_SET_ERR_MSG_MOD(extack, "unsupported offload: match on unknown control flag");
+
+ if (!flow_rule_no_unsupp_control_flags(NFP_FLOWER_SUPPORTED_CTLFLAGS,
+ ctl.mask->flags, extack))
return -EOPNOTSUPP;
- }
}
ret_key_ls->key_layer = key_layer;
--
2.43.0
next prev parent reply other threads:[~2024-04-08 13:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 13:09 [PATCH net-next 0/6] flower: validate control flags Asbjørn Sloth Tønnesen
2024-04-08 13:09 ` [PATCH net-next 1/6] flow_offload: add flow_rule_no_unsupp_control_flags() Asbjørn Sloth Tønnesen
2024-04-09 1:56 ` Baowen Zheng
2024-04-09 11:27 ` Asbjørn Sloth Tønnesen
2024-04-09 2:05 ` Baowen Zheng
2024-04-09 8:40 ` Louis Peens
2024-04-09 11:13 ` Asbjørn Sloth Tønnesen
2024-04-10 5:10 ` Louis Peens
2024-04-08 13:09 ` Asbjørn Sloth Tønnesen [this message]
2024-04-08 13:09 ` [PATCH net-next 3/6] flow_offload: add flow_rule_no_control_flags() Asbjørn Sloth Tønnesen
2024-04-09 2:09 ` Baowen Zheng
2024-04-09 11:31 ` Asbjørn Sloth Tønnesen
2024-04-09 11:35 ` Baowen Zheng
2024-04-08 13:09 ` [PATCH net-next 4/6] net: prestera: flower: validate control flags Asbjørn Sloth Tønnesen
2024-04-08 13:09 ` [PATCH net-next 5/6] flow_offload: add flow_rule_match_no_control_flags() Asbjørn Sloth Tønnesen
2024-04-08 13:09 ` [PATCH net-next 6/6] net: dsa: microchip: ksz9477: flower: validate control flags Asbjørn Sloth Tønnesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240408130927.78594-3-ast@fiberby.net \
--to=ast@fiberby.net \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=taras.chornyi@plvision.eu \
--cc=woojung.huh@microchip.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yanguo.li@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox