[PATCH net-next 0/3] net: pse-pd: Fixes for few small issues

[PATCH net-next 0/3] net: pse-pd: Fixes for few small issues

[Kory Maincent (Dent Project)]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 821 bytes --]

From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>

This patch series fix few issues in PSE net subsystem like Regulator
dependency, PSE regulator type and kernel Documentation.

Signed-off-by: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
---
Kory Maincent (Dent Project) (3):
      net: pse-pd: pse_core: Add missing kdoc return description
      net: pse-pd: pse_core: Fix pse regulator type
      net: pse-pd: Kconfig: Add missing Regulator API dependency

 drivers/net/pse-pd/Kconfig    |  2 +-
 drivers/net/pse-pd/pse_core.c | 10 +++++++++-
 2 files changed, 10 insertions(+), 2 deletions(-)
---
base-commit: 6a57f091622a1251c2826f7380577049199b80ea
change-id: 20240422-fix_poe-d0fb292c9d8e

Best regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

[PATCH net-next 1/3] net: pse-pd: pse_core: Add missing kdoc return description

[Kory Maincent (Dent Project)]

From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>

Add missing kernel documentation return description.
This allows to remove all warning from kernel-doc test script.

Signed-off-by: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
---
 drivers/net/pse-pd/pse_core.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/net/pse-pd/pse_core.c b/drivers/net/pse-pd/pse_core.c
index 31f23c454678..bad29eaa4d01 100644
--- a/drivers/net/pse-pd/pse_core.c
+++ b/drivers/net/pse-pd/pse_core.c
@@ -320,6 +320,8 @@ devm_pse_pi_regulator_register(struct pse_controller_dev *pcdev,
 /**
  * pse_controller_register - register a PSE controller device
  * @pcdev: a pointer to the initialized PSE controller device
+ *
+ * Return: 0 on success and failure value on error
  */
 int pse_controller_register(struct pse_controller_dev *pcdev)
 {
@@ -401,6 +403,8 @@ static void devm_pse_controller_release(struct device *dev, void *res)
  * Managed pse_controller_register(). For PSE controllers registered by
  * this function, pse_controller_unregister() is automatically called on
  * driver detach. See pse_controller_register() for more information.
+ *
+ * Return: 0 on success and failure value on error
  */
 int devm_pse_controller_register(struct device *dev,
 				 struct pse_controller_dev *pcdev)
@@ -627,6 +631,8 @@ EXPORT_SYMBOL_GPL(of_pse_control_get);
  * @psec: PSE control pointer
  * @extack: extack for reporting useful error messages
  * @status: struct to store PSE status
+ *
+ * Return: 0 on success and failure value on error
  */
 int pse_ethtool_get_status(struct pse_control *psec,
 			   struct netlink_ext_ack *extack,
@@ -704,6 +710,8 @@ static int pse_ethtool_podl_set_config(struct pse_control *psec,
  * @psec: PSE control pointer
  * @extack: extack for reporting useful error messages
  * @config: Configuration of the test to run
+ *
+ * Return: 0 on success and failure value on error
  */
 int pse_ethtool_set_config(struct pse_control *psec,
 			   struct netlink_ext_ack *extack,

-- 
2.34.1

Re: [PATCH net-next 1/3] net: pse-pd: pse_core: Add missing kdoc return description

[Andrew Lunn]

On Mon, Apr 22, 2024 at 02:50:48PM +0200, Kory Maincent (Dent Project) wrote:
> From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
> 
> Add missing kernel documentation return description.
> This allows to remove all warning from kernel-doc test script.
> 
> Signed-off-by: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

[PATCH net-next 2/3] net: pse-pd: pse_core: Fix pse regulator type

[Kory Maincent (Dent Project)]

From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>

Clarify PSE regulator as voltage regulator, not current.
The PSE (Power Sourcing Equipment) regulator is defined as a voltage
regulator, maintaining fixed voltage while accommodating varying current.

Signed-off-by: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
---
 drivers/net/pse-pd/pse_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/pse-pd/pse_core.c b/drivers/net/pse-pd/pse_core.c
index bad29eaa4d01..795ab264eaf2 100644
--- a/drivers/net/pse-pd/pse_core.c
+++ b/drivers/net/pse-pd/pse_core.c
@@ -294,7 +294,7 @@ devm_pse_pi_regulator_register(struct pse_controller_dev *pcdev,
 	 */
 	rdesc->id = id;
 	rdesc->name = name;
-	rdesc->type = REGULATOR_CURRENT;
+	rdesc->type = REGULATOR_VOLTAGE;
 	rdesc->ops = &pse_pi_ops;
 	rdesc->owner = pcdev->owner;
 

-- 
2.34.1

Re: [PATCH net-next 2/3] net: pse-pd: pse_core: Fix pse regulator type

[Andrew Lunn]

On Mon, Apr 22, 2024 at 02:50:49PM +0200, Kory Maincent (Dent Project) wrote:
> From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
> 
> Clarify PSE regulator as voltage regulator, not current.
> The PSE (Power Sourcing Equipment) regulator is defined as a voltage
> regulator, maintaining fixed voltage while accommodating varying current.
> 
> Signed-off-by: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

[PATCH net-next 3/3] net: pse-pd: Kconfig: Add missing Regulator API dependency

[Kory Maincent (Dent Project)]

From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>

The PSE (Power Sourcing Equipment) API now relies on the Regulator API.
However, the Regulator dependency was missing from Kconfig. This patch
adds the necessary dependency, resolving the issue of the missing
dependency and ensuring proper functionality of the PSE API.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202404201020.mqX2IOu7-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202404200036.D8ap1Mf5-lkp@intel.com/
Fixes: d83e13761d5b ("net: pse-pd: Use regulator framework within PSE framework")
Signed-off-by: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
---
 drivers/net/pse-pd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/pse-pd/Kconfig b/drivers/net/pse-pd/Kconfig
index 80cf373a5a0e..577ea904b3d9 100644
--- a/drivers/net/pse-pd/Kconfig
+++ b/drivers/net/pse-pd/Kconfig
@@ -5,6 +5,7 @@
 
 menuconfig PSE_CONTROLLER
 	bool "Ethernet Power Sourcing Equipment Support"
+	depends on REGULATOR
 	help
 	  Generic Power Sourcing Equipment Controller support.
 
@@ -14,7 +15,6 @@ if PSE_CONTROLLER
 
 config PSE_REGULATOR
 	tristate "Regulator based PSE controller"
-	depends on REGULATOR || COMPILE_TEST
 	help
 	  This module provides support for simple regulator based Ethernet Power
 	  Sourcing Equipment without automatic classification support. For

-- 
2.34.1

Re: [PATCH net-next 3/3] net: pse-pd: Kconfig: Add missing Regulator API dependency

[Andrew Lunn]

On Mon, Apr 22, 2024 at 02:50:50PM +0200, Kory Maincent (Dent Project) wrote:
> From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
> 
> The PSE (Power Sourcing Equipment) API now relies on the Regulator API.
> However, the Regulator dependency was missing from Kconfig. This patch
> adds the necessary dependency, resolving the issue of the missing
> dependency and ensuring proper functionality of the PSE API.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202404201020.mqX2IOu7-lkp@intel.com/
> Closes: https://lore.kernel.org/oe-kbuild-all/202404200036.D8ap1Mf5-lkp@intel.com/
> Fixes: d83e13761d5b ("net: pse-pd: Use regulator framework within PSE framework")
> Signed-off-by: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH net-next 3/3] net: pse-pd: Kconfig: Add missing Regulator API dependency

[Kory Maincent]

On Mon, 22 Apr 2024 15:17:27 +0200
Andrew Lunn <andrew@lunn.ch> wrote:

> On Mon, Apr 22, 2024 at 02:50:50PM +0200, Kory Maincent (Dent Project) wrote:
> > From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
> > 
> > The PSE (Power Sourcing Equipment) API now relies on the Regulator API.
> > However, the Regulator dependency was missing from Kconfig. This patch
> > adds the necessary dependency, resolving the issue of the missing
> > dependency and ensuring proper functionality of the PSE API.
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes:
> > https://lore.kernel.org/oe-kbuild-all/202404201020.mqX2IOu7-lkp@intel.com/
> > Closes:
> > https://lore.kernel.org/oe-kbuild-all/202404200036.D8ap1Mf5-lkp@intel.com/
> > Fixes: d83e13761d5b ("net: pse-pd: Use regulator framework within PSE
> > framework") Signed-off-by: Kory Maincent (Dent Project)
> > <kory.maincent@bootlin.com>  
> 
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Oh you already put your reviewed-by on the whole series!
So efficient!! Thank you!
I can send the v2 then.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Re: [PATCH net-next 0/3] net: pse-pd: Fixes for few small issues

[Kory Maincent]

On Mon, 22 Apr 2024 14:50:47 +0200
"Kory Maincent (Dent Project)" <kory.maincent@bootlin.com> wrote:

> From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
> 
> This patch series fix few issues in PSE net subsystem like Regulator
> dependency, PSE regulator type and kernel Documentation.
> 
> Signed-off-by: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>

Found out I had a git configuration that adds "Dent Project" to my sob. I don't
want that, and will send a v2 without it. 
I will wait a week for review before the v2, so please do not merge this
version.
Sorry for the noise.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Re: [PATCH net-next 0/3] net: pse-pd: Fixes for few small issues

[Andrew Lunn]

On Mon, Apr 22, 2024 at 03:02:34PM +0200, Kory Maincent wrote:
> On Mon, 22 Apr 2024 14:50:47 +0200
> "Kory Maincent (Dent Project)" <kory.maincent@bootlin.com> wrote:
> 
> > From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
> > 
> > This patch series fix few issues in PSE net subsystem like Regulator
> > dependency, PSE regulator type and kernel Documentation.
> > 
> > Signed-off-by: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
> 
> Found out I had a git configuration that adds "Dent Project" to my sob. I don't
> want that, and will send a v2 without it. 
> I will wait a week for review before the v2, so please do not merge this
> version.

Hi Kory

You should be able to send:

pw-bot: cr

to your own patch series and patchwork will mark the series are Change
Requested. That will stop it from being merged.

	Andrew

Re: [PATCH net-next 0/3] net: pse-pd: Fixes for few small issues

[Kory Maincent]

On Mon, 22 Apr 2024 15:05:39 +0200
Andrew Lunn <andrew@lunn.ch> wrote:

> On Mon, Apr 22, 2024 at 03:02:34PM +0200, Kory Maincent wrote:
> > On Mon, 22 Apr 2024 14:50:47 +0200
> > "Kory Maincent (Dent Project)" <kory.maincent@bootlin.com> wrote:
> >   
> > > From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
> > > 
> > > This patch series fix few issues in PSE net subsystem like Regulator
> > > dependency, PSE regulator type and kernel Documentation.
> > > 
> > > Signed-off-by: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>  
> > 
> > Found out I had a git configuration that adds "Dent Project" to my sob. I
> > don't want that, and will send a v2 without it. 
> > I will wait a week for review before the v2, so please do not merge this
> > version.  
> 
> Hi Kory

Hi Andrew, 
 
> You should be able to send:
> 
> pw-bot: cr
> 
> to your own patch series and patchwork will mark the series are Change
> Requested. That will stop it from being merged.

Oh thanks, I didn't know that.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Re: [PATCH net-next 0/3] net: pse-pd: Fixes for few small issues

[Kory Maincent]

On Mon, 22 Apr 2024 15:02:34 +0200
Kory Maincent <kory.maincent@bootlin.com> wrote:

> On Mon, 22 Apr 2024 14:50:47 +0200
> "Kory Maincent (Dent Project)" <kory.maincent@bootlin.com> wrote:
> 
> > From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
> > 
> > This patch series fix few issues in PSE net subsystem like Regulator
> > dependency, PSE regulator type and kernel Documentation.
> > 
> > Signed-off-by: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
> 
> Found out I had a git configuration that adds "Dent Project" to my sob. I
> don't want that, and will send a v2 without it. 
> I will wait a week for review before the v2, so please do not merge this
> version.
> Sorry for the noise.

---
pw-bot: cr

-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com