Netdev List
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
	Andrew Lunn <andrew@lunn.ch>, Eric Dumazet <edumazet@google.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Woojung Huh <woojung.huh@microchip.com>,
	Arun Ramadoss <arun.ramadoss@microchip.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	kernel@pengutronix.de, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next v1 2/3] net: dsa: microchip: lan937x: force RGMII interface into PHY mode
Date: Fri, 28 Jun 2024 01:25:43 +0300	[thread overview]
Message-ID: <20240627222543.rcx3i5o43toopwcm@skbuf> (raw)
In-Reply-To: <20240627123911.227480-3-o.rempel@pengutronix.de>

On Thu, Jun 27, 2024 at 02:39:10PM +0200, Oleksij Rempel wrote:
> From: Lucas Stach <l.stach@pengutronix.de>
> 
> The register manual and datasheet documentation for the LAN937x series
> disagree about the polarity of the MII mode strap. As a consequence
> there are hardware designs that have the RGMII interface strapped into
> MAC mode, which is a invalid configuration and will prevent the internal
> clock from being fed into the port TX interface.
> 
> Force the MII mode to PHY for RGMII interfaces where this is the only
> valid mode, to override the inproper strapping.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---

What's the difference between MAC mode and PHY mode with RGMII for this switch?

  parent reply	other threads:[~2024-06-27 22:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-27 12:39 [PATCH net-next v1 1/1] net: dsa: microchip: add regmap_range for KSZ9563 chip Oleksij Rempel
2024-06-27 12:39 ` [PATCH net-next v1 1/3] net: dsa: microchip: lan9372: add 100BaseTX PHY support Oleksij Rempel
2024-06-28  2:31   ` Arun.Ramadoss
2024-06-27 12:39 ` [PATCH net-next v1 2/3] net: dsa: microchip: lan937x: force RGMII interface into PHY mode Oleksij Rempel
2024-06-27 15:15   ` Andrew Lunn
2024-06-27 22:25   ` Vladimir Oltean [this message]
2024-06-28  7:10     ` Oleksij Rempel
2024-06-28 14:02       ` Andrew Lunn
2024-06-27 12:39 ` [PATCH net-next v1 3/3] net: dsa: microchip: lan937x: disable VPHY output Oleksij Rempel
2024-06-27 22:38   ` Vladimir Oltean
2024-06-28  5:27     ` Oleksij Rempel
2024-06-28  8:45     ` Lucas Stach
2024-06-27 12:43 ` [PATCH net-next v1 1/1] net: dsa: microchip: add regmap_range for KSZ9563 chip Oleksij Rempel
2024-06-27 22:00   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240627222543.rcx3i5o43toopwcm@skbuf \
    --to=olteanv@gmail.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=arun.ramadoss@microchip.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=l.stach@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=woojung.huh@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox