From: Vladimir Oltean <olteanv@gmail.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: lib/packing.c behaving weird if buffer length is not multiple of 4 with QUIRK_LSW32_IS_FIRST
Date: Wed, 21 Aug 2024 16:58:59 +0300 [thread overview]
Message-ID: <20240821135859.6ge4ruqyxrzcub67@skbuf> (raw)
In-Reply-To: <7d0e11a8-04c3-445b-89d3-fb347563dcd3@intel.com>
On Mon, Aug 19, 2024 at 02:53:34PM -0700, Jacob Keller wrote:
> The patches work for my use-case! I also think it might be helpful to
> add some Kunit tests to cover the packing and unpacking, which I
> wouldn't mind trying to do.
>
> If/when you send the patches, feel free to add:
>
> Tested-by: Jacob Keller <jacob.e.keller@intel.com>
>
> Alternatively, I could send them as part of the series where I implement
> the changes to use lib/packing in the ice driver.
This is good to hear!
I did have some boot-time selftests written, albeit in a very bare-bones
format. I'm afraid I do not have as much energy as I'd wish to push this
patch set forward. Especially not to learn to use KUnit and to adapt the
tests to that format.
If you wish, here is a Github branch with what I have. You can pick from
it for your submissions and adapt as you see fit.
https://github.com/vladimiroltean/linux/tree/packing-selftests
next prev parent reply other threads:[~2024-08-21 13:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 21:16 lib/packing.c behaving weird if buffer length is not multiple of 4 with QUIRK_LSW32_IS_FIRST Jacob Keller
2024-08-16 23:37 ` Jacob Keller
2024-08-18 13:29 ` Vladimir Oltean
2024-08-19 18:45 ` Jacob Keller
2024-08-19 21:53 ` Jacob Keller
2024-08-21 13:58 ` Vladimir Oltean [this message]
2024-08-21 19:12 ` Jacob Keller
2024-08-21 20:21 ` Vladimir Oltean
2024-08-21 23:41 ` Jacob Keller
2024-08-23 1:41 ` Jacob Keller
2024-08-23 19:53 ` Jacob Keller
2024-08-26 22:03 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240821135859.6ge4ruqyxrzcub67@skbuf \
--to=olteanv@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox