From: Vladimir Oltean <olteanv@gmail.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: lib/packing.c behaving weird if buffer length is not multiple of 4 with QUIRK_LSW32_IS_FIRST
Date: Wed, 21 Aug 2024 23:21:10 +0300 [thread overview]
Message-ID: <20240821202110.x6ljy3x3ixvbg43r@skbuf> (raw)
In-Reply-To: <0aab2158-c8a0-493e-8a32-e1abd6ba6c1c@intel.com>
On Wed, Aug 21, 2024 at 12:12:00PM -0700, Jacob Keller wrote:
> Ok. I'll investigate this, and I will send the two fixes for lib/packing
> in my series to implement the support in ice. That would help on our end
> with managing the changes since it avoids an interdependence between
> multiple series in flight.
There's one patch in there which replaces the packing(PACK) call with a
dedicated pack() function, and packing(UNPACK) with unpack(). The idea
being that it helps with const correctness. I still have some mixed
feelings about this, because a multiplexed packing() call is in some
ways more flexible, but apparently others felt bad enough about the
packing() API to tell me about it, and that stuck with me.
I'm mentioning it because if you're going to use the API, you could at
least consider using the const-correct form, so that there's one less
driver to refactor later.
next prev parent reply other threads:[~2024-08-21 20:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 21:16 lib/packing.c behaving weird if buffer length is not multiple of 4 with QUIRK_LSW32_IS_FIRST Jacob Keller
2024-08-16 23:37 ` Jacob Keller
2024-08-18 13:29 ` Vladimir Oltean
2024-08-19 18:45 ` Jacob Keller
2024-08-19 21:53 ` Jacob Keller
2024-08-21 13:58 ` Vladimir Oltean
2024-08-21 19:12 ` Jacob Keller
2024-08-21 20:21 ` Vladimir Oltean [this message]
2024-08-21 23:41 ` Jacob Keller
2024-08-23 1:41 ` Jacob Keller
2024-08-23 19:53 ` Jacob Keller
2024-08-26 22:03 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240821202110.x6ljy3x3ixvbg43r@skbuf \
--to=olteanv@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox