* [PATCH v2 net] ice: Fix NULL pointer access, if PF doesn't support SRIOV_LAG
@ 2024-08-27 7:16 Thomas Bogendoerfer
2024-08-27 7:40 ` Jiri Pirko
2024-08-27 9:52 ` Przemek Kitszel
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Bogendoerfer @ 2024-08-27 7:16 UTC (permalink / raw)
To: Tony Nguyen, Przemek Kitszel, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Daniel Machon, Dave Ertman,
intel-wired-lan, netdev, linux-kernel
For PFs, which don't support SRIOV_LAG, there is no pf->lag struct
allocated. So before accessing pf->lag a NULL pointer check is needed.
Fixes: 1e0f9881ef79 ("ice: Flesh out implementation of support for SRIOV on bonded interface")
Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
---
v2:
- Added Fixes tag
v1: https://lore.kernel.org/netdev/20240826085830.28136-1-tbogendoerfer@suse.de/
drivers/net/ethernet/intel/ice/ice_lag.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_lag.c b/drivers/net/ethernet/intel/ice/ice_lag.c
index 1ccb572ce285..916a16a379a8 100644
--- a/drivers/net/ethernet/intel/ice/ice_lag.c
+++ b/drivers/net/ethernet/intel/ice/ice_lag.c
@@ -704,7 +704,7 @@ void ice_lag_move_new_vf_nodes(struct ice_vf *vf)
lag = pf->lag;
mutex_lock(&pf->lag_mutex);
- if (!lag->bonded)
+ if (!lag || !lag->bonded)
goto new_vf_unlock;
pri_port = pf->hw.port_info->lport;
--
2.35.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2 net] ice: Fix NULL pointer access, if PF doesn't support SRIOV_LAG
2024-08-27 7:16 [PATCH v2 net] ice: Fix NULL pointer access, if PF doesn't support SRIOV_LAG Thomas Bogendoerfer
@ 2024-08-27 7:40 ` Jiri Pirko
2024-08-27 9:52 ` Przemek Kitszel
1 sibling, 0 replies; 4+ messages in thread
From: Jiri Pirko @ 2024-08-27 7:40 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: Tony Nguyen, Przemek Kitszel, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Daniel Machon, Dave Ertman,
intel-wired-lan, netdev, linux-kernel
Tue, Aug 27, 2024 at 09:16:02AM CEST, tbogendoerfer@suse.de wrote:
>For PFs, which don't support SRIOV_LAG, there is no pf->lag struct
>allocated. So before accessing pf->lag a NULL pointer check is needed.
>
>Fixes: 1e0f9881ef79 ("ice: Flesh out implementation of support for SRIOV on bonded interface")
>Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2 net] ice: Fix NULL pointer access, if PF doesn't support SRIOV_LAG
2024-08-27 7:16 [PATCH v2 net] ice: Fix NULL pointer access, if PF doesn't support SRIOV_LAG Thomas Bogendoerfer
2024-08-27 7:40 ` Jiri Pirko
@ 2024-08-27 9:52 ` Przemek Kitszel
2024-08-28 8:20 ` Przemek Kitszel
1 sibling, 1 reply; 4+ messages in thread
From: Przemek Kitszel @ 2024-08-27 9:52 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: David S. Miller, Tony Nguyen, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Daniel Machon, Dave Ertman, intel-wired-lan, netdev,
linux-kernel
On 8/27/24 09:16, Thomas Bogendoerfer wrote:
> For PFs, which don't support SRIOV_LAG, there is no pf->lag struct
> allocated. So before accessing pf->lag a NULL pointer check is needed.
>
> Fixes: 1e0f9881ef79 ("ice: Flesh out implementation of support for SRIOV on bonded interface")
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> ---
> v2:
> - Added Fixes tag
> v1: https://lore.kernel.org/netdev/20240826085830.28136-1-tbogendoerfer@suse.de/
Please see my reply to v1, unfortunately sent at the same time as your
v2. The fixes tag should be different. The check that you have
introduced here repeats the check in the only caller (was not effective
though).
>
> drivers/net/ethernet/intel/ice/ice_lag.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_lag.c b/drivers/net/ethernet/intel/ice/ice_lag.c
> index 1ccb572ce285..916a16a379a8 100644
> --- a/drivers/net/ethernet/intel/ice/ice_lag.c
> +++ b/drivers/net/ethernet/intel/ice/ice_lag.c
> @@ -704,7 +704,7 @@ void ice_lag_move_new_vf_nodes(struct ice_vf *vf)
> lag = pf->lag;
>
> mutex_lock(&pf->lag_mutex);
> - if (!lag->bonded)
> + if (!lag || !lag->bonded)
> goto new_vf_unlock;
>
> pri_port = pf->hw.port_info->lport;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2 net] ice: Fix NULL pointer access, if PF doesn't support SRIOV_LAG
2024-08-27 9:52 ` Przemek Kitszel
@ 2024-08-28 8:20 ` Przemek Kitszel
0 siblings, 0 replies; 4+ messages in thread
From: Przemek Kitszel @ 2024-08-28 8:20 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: David S. Miller, Tony Nguyen, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Daniel Machon, Dave Ertman, intel-wired-lan, netdev,
linux-kernel
On 8/27/24 11:52, Przemek Kitszel wrote:
> On 8/27/24 09:16, Thomas Bogendoerfer wrote:
>> For PFs, which don't support SRIOV_LAG, there is no pf->lag struct
>> allocated. So before accessing pf->lag a NULL pointer check is needed.
>>
>> Fixes: 1e0f9881ef79 ("ice: Flesh out implementation of support for
>> SRIOV on bonded interface")
>> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
>> ---
>> v2:
>> - Added Fixes tag
>> v1:
>> https://lore.kernel.org/netdev/20240826085830.28136-1-tbogendoerfer@suse.de/
>
> Please see my reply to v1, unfortunately sent at the same time as your
> v2. The fixes tag should be different. The check that you have
> introduced here repeats the check in the only caller (was not effective
> though).
>
>>
>> drivers/net/ethernet/intel/ice/ice_lag.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/intel/ice/ice_lag.c
>> b/drivers/net/ethernet/intel/ice/ice_lag.c
>> index 1ccb572ce285..916a16a379a8 100644
>> --- a/drivers/net/ethernet/intel/ice/ice_lag.c
>> +++ b/drivers/net/ethernet/intel/ice/ice_lag.c
>> @@ -704,7 +704,7 @@ void ice_lag_move_new_vf_nodes(struct ice_vf *vf)
>> lag = pf->lag;
>> mutex_lock(&pf->lag_mutex);
>> - if (!lag->bonded)
>> + if (!lag || !lag->bonded)
>> goto new_vf_unlock;
>> pri_port = pf->hw.port_info->lport;
>
>
thank you,
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-28 8:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-27 7:16 [PATCH v2 net] ice: Fix NULL pointer access, if PF doesn't support SRIOV_LAG Thomas Bogendoerfer
2024-08-27 7:40 ` Jiri Pirko
2024-08-27 9:52 ` Przemek Kitszel
2024-08-28 8:20 ` Przemek Kitszel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox