[PATCH net-next v2 0/3] Use functionality of irq_get_trigger_type()

[PATCH net-next v2 0/3] Use functionality of irq_get_trigger_type()

[Vasileios Amoiridis]

Changes in v2:
	- Split the patches into subsystems.

v1: https://lore.kernel.org/netdev/20240902225534.130383-1-vassilisamir@gmail.com/

Vasileios Amoiridis (3):
  net: dsa: realtek: rtl8365mb: Make use of irq_get_trigger_type()
  net: dsa: realtek: rtl8366rb: Make use of irq_get_trigger_type()
  net: smc91x: Make use of irq_get_trigger_type()

 drivers/net/dsa/realtek/rtl8365mb.c | 2 +-
 drivers/net/dsa/realtek/rtl8366rb.c | 2 +-
 drivers/net/ethernet/smsc/smc91x.c  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)


base-commit: 7808012003004b5b31e24795af33480d5eed20f1
-- 
2.25.1

[PATCH net-next v2 1/3] net: dsa: realtek: rtl8365mb: Make use of irq_get_trigger_type()

[Vasileios Amoiridis]

Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
simple irq_get_trigger_type(irq).

Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
---
 drivers/net/dsa/realtek/rtl8365mb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c
index b9674f68b756..ad7044b295ec 100644
--- a/drivers/net/dsa/realtek/rtl8365mb.c
+++ b/drivers/net/dsa/realtek/rtl8365mb.c
@@ -1740,7 +1740,7 @@ static int rtl8365mb_irq_setup(struct realtek_priv *priv)
 	}
 
 	/* Configure chip interrupt signal polarity */
-	irq_trig = irqd_get_trigger_type(irq_get_irq_data(irq));
+	irq_trig = irq_get_trigger_type(irq);
 	switch (irq_trig) {
 	case IRQF_TRIGGER_RISING:
 	case IRQF_TRIGGER_HIGH:
-- 
2.25.1

[PATCH net-next v2 2/3] net: dsa: realtek: rtl8366rb: Make use of irq_get_trigger_type()

[Vasileios Amoiridis]

Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
simple irq_get_trigger_type(irq).

Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
---
 drivers/net/dsa/realtek/rtl8366rb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/realtek/rtl8366rb.c b/drivers/net/dsa/realtek/rtl8366rb.c
index 11243f89c98a..c7a8cd060587 100644
--- a/drivers/net/dsa/realtek/rtl8366rb.c
+++ b/drivers/net/dsa/realtek/rtl8366rb.c
@@ -599,7 +599,7 @@ static int rtl8366rb_setup_cascaded_irq(struct realtek_priv *priv)
 	}
 
 	/* Fetch IRQ edge information from the descriptor */
-	irq_trig = irqd_get_trigger_type(irq_get_irq_data(irq));
+	irq_trig = irq_get_trigger_type(irq);
 	switch (irq_trig) {
 	case IRQF_TRIGGER_RISING:
 	case IRQF_TRIGGER_HIGH:
-- 
2.25.1

[PATCH net-next v2 3/3] net: smc91x: Make use of irq_get_trigger_type()

[Vasileios Amoiridis]

Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
simple irq_get_trigger_type(irq).

Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
---
 drivers/net/ethernet/smsc/smc91x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
index 907498848028..a5e23e2da90f 100644
--- a/drivers/net/ethernet/smsc/smc91x.c
+++ b/drivers/net/ethernet/smsc/smc91x.c
@@ -2355,7 +2355,7 @@ static int smc_drv_probe(struct platform_device *pdev)
 	 * the resource supplies a trigger, override the irqflags with
 	 * the trigger flags from the resource.
 	 */
-	irq_resflags = irqd_get_trigger_type(irq_get_irq_data(ndev->irq));
+	irq_resflags = irq_get_trigger_type(ndev->irq);
 	if (irq_flags == -1 || irq_resflags & IRQF_TRIGGER_MASK)
 		irq_flags = irq_resflags & IRQF_TRIGGER_MASK;
 
-- 
2.25.1

Re: [PATCH net-next v2 1/3] net: dsa: realtek: rtl8365mb: Make use of irq_get_trigger_type()

[Alvin Šipraga]

On Wed, Sep 04, 2024 at 05:10:16PM GMT, Vasileios Amoiridis wrote:
> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type(irq).
> 
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> ---
>  drivers/net/dsa/realtek/rtl8365mb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks like you missed my review here, you can add it :)

Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>

Re: [PATCH net-next v2 3/3] net: smc91x: Make use of irq_get_trigger_type()

[Alvin Šipraga]

On Wed, Sep 04, 2024 at 05:10:18PM GMT, Vasileios Amoiridis wrote:
> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type(irq).
> 
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> ---
>  drivers/net/ethernet/smsc/smc91x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>

> 
> diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
> index 907498848028..a5e23e2da90f 100644
> --- a/drivers/net/ethernet/smsc/smc91x.c
> +++ b/drivers/net/ethernet/smsc/smc91x.c
> @@ -2355,7 +2355,7 @@ static int smc_drv_probe(struct platform_device *pdev)
>  	 * the resource supplies a trigger, override the irqflags with
>  	 * the trigger flags from the resource.
>  	 */
> -	irq_resflags = irqd_get_trigger_type(irq_get_irq_data(ndev->irq));
> +	irq_resflags = irq_get_trigger_type(ndev->irq);
>  	if (irq_flags == -1 || irq_resflags & IRQF_TRIGGER_MASK)
>  		irq_flags = irq_resflags & IRQF_TRIGGER_MASK;
>  
> -- 
> 2.25.1
>

Re: [PATCH net-next v2 0/3] Use functionality of irq_get_trigger_type()

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed,  4 Sep 2024 17:10:15 +0200 you wrote:
> Changes in v2:
> 	- Split the patches into subsystems.
> 
> v1: https://lore.kernel.org/netdev/20240902225534.130383-1-vassilisamir@gmail.com/
> 
> Vasileios Amoiridis (3):
>   net: dsa: realtek: rtl8365mb: Make use of irq_get_trigger_type()
>   net: dsa: realtek: rtl8366rb: Make use of irq_get_trigger_type()
>   net: smc91x: Make use of irq_get_trigger_type()
> 
> [...]

Here is the summary with links:
  - [net-next,v2,1/3] net: dsa: realtek: rtl8365mb: Make use of irq_get_trigger_type()
    https://git.kernel.org/netdev/net-next/c/517c29247557
  - [net-next,v2,2/3] net: dsa: realtek: rtl8366rb: Make use of irq_get_trigger_type()
    https://git.kernel.org/netdev/net-next/c/36a5faec5658
  - [net-next,v2,3/3] net: smc91x: Make use of irq_get_trigger_type()
    https://git.kernel.org/netdev/net-next/c/f4bbf496f5fd

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH net-next v2 1/3] net: dsa: realtek: rtl8365mb: Make use of irq_get_trigger_type()

[Vasileios Amoiridis]

On Wed, Sep 04, 2024 at 03:40:56PM +0000, Alvin Šipraga wrote:
> On Wed, Sep 04, 2024 at 05:10:16PM GMT, Vasileios Amoiridis wrote:
> > Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> > simple irq_get_trigger_type(irq).
> > 
> > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> > ---
> >  drivers/net/dsa/realtek/rtl8365mb.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Looks like you missed my review here, you can add it :)
> 
> Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>

Hi Alvin,

Sorry for missing that, but thank you for reminding :)