From: Joe Damato <jdamato@fastly.com>
To: netdev@vger.kernel.org
Cc: Joe Damato <jdamato@fastly.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-kernel@vger.kernel.org (open list),
Michael Chan <mchan@broadcom.com>,
Paolo Abeni <pabeni@redhat.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>
Subject: [RFC net-next v2 0/2] tg3: Link IRQs, NAPIs, and queues
Date: Sat, 5 Oct 2024 14:57:15 +0000 [thread overview]
Message-ID: <20241005145717.302575-1-jdamato@fastly.com> (raw)
Greetings:
This RFC v3 follows from a previous RFC [1] submission which I noticed
had an issue in patch 2.
Patch 1 is changed to wrap a long line at 80 characters. No functional
changes. As such, I retained Pavan Chebbi's Reviewed-by.
Patch 2 in RFC v2 had an issue where it used the index into tp->irq_cnt
as the rxq or txq index; this is incorrect. It does not need seem that
tg3 assigns explicit queue index to struct tg3_napi, so the least
invasive change I could think of included two running counters in
tg3_napi_enable and tg3_napi_disable.
This is required because netif_queue_set_napi expected the queue index
(0 to real_num_[rt]x_queues) to be passed in to associate queues IDs
with NAPI IDs. tg2_napi_disable is modified in the reverse order;
counting down queue indices.
I am open to other suggestions on implementation from broadcom, but
thought that this was the least disruptive change.
I've tested this change on my tg3 hardware and it seems to work, see
commit message for examples of how to test.
Thanks,
Joe
[1]: https://lore.kernel.org/netdev/20240925162048.16208-1-jdamato@fastly.com/
Joe Damato (2):
tg3: Link IRQs to NAPI instances
tg3: Link queues to NAPIs
drivers/net/ethernet/broadcom/tg3.c | 45 ++++++++++++++++++++++++-----
1 file changed, 38 insertions(+), 7 deletions(-)
--
2.25.1
next reply other threads:[~2024-10-05 14:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-05 14:57 Joe Damato [this message]
2024-10-05 14:57 ` [net-next v3 1/2] tg3: Link IRQs to NAPI instances Joe Damato
2024-10-05 14:57 ` [net-next v3 2/2] tg3: Link queues to NAPIs Joe Damato
2024-10-07 7:30 ` Michael Chan
2024-10-07 13:38 ` Joe Damato
2024-10-07 14:23 ` Joe Damato
2024-10-07 22:39 ` Michael Chan
2024-10-06 21:15 ` [RFC net-next v2 0/2] tg3: Link IRQs, NAPIs, and queues Joe Damato
-- strict thread matches above, loose matches on Subject: below --
2024-09-25 16:20 Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241005145717.302575-1-jdamato@fastly.com \
--to=jdamato@fastly.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox