* [PATCH net-next v1] netlink: specs: Add missing bitset attrs to ethtool spec
@ 2024-10-18 9:06 Donald Hunter
2024-10-18 9:08 ` Kory Maincent
2024-10-23 11:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Donald Hunter @ 2024-10-18 9:06 UTC (permalink / raw)
To: netdev, Jakub Kicinski, David S. Miller, Eric Dumazet,
Paolo Abeni, Kory Maincent
Cc: donald.hunter, Donald Hunter
There are a couple of attributes missing from the 'bitset' attribute-set
in the ethtool netlink spec. Add them to the spec.
Reported-by: Kory Maincent <kory.maincent@bootlin.com>
Closes: https://lore.kernel.org/netdev/20241017180551.1259bf5c@kmaincent-XPS-13-7390/
Signed-off-by: Donald Hunter <donald.hunter@gmail.com>
---
Documentation/netlink/specs/ethtool.yaml | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
index 6a050d755b9c..f6c5d8214c7e 100644
--- a/Documentation/netlink/specs/ethtool.yaml
+++ b/Documentation/netlink/specs/ethtool.yaml
@@ -96,7 +96,12 @@ attribute-sets:
name: bits
type: nest
nested-attributes: bitset-bits
-
+ -
+ name: value
+ type: binary
+ -
+ name: mask
+ type: binary
-
name: string
attributes:
--
2.47.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next v1] netlink: specs: Add missing bitset attrs to ethtool spec
2024-10-18 9:06 [PATCH net-next v1] netlink: specs: Add missing bitset attrs to ethtool spec Donald Hunter
@ 2024-10-18 9:08 ` Kory Maincent
2024-10-23 11:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Kory Maincent @ 2024-10-18 9:08 UTC (permalink / raw)
To: Donald Hunter
Cc: netdev, Jakub Kicinski, David S. Miller, Eric Dumazet,
Paolo Abeni, donald.hunter
On Fri, 18 Oct 2024 10:06:30 +0100
Donald Hunter <donald.hunter@gmail.com> wrote:
> There are a couple of attributes missing from the 'bitset' attribute-set
> in the ethtool netlink spec. Add them to the spec.
Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
Tested-by: Kory Maincent <kory.maincent@bootlin.com>
Thank you!
> Reported-by: Kory Maincent <kory.maincent@bootlin.com>
> Closes:
> https://lore.kernel.org/netdev/20241017180551.1259bf5c@kmaincent-XPS-13-7390/
> Signed-off-by: Donald Hunter <donald.hunter@gmail.com> ---
> Documentation/netlink/specs/ethtool.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/netlink/specs/ethtool.yaml
> b/Documentation/netlink/specs/ethtool.yaml index 6a050d755b9c..f6c5d8214c7e
> 100644 --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -96,7 +96,12 @@ attribute-sets:
> name: bits
> type: nest
> nested-attributes: bitset-bits
> -
> + -
> + name: value
> + type: binary
> + -
> + name: mask
> + type: binary
> -
> name: string
> attributes:
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v1] netlink: specs: Add missing bitset attrs to ethtool spec
2024-10-18 9:06 [PATCH net-next v1] netlink: specs: Add missing bitset attrs to ethtool spec Donald Hunter
2024-10-18 9:08 ` Kory Maincent
@ 2024-10-23 11:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-10-23 11:50 UTC (permalink / raw)
To: Donald Hunter
Cc: netdev, kuba, davem, edumazet, pabeni, kory.maincent,
donald.hunter
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Fri, 18 Oct 2024 10:06:30 +0100 you wrote:
> There are a couple of attributes missing from the 'bitset' attribute-set
> in the ethtool netlink spec. Add them to the spec.
>
> Reported-by: Kory Maincent <kory.maincent@bootlin.com>
> Closes: https://lore.kernel.org/netdev/20241017180551.1259bf5c@kmaincent-XPS-13-7390/
> Signed-off-by: Donald Hunter <donald.hunter@gmail.com>
>
> [...]
Here is the summary with links:
- [net-next,v1] netlink: specs: Add missing bitset attrs to ethtool spec
https://git.kernel.org/netdev/net-next/c/b0b3683419b4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-23 11:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-18 9:06 [PATCH net-next v1] netlink: specs: Add missing bitset attrs to ethtool spec Donald Hunter
2024-10-18 9:08 ` Kory Maincent
2024-10-23 11:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox