From: Ming Yu <a0282524688@gmail.com>
To: tmyu0@nuvoton.com, lee@kernel.org, linus.walleij@linaro.org,
brgl@bgdev.pl, andi.shyti@kernel.org, mkl@pengutronix.de,
mailhol.vincent@wanadoo.fr, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, wim@linux-watchdog.org, linux@roeck-us.net,
jdelvare@suse.com, jic23@kernel.org, lars@metafoo.de,
ukleinek@kernel.org, alexandre.belloni@bootlin.com
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-can@vger.kernel.org,
netdev@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org
Subject: [PATCH v1 8/9] pwm: Add Nuvoton NCT6694 PWM support
Date: Thu, 24 Oct 2024 16:59:21 +0800 [thread overview]
Message-ID: <20241024085922.133071-9-tmyu0@nuvoton.com> (raw)
In-Reply-To: <20241024085922.133071-1-tmyu0@nuvoton.com>
This driver supports PWM functionality for NCT6694 MFD device
based on USB interface.
Signed-off-by: Ming Yu <tmyu0@nuvoton.com>
---
MAINTAINERS | 1 +
drivers/pwm/Kconfig | 10 ++
drivers/pwm/Makefile | 1 +
drivers/pwm/pwm-nct6694.c | 245 ++++++++++++++++++++++++++++++++++++++
4 files changed, 257 insertions(+)
create mode 100644 drivers/pwm/pwm-nct6694.c
diff --git a/MAINTAINERS b/MAINTAINERS
index 5c350eac187d..4d5a5eded3b9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16444,6 +16444,7 @@ F: drivers/iio/adc/nct6694_adc.c
F: drivers/i2c/busses/i2c-nct6694.c
F: drivers/mfd/nct6694.c
F: drivers/net/can/nct6694_canfd.c
+F: drivers/pwm/pwm-nct6694.c
F: drivers/watchdog/nct6694_wdt.c
F: include/linux/mfd/nct6694.h
diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
index 0915c1e7df16..00b5eb13f99d 100644
--- a/drivers/pwm/Kconfig
+++ b/drivers/pwm/Kconfig
@@ -471,6 +471,16 @@ config PWM_NTXEC
controller found in certain e-book readers designed by the original
design manufacturer Netronix.
+config PWM_NCT6694
+ tristate "Nuvoton NCT6694 PWM support"
+ depends on MFD_NCT6694
+ help
+ If you say yes to this option, support will be included for Nuvoton
+ NCT6694, a USB device to PWM controller.
+
+ This driver can also be built as a module. If so, the module
+ will be called pwm-nct6694.
+
config PWM_OMAP_DMTIMER
tristate "OMAP Dual-Mode Timer PWM support"
depends on OF
diff --git a/drivers/pwm/Makefile b/drivers/pwm/Makefile
index 9081e0c0e9e0..5c5602b79402 100644
--- a/drivers/pwm/Makefile
+++ b/drivers/pwm/Makefile
@@ -42,6 +42,7 @@ obj-$(CONFIG_PWM_MICROCHIP_CORE) += pwm-microchip-core.o
obj-$(CONFIG_PWM_MTK_DISP) += pwm-mtk-disp.o
obj-$(CONFIG_PWM_MXS) += pwm-mxs.o
obj-$(CONFIG_PWM_NTXEC) += pwm-ntxec.o
+obj-$(CONFIG_PWM_NCT6694) += pwm-nct6694.o
obj-$(CONFIG_PWM_OMAP_DMTIMER) += pwm-omap-dmtimer.o
obj-$(CONFIG_PWM_PCA9685) += pwm-pca9685.o
obj-$(CONFIG_PWM_PXA) += pwm-pxa.o
diff --git a/drivers/pwm/pwm-nct6694.c b/drivers/pwm/pwm-nct6694.c
new file mode 100644
index 000000000000..915a2ab50834
--- /dev/null
+++ b/drivers/pwm/pwm-nct6694.c
@@ -0,0 +1,245 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Nuvoton NCT6694 PWM driver based on USB interface.
+ *
+ * Copyright (C) 2024 Nuvoton Technology Corp.
+ */
+
+#include <linux/slab.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/pwm.h>
+#include <linux/platform_device.h>
+#include <linux/mfd/nct6694.h>
+
+#define DRVNAME "nct6694-pwm"
+
+#define NR_PWM 10
+#define MAX_PERIOD_NS 40000 /* PWM Maximum Frequency = 25kHz */
+#define PERIOD_NS_CONST 10200000 /* Period_ns to Freq_reg */
+
+/* Host interface */
+#define REQUEST_RPT_MOD 0xFF
+#define REQUEST_HWMON_MOD 0x00
+#define REQUEST_PWM_MOD 0x01
+
+/* Report Channel */
+#define HWMON_PWM_IDX(x) (0x70 + (x))
+
+/* Message Channel -HWMON */
+/* Command 00h */
+#define REQUEST_HWMON_CMD0_LEN 0x40
+#define REQUEST_HWMON_CMD0_OFFSET 0x0000 /* OFFSET = SEL|CMD */
+#define HWMON_PWM_EN(x) (0x06 + (x))
+#define HWMON_PWM_PP(x) (0x08 + (x))
+#define HWMON_PWM_FREQ_IDX(x) (0x30 + (x))
+
+/* Message Channel -FAN */
+/* Command 00h */
+#define REQUEST_PWM_CMD0_LEN 0x08
+#define REQUEST_PWM_CMD0_OFFSET 0x0000 /* OFFSET = SEL|CMD */
+#define PWM_CH_EN(x) (x ? 0x00 : 0x01)
+/* Command 01h */
+#define REQUEST_PWM_CMD1_LEN 0x20
+#define REQUEST_PWM_CMD1_OFFSET 0x0001 /* OFFSET = SEL|CMD */
+#define PWM_MAL_EN(x) (x ? 0x00 : 0x01)
+#define PWM_MAL_VAL(x) (0x02 + (x))
+
+/*
+ * Frequency <-> Period
+ * (10^9 * 255) / (25000 * Freq_reg) = Period_ns
+ * 10200000 / Freq_reg = Period_ns
+ *
+ * | Freq_reg | Freq_Hz | Period_ns |
+ * | 1 (01h | 98.039 | 10200000 |
+ * | 2 (02h) | 196.078 | 5100000 |
+ * | 3 (03h) | 294.117 | 3400000 |
+ * | ... |
+ * | ... |
+ * | ... |
+ * | 253 (FDh)| 24803.9 | 40316.20 |
+ * | 254 (FEh)| 24901.9 | 40157.48 |
+ * | 255 (FFh)| 25000 | 40000 |
+ *
+ */
+
+struct nct6694_pwm_data {
+ struct nct6694 *nct6694;
+ unsigned char hwmon_cmd0_buf[REQUEST_HWMON_CMD0_LEN];
+ unsigned char pwm_cmd0_buf[REQUEST_PWM_CMD0_LEN];
+ unsigned char pwm_cmd1_buf[REQUEST_PWM_CMD1_LEN];
+};
+
+static inline struct nct6694_pwm_data *to_nct6694_pwm_data(struct pwm_chip *chip)
+{
+ return pwmchip_get_drvdata(chip);
+}
+
+static int nct6694_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm)
+{
+ struct nct6694_pwm_data *data = to_nct6694_pwm_data(chip);
+ unsigned char ch_enable = data->pwm_cmd0_buf[PWM_CH_EN(pwm->hwpwm / 8)];
+ unsigned char mal_enable = data->pwm_cmd1_buf[PWM_MAL_EN(pwm->hwpwm / 8)];
+ bool ch_en = ch_enable & BIT(pwm->hwpwm % 8);
+ bool mal_en = mal_enable & BIT(pwm->hwpwm % 8);
+
+ if (!(ch_en && mal_en)) {
+ pr_err("%s: PWM(%d) is running in other mode!\n",
+ __func__, pwm->hwpwm);
+ return -EINVAL;
+ }
+
+ return 0;
+}
+
+static int nct6694_pwm_get_state(struct pwm_chip *chip,
+ struct pwm_device *pwm,
+ struct pwm_state *state)
+{
+ struct nct6694_pwm_data *data = to_nct6694_pwm_data(chip);
+ unsigned char freq_reg, duty;
+
+ /* Get pwm device initial state */
+ state->enabled = true;
+
+ freq_reg = data->hwmon_cmd0_buf[HWMON_PWM_FREQ_IDX(pwm->hwpwm)];
+ state->period = PERIOD_NS_CONST / freq_reg;
+
+ duty = data->pwm_cmd1_buf[PWM_MAL_VAL(pwm->hwpwm)];
+ state->duty_cycle = duty * state->period / 0xFF;
+
+ return 0;
+}
+
+static int nct6694_pwm_apply(struct pwm_chip *chip,
+ struct pwm_device *pwm,
+ const struct pwm_state *state)
+{
+ struct nct6694_pwm_data *data = to_nct6694_pwm_data(chip);
+ unsigned char freq_reg, duty;
+ int ret;
+
+ if (state->period < MAX_PERIOD_NS)
+ return -EINVAL;
+
+ /* (10^9 * 255) / (25000 * Freq_reg) = Period_ns */
+ freq_reg = (unsigned char)(PERIOD_NS_CONST / state->period);
+ data->hwmon_cmd0_buf[HWMON_PWM_FREQ_IDX(pwm->hwpwm)] = freq_reg;
+ ret = nct6694_write_msg(data->nct6694, REQUEST_HWMON_MOD,
+ REQUEST_HWMON_CMD0_OFFSET,
+ REQUEST_HWMON_CMD0_LEN,
+ data->hwmon_cmd0_buf);
+ if (ret)
+ return -EIO;
+
+ /* Duty = duty * 0xFF */
+ duty = (unsigned char)(state->duty_cycle * 0xFF / state->period);
+ data->pwm_cmd1_buf[PWM_MAL_VAL(pwm->hwpwm)] = duty;
+ if (state->enabled)
+ data->pwm_cmd1_buf[PWM_MAL_EN(pwm->hwpwm / 8)] |= BIT(pwm->hwpwm % 8);
+ else
+ data->pwm_cmd1_buf[PWM_MAL_EN(pwm->hwpwm / 8)] &= ~BIT(pwm->hwpwm % 8);
+ ret = nct6694_write_msg(data->nct6694, REQUEST_PWM_MOD,
+ REQUEST_PWM_CMD1_OFFSET, REQUEST_PWM_CMD1_LEN,
+ data->pwm_cmd1_buf);
+ if (ret)
+ return -EIO;
+
+ return 0;
+}
+
+static const struct pwm_ops nct6694_pwm_ops = {
+ .request = nct6694_pwm_request,
+ .apply = nct6694_pwm_apply,
+ .get_state = nct6694_pwm_get_state,
+};
+
+static int nct6694_pwm_init(struct nct6694_pwm_data *data)
+{
+ struct nct6694 *nct6694 = data->nct6694;
+ int ret;
+
+ ret = nct6694_read_msg(nct6694, REQUEST_HWMON_MOD,
+ REQUEST_HWMON_CMD0_OFFSET,
+ REQUEST_HWMON_CMD0_LEN, 0,
+ REQUEST_HWMON_CMD0_LEN,
+ data->hwmon_cmd0_buf);
+ if (ret)
+ return ret;
+
+ ret = nct6694_read_msg(nct6694, REQUEST_PWM_MOD,
+ REQUEST_PWM_CMD0_OFFSET,
+ REQUEST_PWM_CMD0_LEN, 0,
+ REQUEST_PWM_CMD0_LEN,
+ data->pwm_cmd0_buf);
+ if (ret)
+ return ret;
+
+ ret = nct6694_read_msg(nct6694, REQUEST_PWM_MOD,
+ REQUEST_PWM_CMD1_OFFSET,
+ REQUEST_PWM_CMD1_LEN, 0,
+ REQUEST_PWM_CMD1_LEN,
+ data->pwm_cmd1_buf);
+ return ret;
+}
+
+static int nct6694_pwm_probe(struct platform_device *pdev)
+{
+ struct pwm_chip *chip;
+ struct nct6694_pwm_data *data;
+ struct nct6694 *nct6694 = dev_get_drvdata(pdev->dev.parent);
+ int ret;
+
+ chip = devm_pwmchip_alloc(&pdev->dev, NR_PWM, sizeof(*data));
+ if (IS_ERR(chip))
+ return PTR_ERR(chip);
+
+ data = to_nct6694_pwm_data(chip);
+
+ data->nct6694 = nct6694;
+ chip->ops = &nct6694_pwm_ops;
+
+ ret = nct6694_pwm_init(data);
+ if (ret)
+ return -EIO;
+
+ /* Register pwm device to PWM framework */
+ ret = devm_pwmchip_add(&pdev->dev, chip);
+ if (ret) {
+ dev_err(&pdev->dev, "Failed to register pwm device!\n");
+ return ret;
+ }
+
+ return 0;
+}
+
+static struct platform_driver nct6694_pwm_driver = {
+ .driver = {
+ .name = DRVNAME,
+ },
+ .probe = nct6694_pwm_probe,
+};
+
+static int __init nct6694_init(void)
+{
+ int err;
+
+ err = platform_driver_register(&nct6694_pwm_driver);
+ if (!err) {
+ if (err)
+ platform_driver_unregister(&nct6694_pwm_driver);
+ }
+
+ return err;
+}
+subsys_initcall(nct6694_init);
+
+static void __exit nct6694_exit(void)
+{
+ platform_driver_unregister(&nct6694_pwm_driver);
+}
+module_exit(nct6694_exit);
+
+MODULE_DESCRIPTION("USB-PWM driver for NCT6694");
+MODULE_AUTHOR("Ming Yu <tmyu0@nuvoton.com>");
+MODULE_LICENSE("GPL");
--
2.34.1
next prev parent reply other threads:[~2024-10-24 9:00 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 8:59 [PATCH v1 0/9] Add Nuvoton NCT6694 MFD devices Ming Yu
2024-10-24 8:59 ` [PATCH v1 1/9] mfd: Add core driver for Nuvoton NCT6694 Ming Yu
2024-10-24 9:03 ` Marc Kleine-Budde
2024-10-25 8:00 ` Ming Yu
2024-10-24 9:57 ` Marc Kleine-Budde
2024-10-25 8:02 ` Ming Yu
2024-10-24 15:20 ` Marc Kleine-Budde
2024-10-24 15:34 ` Marc Kleine-Budde
2024-10-25 8:14 ` Ming Yu
2024-10-25 8:35 ` Marc Kleine-Budde
2024-10-25 9:02 ` Marc Kleine-Budde
2024-10-25 10:22 ` Ming Yu
2024-10-25 8:08 ` Ming Yu
2024-10-25 10:08 ` Marc Kleine-Budde
2024-10-25 11:03 ` Ming Yu
2024-10-25 12:23 ` Marc Kleine-Budde
2024-10-28 7:33 ` Ming Yu
2024-10-28 7:52 ` Marc Kleine-Budde
2024-10-28 8:31 ` Ming Yu
2024-10-28 14:06 ` Marc Kleine-Budde
2024-10-29 3:45 ` Ming Yu
2024-10-29 8:14 ` Marc Kleine-Budde
2024-11-01 5:35 ` Ming Yu
2024-10-26 14:58 ` Christophe JAILLET
2024-10-28 7:37 ` Ming Yu
2024-10-24 8:59 ` [PATCH v1 2/9] gpio: Add Nuvoton NCT6694 GPIO support Ming Yu
2024-10-24 9:47 ` Bartosz Golaszewski
[not found] ` <CAOoeyxUUOCSaDLK8=ox3hwDVu=Ej-ds4=FsS8F+9GfiE-8HYvg@mail.gmail.com>
2024-10-25 7:12 ` Bartosz Golaszewski
2024-10-25 7:38 ` 游子民
2024-10-25 7:46 ` Bartosz Golaszewski
2024-10-28 8:56 ` Ming Yu
2024-10-30 19:32 ` Bartosz Golaszewski
2024-11-01 6:15 ` Ming Yu
2024-10-24 8:59 ` [PATCH v1 3/9] i2c: Add Nuvoton NCT6694 I2C support Ming Yu
2024-10-24 10:41 ` Andi Shyti
2024-10-25 7:47 ` 游子民
2024-10-24 8:59 ` [PATCH v1 4/9] can: Add Nuvoton NCT6694 CAN support Ming Yu
2024-10-24 10:03 ` Marc Kleine-Budde
2024-10-24 10:05 ` Marc Kleine-Budde
2024-11-01 1:27 ` Ming Yu
2024-10-24 12:12 ` Marc Kleine-Budde
2024-10-24 15:28 ` Marc Kleine-Budde
2024-11-01 5:32 ` Ming Yu
2024-10-24 14:17 ` Marc Kleine-Budde
2024-10-24 14:20 ` Marc Kleine-Budde
2024-11-01 1:44 ` Ming Yu
2024-11-01 1:37 ` Ming Yu
2024-10-25 11:18 ` kernel test robot
2024-10-25 23:31 ` kernel test robot
2024-10-24 8:59 ` [PATCH v1 5/9] watchdog: Add Nuvoton NCT6694 WDT support Ming Yu
2024-10-24 15:32 ` Guenter Roeck
2024-10-28 9:49 ` Ming Yu
2024-10-24 16:06 ` Guenter Roeck
2024-10-26 9:19 ` kernel test robot
2024-10-24 8:59 ` [PATCH v1 6/9] hwmon: Add Nuvoton NCT6694 HWMON support Ming Yu
2024-10-24 9:20 ` Kalesh Anakkur Purayil
2024-10-24 14:53 ` Guenter Roeck
2024-10-25 15:22 ` Ming Yu
2024-10-25 15:44 ` Guenter Roeck
2024-10-26 14:50 ` Guenter Roeck
2024-10-28 7:58 ` Ming Yu
2024-10-28 18:54 ` Jonathan Cameron
2024-10-30 3:29 ` Ming Yu
2024-10-30 4:26 ` Guenter Roeck
2024-11-01 6:11 ` Ming Yu
2024-10-28 7:42 ` Ming Yu
2024-10-25 15:10 ` Ming Yu
2024-10-24 15:03 ` Guenter Roeck
2024-10-25 15:33 ` Ming Yu
2024-10-24 8:59 ` [PATCH v1 7/9] iio: adc: Add Nuvoton NCT6694 IIO support Ming Yu
2024-10-26 14:41 ` Jonathan Cameron
2024-11-05 6:21 ` Ming Yu
2024-10-24 8:59 ` Ming Yu [this message]
2024-11-22 18:05 ` [PATCH v1 8/9] pwm: Add Nuvoton NCT6694 PWM support Uwe Kleine-König
2024-10-24 8:59 ` [PATCH v1 9/9] rtc: Add Nuvoton NCT6694 RTC support Ming Yu
2024-10-25 23:34 ` Nobuhiro Iwamatsu
2024-10-28 8:42 ` Ming Yu
2024-10-24 11:57 ` [PATCH v1 0/9] Add Nuvoton NCT6694 MFD devices Marc Kleine-Budde
2024-10-25 8:22 ` Ming Yu
2024-10-25 8:33 ` Marc Kleine-Budde
2024-10-30 8:30 ` Ming Yu
2024-10-30 10:12 ` Marc Kleine-Budde
2024-10-30 14:21 ` Ming Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241024085922.133071-9-tmyu0@nuvoton.com \
--to=a0282524688@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andi.shyti@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=brgl@bgdev.pl \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdelvare@suse.com \
--cc=jic23@kernel.org \
--cc=kuba@kernel.org \
--cc=lars@metafoo.de \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tmyu0@nuvoton.com \
--cc=ukleinek@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox