* [PATCH net-next] dt-bindings: net: sff,sfp: Fix "interrupts" property typo
@ 2024-11-13 22:58 Rob Herring (Arm)
2024-11-14 15:29 ` Andrew Lunn
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2024-11-13 22:58 UTC (permalink / raw)
To: Russell King, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Krzysztof Kozlowski, Conor Dooley
Cc: netdev, devicetree, linux-kernel
The example has "interrupt" property which is not a defined property. It
should be "interrupts" instead. "interrupts" also should not contain a
phandle.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
Documentation/devicetree/bindings/net/sff,sfp.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/sff,sfp.yaml b/Documentation/devicetree/bindings/net/sff,sfp.yaml
index 90611b598d2b..15616ad737f5 100644
--- a/Documentation/devicetree/bindings/net/sff,sfp.yaml
+++ b/Documentation/devicetree/bindings/net/sff,sfp.yaml
@@ -132,7 +132,7 @@ examples:
pinctrl-names = "default";
pinctrl-0 = <&cpm_phy0_pins &cps_phy0_pins>;
reg = <0>;
- interrupt = <&cpm_gpio2 18 IRQ_TYPE_EDGE_FALLING>;
+ interrupts = <18 IRQ_TYPE_EDGE_FALLING>;
sfp = <&sfp2>;
};
};
--
2.45.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] dt-bindings: net: sff,sfp: Fix "interrupts" property typo
2024-11-13 22:58 [PATCH net-next] dt-bindings: net: sff,sfp: Fix "interrupts" property typo Rob Herring (Arm)
@ 2024-11-14 15:29 ` Andrew Lunn
2024-11-14 19:57 ` Conor Dooley
2024-11-15 3:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2024-11-14 15:29 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Russell King, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Krzysztof Kozlowski, Conor Dooley, netdev,
devicetree, linux-kernel
On Wed, Nov 13, 2024 at 04:58:25PM -0600, Rob Herring (Arm) wrote:
> The example has "interrupt" property which is not a defined property. It
> should be "interrupts" instead. "interrupts" also should not contain a
> phandle.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] dt-bindings: net: sff,sfp: Fix "interrupts" property typo
2024-11-13 22:58 [PATCH net-next] dt-bindings: net: sff,sfp: Fix "interrupts" property typo Rob Herring (Arm)
2024-11-14 15:29 ` Andrew Lunn
@ 2024-11-14 19:57 ` Conor Dooley
2024-11-15 3:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2024-11-14 19:57 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Russell King, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Krzysztof Kozlowski, Conor Dooley, netdev,
devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 343 bytes --]
On Wed, Nov 13, 2024 at 04:58:25PM -0600, Rob Herring (Arm) wrote:
> The example has "interrupt" property which is not a defined property. It
> should be "interrupts" instead. "interrupts" also should not contain a
> phandle.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] dt-bindings: net: sff,sfp: Fix "interrupts" property typo
2024-11-13 22:58 [PATCH net-next] dt-bindings: net: sff,sfp: Fix "interrupts" property typo Rob Herring (Arm)
2024-11-14 15:29 ` Andrew Lunn
2024-11-14 19:57 ` Conor Dooley
@ 2024-11-15 3:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-11-15 3:40 UTC (permalink / raw)
To: Rob Herring
Cc: linux, davem, edumazet, kuba, pabeni, krzk+dt, conor+dt, netdev,
devicetree, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 13 Nov 2024 16:58:25 -0600 you wrote:
> The example has "interrupt" property which is not a defined property. It
> should be "interrupts" instead. "interrupts" also should not contain a
> phandle.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/net/sff,sfp.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net-next] dt-bindings: net: sff,sfp: Fix "interrupts" property typo
https://git.kernel.org/netdev/net-next/c/b52a8deea530
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-11-15 3:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-13 22:58 [PATCH net-next] dt-bindings: net: sff,sfp: Fix "interrupts" property typo Rob Herring (Arm)
2024-11-14 15:29 ` Andrew Lunn
2024-11-14 19:57 ` Conor Dooley
2024-11-15 3:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox