Re: [PATCH net-next v7 6/9] ice: use <linux/packing.h> for Tx and Rx queue context data

[Vladimir Oltean <olteanv@gmail.com>]

On Mon, Dec 02, 2024 at 04:26:29PM -0800, Jacob Keller wrote:
> +/**
> + * ice_pack_rxq_ctx - Pack Rx queue context into a HW buffer
> + * @ctx: the Rx queue context to pack
> + * @buf: the HW buffer to pack into
> + *
> + * Pack the Rx queue context from the CPU-friendly unpacked buffer into its
> + * bit-packed HW layout.
> + */
> +static void ice_pack_rxq_ctx(const struct ice_rlan_ctx *ctx,
> +			     ice_rxq_ctx_buf_t *buf)
> +{
> +	pack_fields(buf, sizeof(*buf), ctx, ice_rlan_ctx_fields,
> +		    QUIRK_LITTLE_ENDIAN | QUIRK_LSW32_IS_FIRST);

An alternative pack_fields() design would enforce that the pbuf argument
has a sizeof() which reveals the packed buffer size. Pro: one macro
argument less. Con: too intrusive in forcing authors to write code in a
certain way maybe?

> +}