Re: [PATCH net-next v7 2/9] lib: packing: demote truncation error in pack() to a warning in __pack()

[Jacob Keller <jacob.e.keller@intel.com>]

On 12/3/2024 4:43 AM, Vladimir Oltean wrote:
> On Mon, Dec 02, 2024 at 04:26:25PM -0800, Jacob Keller wrote:
>> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>>
>> Most of the sanity checks in pack() and unpack() can be covered at
>> compile time. There is only one exception, and that is truncation of the
>> uval during a pack() operation.
>>
>> We'd like the error-less __pack() to catch that condition as well. But
>> at the same time, it is currently the responsibility of consumer drivers
>> (currently just sja1105) to print anything at all when this error
>> occurs, and then discard the return code.
>>
>> We can just print a loud warning in the library code and continue with
>> the truncated __pack() operation. In practice, having the warning is
>> very important, see commit 24deec6b9e4a ("net: dsa: sja1105: disallow
>> C45 transactions on the BASE-TX MDIO bus") where the bug was caught
>> exactly by noticing this print.
>>
>> Add the first print to the packing library, and at the same time remove
>> the print for the same condition from the sja1105 driver, to avoid
>> double printing.
>>
>> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>> ---
> 
> Somehow this is missing your sign off.

Oops.