Re: [PATCH v5 1/4] dt-bindings: net: Add Realtek MDIO controller

[Krzysztof Kozlowski <krzk@kernel.org>]

On Fri, Jan 31, 2025 at 02:01:48PM +1300, Chris Packham wrote:
> +  '#address-cells':
> +    const: 1
> +
> +  '#size-cells':
> +    const: 0
> +
> +  reg:
> +    maxItems: 1
> +
> +patternProperties:
> +  '^mdio-bus@[0-4]$':

4 or 5 buses?

> +    $ref: mdio.yaml#
> +
> +    properties:
> +      reg:
> +        maxItems: 1
> +
> +    required:
> +      - reg
> +
> +    patternProperties:
> +      '^ethernet-phy@[a-f0-9]+$':
> +        type: object
> +        $ref: ethernet-phy.yaml#
> +
> +        properties:
> +          realtek,port:
> +            $ref: /schemas/types.yaml#/definitions/uint32
> +            description:
> +              The MDIO communication on the RTL9300 is abstracted by the switch. At
> +              the software level communication uses the switch port to address the
> +              PHY with the actual MDIO bus and address having been setup via the
> +              parent mdio-bus and reg property.

maximum: 8 ?

also property should be required or you miss here default.

Best regards,
Krzysztof