* [PATCH v2] octeontx2-pf: Add error log forcn10k_map_unmap_rq_policer()
@ 2025-04-05 15:23 Wentao Liang
0 siblings, 0 replies; 2+ messages in thread
From: Wentao Liang @ 2025-04-05 15:23 UTC (permalink / raw)
To: sgoutham, gakula, sbhatta, hkelam, andrew+netdev, davem, edumazet,
kuba, pabeni
Cc: netdev, linux-kernel, Wentao Liang
The cn10k_free_matchall_ipolicer() calls the cn10k_map_unmap_rq_policer()
for each queue in a for loop without checking for any errors.
Check the return value of the cn10k_map_unmap_rq_policer() function during
each loop, and report a warning if the function fails.
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c
index a15cc86635d6..895f0f8c85b2 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c
@@ -353,8 +353,10 @@ int cn10k_free_matchall_ipolicer(struct otx2_nic *pfvf)
/* Remove RQ's policer mapping */
for (qidx = 0; qidx < hw->rx_queues; qidx++)
- cn10k_map_unmap_rq_policer(pfvf, qidx,
- hw->matchall_ipolicer, false);
+ rc = cn10k_map_unmap_rq_policer(pfvf, qidx, hw->matchall_ipolicer, false);
+ if (rc)
+ dev_warn(pfvf->dev,
+ "Failed to unmap RQ's policer.");
rc = cn10k_free_leaf_profile(pfvf, hw->matchall_ipolicer);
--
2.42.0.windows.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] octeontx2-pf: Add error log forcn10k_map_unmap_rq_policer()
@ 2025-04-07 6:01 Subbaraya Sundeep
0 siblings, 0 replies; 2+ messages in thread
From: Subbaraya Sundeep @ 2025-04-07 6:01 UTC (permalink / raw)
To: Wentao Liang
Cc: sgoutham, gakula, hkelam, andrew+netdev, davem, edumazet, kuba,
pabeni, netdev, linux-kernel
On 2025-04-05 at 15:23:34, Wentao Liang (vulab@iscas.ac.cn) wrote:
> The cn10k_free_matchall_ipolicer() calls the cn10k_map_unmap_rq_policer()
> for each queue in a for loop without checking for any errors.
>
> Check the return value of the cn10k_map_unmap_rq_policer() function during
> each loop, and report a warning if the function fails.
>
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
> drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c
> index a15cc86635d6..895f0f8c85b2 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c
> @@ -353,8 +353,10 @@ int cn10k_free_matchall_ipolicer(struct otx2_nic *pfvf)
>
> /* Remove RQ's policer mapping */
> for (qidx = 0; qidx < hw->rx_queues; qidx++)
> - cn10k_map_unmap_rq_policer(pfvf, qidx,
> - hw->matchall_ipolicer, false);
> + rc = cn10k_map_unmap_rq_policer(pfvf, qidx, hw->matchall_ipolicer, false);
> + if (rc)
> + dev_warn(pfvf->dev,
> + "Failed to unmap RQ's policer.");
Print failed queue number also please.
Thanks,
Sundeep
>
> rc = cn10k_free_leaf_profile(pfvf, hw->matchall_ipolicer);
>
> --
> 2.42.0.windows.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-07 6:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-05 15:23 [PATCH v2] octeontx2-pf: Add error log forcn10k_map_unmap_rq_policer() Wentao Liang
-- strict thread matches above, loose matches on Subject: below --
2025-04-07 6:01 Subbaraya Sundeep
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox