* batman-adv: Fix double-hold of meshif when getting enabled
@ 2025-04-09 7:30 Sven Eckelmann
2025-04-09 7:30 ` Sven Eckelmann
0 siblings, 1 reply; 2+ messages in thread
From: Sven Eckelmann @ 2025-04-09 7:30 UTC (permalink / raw)
To: netdev
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
b.a.t.m.a.n, Sven Eckelmann
Fixes: 00b35530811f ("batman-adv: adopt netdev_hold() / netdev_put()")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
diff --git a/net/batman-adv/hard-interface.c b/net/batman-adv/hard-interface.c
index f145f96626531053bbf8f58a31f28f625a9d80f9..7cd4bdcee43935b9e5fb7d1696430909b7af67b4 100644
--- a/net/batman-adv/hard-interface.c
+++ b/net/batman-adv/hard-interface.c
@@ -725,7 +725,6 @@ int batadv_hardif_enable_interface(struct batadv_hard_iface *hard_iface,
kref_get(&hard_iface->refcount);
- dev_hold(mesh_iface);
netdev_hold(mesh_iface, &hard_iface->meshif_dev_tracker, GFP_ATOMIC);
hard_iface->mesh_iface = mesh_iface;
bat_priv = netdev_priv(hard_iface->mesh_iface);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: batman-adv: Fix double-hold of meshif when getting enabled
2025-04-09 7:30 batman-adv: Fix double-hold of meshif when getting enabled Sven Eckelmann
@ 2025-04-09 7:30 ` Sven Eckelmann
0 siblings, 0 replies; 2+ messages in thread
From: Sven Eckelmann @ 2025-04-09 7:30 UTC (permalink / raw)
To: netdev; +Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
On Wednesday, 9 April 2025 09:30:00 CEST Sven Eckelmann wrote:
> Fixes: 00b35530811f ("batman-adv: adopt netdev_hold() / netdev_put()")
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
>
> diff --git a/net/batman-adv/hard-interface.c b/net/batman-adv/hard-interface.c
> index f145f96626531053bbf8f58a31f28f625a9d80f9..7cd4bdcee43935b9e5fb7d1696430909b7af67b4 100644
> --- a/net/batman-adv/hard-interface.c
> +++ b/net/batman-adv/hard-interface.c
> @@ -725,7 +725,6 @@ int batadv_hardif_enable_interface(struct batadv_hard_iface *hard_iface,
>
> kref_get(&hard_iface->refcount);
>
> - dev_hold(mesh_iface);
> netdev_hold(mesh_iface, &hard_iface->meshif_dev_tracker, GFP_ATOMIC);
> hard_iface->mesh_iface = mesh_iface;
> bat_priv = netdev_priv(hard_iface->mesh_iface);
>
Sorry, from wrong folder
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-09 7:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-09 7:30 batman-adv: Fix double-hold of meshif when getting enabled Sven Eckelmann
2025-04-09 7:30 ` Sven Eckelmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox