* [PATCH net] net: dp83822: Fix OF_MDIO config check
@ 2025-04-22 6:36 Johannes Schneider
2025-04-22 8:14 ` Maxime Chevallier
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Schneider @ 2025-04-22 6:36 UTC (permalink / raw)
To: dmurphy
Cc: andrew, davem, f.fainelli, hkallweit1, kuba, linux-kernel, linux,
michael, netdev, bsp-development.geo, Johannes Schneider
When CONFIG_OF_MDIO is set to be a module the code block is not
compiled. Use the IS_ENABLED macro that checks for both built in as
well as module.
Fixes: 5dc39fd ("net: phy: DP83822: Add ability to advertise Fiber connection")
Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
---
drivers/net/phy/dp83822.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
index 6599feca1967..f1179881abb4 100644
--- a/drivers/net/phy/dp83822.c
+++ b/drivers/net/phy/dp83822.c
@@ -719,7 +719,7 @@ static int dp83822_phy_reset(struct phy_device *phydev)
return phydev->drv->config_init(phydev);
}
-#ifdef CONFIG_OF_MDIO
+#if IS_ENABLED(CONFIG_OF_MDIO)
static int dp83822_of_init_leds(struct phy_device *phydev)
{
struct device_node *node = phydev->mdio.dev.of_node;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: dp83822: Fix OF_MDIO config check
2025-04-22 6:36 [PATCH net] net: dp83822: Fix OF_MDIO config check Johannes Schneider
@ 2025-04-22 8:14 ` Maxime Chevallier
2025-04-22 8:30 ` SCHNEIDER Johannes
0 siblings, 1 reply; 3+ messages in thread
From: Maxime Chevallier @ 2025-04-22 8:14 UTC (permalink / raw)
To: Johannes Schneider
Cc: dmurphy, andrew, davem, f.fainelli, hkallweit1, kuba,
linux-kernel, linux, michael, netdev, bsp-development.geo
Hello Johannes,
On Tue, 22 Apr 2025 08:36:38 +0200
Johannes Schneider <johannes.schneider@leica-geosystems.com> wrote:
> When CONFIG_OF_MDIO is set to be a module the code block is not
> compiled. Use the IS_ENABLED macro that checks for both built in as
> well as module.
>
> Fixes: 5dc39fd ("net: phy: DP83822: Add ability to advertise Fiber connection")
> Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
> ---
The patch looks correct, but doesn't apply. Have you correctly rebased
it on the latest net tree ?
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: dp83822: Fix OF_MDIO config check
2025-04-22 8:14 ` Maxime Chevallier
@ 2025-04-22 8:30 ` SCHNEIDER Johannes
0 siblings, 0 replies; 3+ messages in thread
From: SCHNEIDER Johannes @ 2025-04-22 8:30 UTC (permalink / raw)
To: Maxime Chevallier
Cc: dmurphy@ti.com, andrew@lunn.ch, davem@davemloft.net,
f.fainelli@gmail.com, hkallweit1@gmail.com, kuba@kernel.org,
linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
michael@walle.cc, netdev@vger.kernel.org,
GEO-CHHER-bsp-development
Hoi,
>
> Hello Johannes,
>
> On Tue, 22 Apr 2025 08:36:38 +0200
> Johannes Schneider <johannes.schneider@leica-geosystems.com> wrote:
>
> > When CONFIG_OF_MDIO is set to be a module the code block is not
> > compiled. Use the IS_ENABLED macro that checks for both built in as
> > well as module.
> >
> > Fixes: 5dc39fd ("net: phy: DP83822: Add ability to advertise Fiber connection")
> > Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
> > ---
>
> The patch looks correct, but doesn't apply. Have you correctly rebased
> it on the latest net tree ?
>
ah, merde! i was still on "our" kernel: 6.14.0
I'll rebase and send out an updated version
>
> Thanks,
>
> Maxime
>
gruß
Johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-22 8:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-22 6:36 [PATCH net] net: dp83822: Fix OF_MDIO config check Johannes Schneider
2025-04-22 8:14 ` Maxime Chevallier
2025-04-22 8:30 ` SCHNEIDER Johannes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox