[PATCH] Revert "rndis_host: Flag RNDIS modems as WWAN devices"

[PATCH] Revert "rndis_host: Flag RNDIS modems as WWAN devices"

[Christian Heusel]

This reverts commit 67d1a8956d2d62fe6b4c13ebabb57806098511d8. Since this
commit has been proven to be problematic for the setup of USB-tethered
ethernet connections and the related breakage is very noticeable for
users it should be reverted until a fixed version of the change can be
rolled out.

Closes: https://lore.kernel.org/all/e0df2d85-1296-4317-b717-bd757e3ab928@heusel.eu/
Link: https://chaos.social/@gromit/114377862699921553
Link: https://bugzilla.kernel.org/show_bug.cgi?id=220002
Link: https://bugs.gentoo.org/953555
Link: https://bbs.archlinux.org/viewtopic.php?id=304892
Cc: stable@vger.kernel.org
Acked-by: Lubomir Rintel <lkundrak@v3.sk>
Signed-off-by: Christian Heusel <christian@heusel.eu>
---
 drivers/net/usb/rndis_host.c | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)

diff --git a/drivers/net/usb/rndis_host.c b/drivers/net/usb/rndis_host.c
index bb0bf1415872745aea177ce0ba7d6eb578cb4a47..7b3739b29c8f72b7b108c5f4ae11fdfcf243237d 100644
--- a/drivers/net/usb/rndis_host.c
+++ b/drivers/net/usb/rndis_host.c
@@ -630,16 +630,6 @@ static const struct driver_info	zte_rndis_info = {
 	.tx_fixup =	rndis_tx_fixup,
 };
 
-static const struct driver_info	wwan_rndis_info = {
-	.description =	"Mobile Broadband RNDIS device",
-	.flags =	FLAG_WWAN | FLAG_POINTTOPOINT | FLAG_FRAMING_RN | FLAG_NO_SETINT,
-	.bind =		rndis_bind,
-	.unbind =	rndis_unbind,
-	.status =	rndis_status,
-	.rx_fixup =	rndis_rx_fixup,
-	.tx_fixup =	rndis_tx_fixup,
-};
-
 /*-------------------------------------------------------------------------*/
 
 static const struct usb_device_id	products [] = {
@@ -676,11 +666,9 @@ static const struct usb_device_id	products [] = {
 	USB_INTERFACE_INFO(USB_CLASS_WIRELESS_CONTROLLER, 1, 3),
 	.driver_info = (unsigned long) &rndis_info,
 }, {
-	/* Mobile Broadband Modem, seen in Novatel Verizon USB730L and
-	 * Telit FN990A (RNDIS)
-	 */
+	/* Novatel Verizon USB730L */
 	USB_INTERFACE_INFO(USB_CLASS_MISC, 4, 1),
-	.driver_info = (unsigned long)&wwan_rndis_info,
+	.driver_info = (unsigned long) &rndis_info,
 },
 	{ },		// END
 };

---
base-commit: 9c32cda43eb78f78c73aee4aa344b777714e259b
change-id: 20250424-usb-tethering-fix-398688b32dad

Best regards,
-- 
Christian Heusel <christian@heusel.eu>

Re: [PATCH] Revert "rndis_host: Flag RNDIS modems as WWAN devices"

[Lubomir Rintel]

On Thu, Apr 24, 2025 at 04:00:28PM +0200, Christian Heusel wrote:
> This reverts commit 67d1a8956d2d62fe6b4c13ebabb57806098511d8. Since this
> commit has been proven to be problematic for the setup of USB-tethered
> ethernet connections and the related breakage is very noticeable for
> users it should be reverted until a fixed version of the change can be
> rolled out.
> 
> Closes: https://lore.kernel.org/all/e0df2d85-1296-4317-b717-bd757e3ab928@heusel.eu/
> Link: https://chaos.social/@gromit/114377862699921553
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=220002
> Link: https://bugs.gentoo.org/953555
> Link: https://bbs.archlinux.org/viewtopic.php?id=304892
> Cc: stable@vger.kernel.org
> Acked-by: Lubomir Rintel <lkundrak@v3.sk>
> Signed-off-by: Christian Heusel <christian@heusel.eu>

Thanks for sending this out, it really needs a different solution.

Reviewed-by: Lubomir Rintel <lkundrak@v3.sk>

> ---
>  drivers/net/usb/rndis_host.c | 16 ++--------------
>  1 file changed, 2 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/net/usb/rndis_host.c b/drivers/net/usb/rndis_host.c
> index bb0bf1415872745aea177ce0ba7d6eb578cb4a47..7b3739b29c8f72b7b108c5f4ae11fdfcf243237d 100644
> --- a/drivers/net/usb/rndis_host.c
> +++ b/drivers/net/usb/rndis_host.c
> @@ -630,16 +630,6 @@ static const struct driver_info	zte_rndis_info = {
>  	.tx_fixup =	rndis_tx_fixup,
>  };
>  
> -static const struct driver_info	wwan_rndis_info = {
> -	.description =	"Mobile Broadband RNDIS device",
> -	.flags =	FLAG_WWAN | FLAG_POINTTOPOINT | FLAG_FRAMING_RN | FLAG_NO_SETINT,
> -	.bind =		rndis_bind,
> -	.unbind =	rndis_unbind,
> -	.status =	rndis_status,
> -	.rx_fixup =	rndis_rx_fixup,
> -	.tx_fixup =	rndis_tx_fixup,
> -};
> -
>  /*-------------------------------------------------------------------------*/
>  
>  static const struct usb_device_id	products [] = {
> @@ -676,11 +666,9 @@ static const struct usb_device_id	products [] = {
>  	USB_INTERFACE_INFO(USB_CLASS_WIRELESS_CONTROLLER, 1, 3),
>  	.driver_info = (unsigned long) &rndis_info,
>  }, {
> -	/* Mobile Broadband Modem, seen in Novatel Verizon USB730L and
> -	 * Telit FN990A (RNDIS)
> -	 */
> +	/* Novatel Verizon USB730L */
>  	USB_INTERFACE_INFO(USB_CLASS_MISC, 4, 1),
> -	.driver_info = (unsigned long)&wwan_rndis_info,
> +	.driver_info = (unsigned long) &rndis_info,
>  },
>  	{ },		// END
>  };
> 
> ---
> base-commit: 9c32cda43eb78f78c73aee4aa344b777714e259b
> change-id: 20250424-usb-tethering-fix-398688b32dad
> 
> Best regards,
> -- 
> Christian Heusel <christian@heusel.eu>
> 

Re: [PATCH] Revert "rndis_host: Flag RNDIS modems as WWAN devices"

[Greg KH]

On Thu, Apr 24, 2025 at 04:00:28PM +0200, Christian Heusel wrote:
> This reverts commit 67d1a8956d2d62fe6b4c13ebabb57806098511d8. Since this
> commit has been proven to be problematic for the setup of USB-tethered
> ethernet connections and the related breakage is very noticeable for
> users it should be reverted until a fixed version of the change can be
> rolled out.
> 
> Closes: https://lore.kernel.org/all/e0df2d85-1296-4317-b717-bd757e3ab928@heusel.eu/
> Link: https://chaos.social/@gromit/114377862699921553
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=220002
> Link: https://bugs.gentoo.org/953555
> Link: https://bbs.archlinux.org/viewtopic.php?id=304892
> Cc: stable@vger.kernel.org
> Acked-by: Lubomir Rintel <lkundrak@v3.sk>
> Signed-off-by: Christian Heusel <christian@heusel.eu>
> ---
>  drivers/net/usb/rndis_host.c | 16 ++--------------
>  1 file changed, 2 insertions(+), 14 deletions(-)

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Re: [PATCH] Revert "rndis_host: Flag RNDIS modems as WWAN devices"

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 24 Apr 2025 16:00:28 +0200 you wrote:
> This reverts commit 67d1a8956d2d62fe6b4c13ebabb57806098511d8. Since this
> commit has been proven to be problematic for the setup of USB-tethered
> ethernet connections and the related breakage is very noticeable for
> users it should be reverted until a fixed version of the change can be
> rolled out.
> 
> Closes: https://lore.kernel.org/all/e0df2d85-1296-4317-b717-bd757e3ab928@heusel.eu/
> Link: https://chaos.social/@gromit/114377862699921553
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=220002
> Link: https://bugs.gentoo.org/953555
> Link: https://bbs.archlinux.org/viewtopic.php?id=304892
> Cc: stable@vger.kernel.org
> Acked-by: Lubomir Rintel <lkundrak@v3.sk>
> Signed-off-by: Christian Heusel <christian@heusel.eu>
> 
> [...]

Here is the summary with links:
  - Revert "rndis_host: Flag RNDIS modems as WWAN devices"
    https://git.kernel.org/netdev/net/c/765f253e2890

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html