[PATCH iproute2-next] misc: ss.c: fix logical error in main function

[PATCH iproute2-next] misc: ss.c: fix logical error in main function

[Anton Moryakov]

In the line if (!dump_tcpdiag) { there was a logical error 
in checking the descriptor, which the static analyzer complained 
about (this action is always false)

fixed by replacing !dump_tcpdiag with !dump_fp

Reported-by: SVACE static analyzer
Signed-off-by: Anton Moryakov <ant.v.moryakov@gmail.com>
---
 misc/ss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/misc/ss.c b/misc/ss.c
index de02fccb..20d0766d 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -6228,7 +6228,7 @@ int main(int argc, char *argv[])
 		}
 		if (dump_tcpdiag[0] != '-') {
 			dump_fp = fopen(dump_tcpdiag, "w");
-			if (!dump_tcpdiag) {
+			if (!dump_fp) {
 				perror("fopen dump file");
 				exit(-1);
 			}
-- 
2.39.2

Re: [PATCH iproute2-next] misc: ss.c: fix logical error in main function

[Stephen Hemminger]

On Sat, 19 Jul 2025 19:31:22 +0300
Anton Moryakov <ant.v.moryakov@gmail.com> wrote:

> In the line if (!dump_tcpdiag) { there was a logical error 
> in checking the descriptor, which the static analyzer complained 
> about (this action is always false)
> 
> fixed by replacing !dump_tcpdiag with !dump_fp
> 
> Reported-by: SVACE static analyzer
> Signed-off-by: Anton Moryakov <ant.v.moryakov@gmail.com>

Acked-by: Stephen Hemminger <stephen@networkplumber.org>

Re: [PATCH iproute2-next] misc: ss.c: fix logical error in main function

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to iproute2/iproute2-next.git (main)
by David Ahern <dsahern@kernel.org>:

On Sat, 19 Jul 2025 19:31:22 +0300 you wrote:
> In the line if (!dump_tcpdiag) { there was a logical error
> in checking the descriptor, which the static analyzer complained
> about (this action is always false)
> 
> fixed by replacing !dump_tcpdiag with !dump_fp
> 
> Reported-by: SVACE static analyzer
> Signed-off-by: Anton Moryakov <ant.v.moryakov@gmail.com>
> 
> [...]

Here is the summary with links:
  - [iproute2-next] misc: ss.c: fix logical error in main function
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=27d11a81197c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html