From: Laura Nao <laura.nao@collabora.com>
To: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com, p.zabel@pengutronix.de,
richardcochran@gmail.com
Cc: guangjie.song@mediatek.com, wenst@chromium.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org,
kernel@collabora.com, "Laura Nao" <laura.nao@collabora.com>,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>
Subject: [PATCH v6 03/27] clk: mediatek: clk-mux: Add ops for mux gates with set/clr/upd and FENC
Date: Mon, 15 Sep 2025 17:19:23 +0200 [thread overview]
Message-ID: <20250915151947.277983-4-laura.nao@collabora.com> (raw)
In-Reply-To: <20250915151947.277983-1-laura.nao@collabora.com>
MT8196 uses set/clr/upd registers for mux gate enable/disable control,
along with a FENC bit to check the status. Add new set of mux gate
clock operations with support for set/clr/upd and FENC status logic.
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Signed-off-by: Laura Nao <laura.nao@collabora.com>
---
drivers/clk/mediatek/clk-mux.c | 49 ++++++++++++++++++++++++++++++++++
drivers/clk/mediatek/clk-mux.h | 45 +++++++++++++++++++++++++++++++
2 files changed, 94 insertions(+)
diff --git a/drivers/clk/mediatek/clk-mux.c b/drivers/clk/mediatek/clk-mux.c
index 60990296450b..3931d157b262 100644
--- a/drivers/clk/mediatek/clk-mux.c
+++ b/drivers/clk/mediatek/clk-mux.c
@@ -17,6 +17,8 @@
#include "clk-mux.h"
+#define MTK_WAIT_FENC_DONE_US 30
+
struct mtk_clk_mux {
struct clk_hw hw;
struct regmap *regmap;
@@ -30,6 +32,33 @@ static inline struct mtk_clk_mux *to_mtk_clk_mux(struct clk_hw *hw)
return container_of(hw, struct mtk_clk_mux, hw);
}
+static int mtk_clk_mux_fenc_enable_setclr(struct clk_hw *hw)
+{
+ struct mtk_clk_mux *mux = to_mtk_clk_mux(hw);
+ unsigned long flags;
+ u32 val;
+ int ret;
+
+ if (mux->lock)
+ spin_lock_irqsave(mux->lock, flags);
+ else
+ __acquire(mux->lock);
+
+ regmap_write(mux->regmap, mux->data->clr_ofs,
+ BIT(mux->data->gate_shift));
+
+ ret = regmap_read_poll_timeout_atomic(mux->regmap, mux->data->fenc_sta_mon_ofs,
+ val, val & BIT(mux->data->fenc_shift), 1,
+ MTK_WAIT_FENC_DONE_US);
+
+ if (mux->lock)
+ spin_unlock_irqrestore(mux->lock, flags);
+ else
+ __release(mux->lock);
+
+ return ret;
+}
+
static int mtk_clk_mux_enable_setclr(struct clk_hw *hw)
{
struct mtk_clk_mux *mux = to_mtk_clk_mux(hw);
@@ -70,6 +99,16 @@ static void mtk_clk_mux_disable_setclr(struct clk_hw *hw)
BIT(mux->data->gate_shift));
}
+static int mtk_clk_mux_fenc_is_enabled(struct clk_hw *hw)
+{
+ struct mtk_clk_mux *mux = to_mtk_clk_mux(hw);
+ u32 val;
+
+ regmap_read(mux->regmap, mux->data->fenc_sta_mon_ofs, &val);
+
+ return !!(val & BIT(mux->data->fenc_shift));
+}
+
static int mtk_clk_mux_is_enabled(struct clk_hw *hw)
{
struct mtk_clk_mux *mux = to_mtk_clk_mux(hw);
@@ -168,6 +207,16 @@ const struct clk_ops mtk_mux_gate_clr_set_upd_ops = {
};
EXPORT_SYMBOL_GPL(mtk_mux_gate_clr_set_upd_ops);
+const struct clk_ops mtk_mux_gate_fenc_clr_set_upd_ops = {
+ .enable = mtk_clk_mux_fenc_enable_setclr,
+ .disable = mtk_clk_mux_disable_setclr,
+ .is_enabled = mtk_clk_mux_fenc_is_enabled,
+ .get_parent = mtk_clk_mux_get_parent,
+ .set_parent = mtk_clk_mux_set_parent_setclr_lock,
+ .determine_rate = mtk_clk_mux_determine_rate,
+};
+EXPORT_SYMBOL_GPL(mtk_mux_gate_fenc_clr_set_upd_ops);
+
static struct clk_hw *mtk_clk_register_mux(struct device *dev,
const struct mtk_mux *mux,
struct regmap *regmap,
diff --git a/drivers/clk/mediatek/clk-mux.h b/drivers/clk/mediatek/clk-mux.h
index 943ad1d7ce4b..a4fd17a18532 100644
--- a/drivers/clk/mediatek/clk-mux.h
+++ b/drivers/clk/mediatek/clk-mux.h
@@ -28,11 +28,13 @@ struct mtk_mux {
u32 set_ofs;
u32 clr_ofs;
u32 upd_ofs;
+ u32 fenc_sta_mon_ofs;
u8 mux_shift;
u8 mux_width;
u8 gate_shift;
s8 upd_shift;
+ u8 fenc_shift;
const struct clk_ops *ops;
signed char num_parents;
@@ -77,6 +79,7 @@ struct mtk_mux {
extern const struct clk_ops mtk_mux_clr_set_upd_ops;
extern const struct clk_ops mtk_mux_gate_clr_set_upd_ops;
+extern const struct clk_ops mtk_mux_gate_fenc_clr_set_upd_ops;
#define MUX_GATE_CLR_SET_UPD_FLAGS(_id, _name, _parents, _mux_ofs, \
_mux_set_ofs, _mux_clr_ofs, _shift, _width, \
@@ -118,6 +121,48 @@ extern const struct clk_ops mtk_mux_gate_clr_set_upd_ops;
0, _upd_ofs, _upd, CLK_SET_RATE_PARENT, \
mtk_mux_clr_set_upd_ops)
+#define MUX_GATE_FENC_CLR_SET_UPD_FLAGS(_id, _name, _parents, _paridx, \
+ _num_parents, _mux_ofs, _mux_set_ofs, _mux_clr_ofs, \
+ _shift, _width, _gate, _upd_ofs, _upd, \
+ _fenc_sta_mon_ofs, _fenc, _flags) { \
+ .id = _id, \
+ .name = _name, \
+ .mux_ofs = _mux_ofs, \
+ .set_ofs = _mux_set_ofs, \
+ .clr_ofs = _mux_clr_ofs, \
+ .upd_ofs = _upd_ofs, \
+ .fenc_sta_mon_ofs = _fenc_sta_mon_ofs, \
+ .mux_shift = _shift, \
+ .mux_width = _width, \
+ .gate_shift = _gate, \
+ .upd_shift = _upd, \
+ .fenc_shift = _fenc, \
+ .parent_names = _parents, \
+ .parent_index = _paridx, \
+ .num_parents = _num_parents, \
+ .flags = _flags, \
+ .ops = &mtk_mux_gate_fenc_clr_set_upd_ops, \
+ }
+
+#define MUX_GATE_FENC_CLR_SET_UPD(_id, _name, _parents, \
+ _mux_ofs, _mux_set_ofs, _mux_clr_ofs, \
+ _shift, _width, _gate, _upd_ofs, _upd, \
+ _fenc_sta_mon_ofs, _fenc) \
+ MUX_GATE_FENC_CLR_SET_UPD_FLAGS(_id, _name, _parents, \
+ NULL, ARRAY_SIZE(_parents), _mux_ofs, \
+ _mux_set_ofs, _mux_clr_ofs, _shift, \
+ _width, _gate, _upd_ofs, _upd, \
+ _fenc_sta_mon_ofs, _fenc, 0)
+
+#define MUX_GATE_FENC_CLR_SET_UPD_INDEXED(_id, _name, _parents, _paridx, \
+ _mux_ofs, _mux_set_ofs, _mux_clr_ofs, \
+ _shift, _width, _gate, _upd_ofs, _upd, \
+ _fenc_sta_mon_ofs, _fenc) \
+ MUX_GATE_FENC_CLR_SET_UPD_FLAGS(_id, _name, _parents, _paridx, \
+ ARRAY_SIZE(_paridx), _mux_ofs, _mux_set_ofs, \
+ _mux_clr_ofs, _shift, _width, _gate, _upd_ofs, _upd, \
+ _fenc_sta_mon_ofs, _fenc, 0)
+
int mtk_clk_register_muxes(struct device *dev,
const struct mtk_mux *muxes,
int num, struct device_node *node,
--
2.39.5
next prev parent reply other threads:[~2025-09-15 15:21 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 15:19 [PATCH v6 00/27] Add support for MT8196 clock controllers Laura Nao
2025-09-15 15:19 ` [PATCH v6 01/27] clk: mediatek: clk-pll: Add set/clr regs for shared PLL enable control Laura Nao
2025-09-21 16:53 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 02/27] clk: mediatek: clk-pll: Add ops for PLLs using set/clr regs and FENC Laura Nao
2025-09-21 16:53 ` Stephen Boyd
2025-09-15 15:19 ` Laura Nao [this message]
2025-09-21 16:53 ` [PATCH v6 03/27] clk: mediatek: clk-mux: Add ops for mux gates with set/clr/upd " Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 04/27] clk: mediatek: clk-mtk: Introduce mtk_clk_get_hwv_regmap() Laura Nao
2025-09-21 16:53 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 05/27] clk: mediatek: clk-mux: Add ops for mux gates with HW voter and FENC Laura Nao
2025-09-21 16:53 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 06/27] clk: mediatek: clk-gate: Refactor mtk_clk_register_gate to use mtk_gate struct Laura Nao
2025-09-21 16:53 ` Stephen Boyd
2025-10-12 17:50 ` issue with " Frank Wunderlich
2025-10-23 11:09 ` Laura Nao
2025-10-23 17:34 ` Aw: " frank-w
2025-10-24 11:21 ` Laura Nao
2025-09-15 15:19 ` [PATCH v6 07/27] clk: mediatek: clk-gate: Add ops for gates with HW voter Laura Nao
2025-09-21 16:53 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 08/27] clk: mediatek: clk-mtk: Add MUX_DIV_GATE macro Laura Nao
2025-09-21 16:53 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 09/27] dt-bindings: clock: mediatek: Describe MT8196 clock controllers Laura Nao
2025-09-21 16:53 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 10/27] clk: mediatek: Add MT8196 apmixedsys clock support Laura Nao
2025-09-21 16:53 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 11/27] clk: mediatek: Add MT8196 topckgen " Laura Nao
2025-09-21 16:53 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 12/27] clk: mediatek: Add MT8196 topckgen2 " Laura Nao
2025-09-21 16:54 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 13/27] clk: mediatek: Add MT8196 vlpckgen " Laura Nao
2025-09-21 16:54 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 14/27] clk: mediatek: Add MT8196 peripheral " Laura Nao
2025-09-21 16:54 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 15/27] clk: mediatek: Add MT8196 ufssys " Laura Nao
2025-09-21 16:54 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 16/27] clk: mediatek: Add MT8196 pextpsys " Laura Nao
2025-09-21 16:54 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 17/27] clk: mediatek: Add MT8196 I2C " Laura Nao
2025-09-21 16:54 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 18/27] clk: mediatek: Add MT8196 mcu " Laura Nao
2025-09-21 16:54 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 19/27] clk: mediatek: Add MT8196 mdpsys " Laura Nao
2025-09-21 16:54 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 20/27] clk: mediatek: Add MT8196 mfg " Laura Nao
2025-09-21 16:54 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 21/27] clk: mediatek: Add MT8196 disp0 " Laura Nao
2025-09-21 16:54 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 22/27] clk: mediatek: Add MT8196 disp1 " Laura Nao
2025-09-21 16:54 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 23/27] clk: mediatek: Add MT8196 disp-ao " Laura Nao
2025-09-21 16:54 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 24/27] clk: mediatek: Add MT8196 ovl0 " Laura Nao
2025-09-21 16:54 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 25/27] clk: mediatek: Add MT8196 ovl1 " Laura Nao
2025-09-21 16:55 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 26/27] clk: mediatek: Add MT8196 vdecsys " Laura Nao
2025-09-21 16:55 ` Stephen Boyd
2025-09-15 15:19 ` [PATCH v6 27/27] clk: mediatek: Add MT8196 vencsys " Laura Nao
2025-09-21 16:55 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915151947.277983-4-laura.nao@collabora.com \
--to=laura.nao@collabora.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guangjie.song@mediatek.com \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=nfraprado@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox