* Re: [PATCH v2 4/4] arm64: dts: qcom: sm7225-fairphone-fp4: Add Bluetooth [not found] ` <20230421-fp4-bluetooth-v2-4-3de840d5483e@fairphone.com> @ 2026-03-10 18:02 ` Conor Dooley 2026-03-11 8:04 ` Luca Weiss 0 siblings, 1 reply; 3+ messages in thread From: Conor Dooley @ 2026-03-10 18:02 UTC (permalink / raw) To: Luca Weiss Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz, Andy Gross, Bjorn Andersson, Konrad Dybcio, Conor Dooley, ~postmarketos/upstreaming, phone-devel, netdev, devicetree, linux-kernel, linux-bluetooth, linux-arm-msm [-- Attachment #1: Type: text/plain, Size: 1190 bytes --] On Fri, May 12, 2023 at 03:58:26PM +0200, Luca Weiss wrote: > +&qup_uart1_cts { > + /* > + * Configure a bias-bus-hold on CTS to lower power > + * usage when Bluetooth is turned off. Bus hold will > + * maintain a low power state regardless of whether > + * the Bluetooth module drives the pin in either > + * direction or leaves the pin fully unpowered. > + */ > + bias-bus-hold; > +}; > + > +&qup_uart1_rts { > + /* We'll drive RTS, so no pull */ > + drive-strength = <2>; > + bias-disable; > +}; > + > +&qup_uart1_rx { > + /* > + * Configure a pull-up on RX. This is needed to avoid > + * garbage data when the TX pin of the Bluetooth module is > + * in tri-state (module powered off or not driving the > + * signal yet). > + */ > + bias-pull-up; > +}; > + > +&qup_uart1_tx { > + /* We'll drive TX, so no pull */ > + drive-strength = <2>; > + bias-disable; > +}; I recently made some changes to pincfg-node.yaml to detect if there's conflicting properties used, and these got detected. Should these not do what has been done on the msm8998-xiaomi-sagit, and delete the inherited bias-foo from the dtsi? &blsp1_i2c5_sleep { /delete-property/ bias-pull-up; bias-disable; }; [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 4/4] arm64: dts: qcom: sm7225-fairphone-fp4: Add Bluetooth 2026-03-10 18:02 ` [PATCH v2 4/4] arm64: dts: qcom: sm7225-fairphone-fp4: Add Bluetooth Conor Dooley @ 2026-03-11 8:04 ` Luca Weiss 2026-03-11 18:01 ` Conor Dooley 0 siblings, 1 reply; 3+ messages in thread From: Luca Weiss @ 2026-03-11 8:04 UTC (permalink / raw) To: Conor Dooley, Luca Weiss Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz, Andy Gross, Bjorn Andersson, Konrad Dybcio, Conor Dooley, ~postmarketos/upstreaming, phone-devel, netdev, devicetree, linux-kernel, linux-bluetooth, linux-arm-msm On Tue Mar 10, 2026 at 7:02 PM CET, Conor Dooley wrote: > On Fri, May 12, 2023 at 03:58:26PM +0200, Luca Weiss wrote: > >> +&qup_uart1_cts { >> + /* >> + * Configure a bias-bus-hold on CTS to lower power >> + * usage when Bluetooth is turned off. Bus hold will >> + * maintain a low power state regardless of whether >> + * the Bluetooth module drives the pin in either >> + * direction or leaves the pin fully unpowered. >> + */ >> + bias-bus-hold; >> +}; >> + >> +&qup_uart1_rts { >> + /* We'll drive RTS, so no pull */ >> + drive-strength = <2>; >> + bias-disable; >> +}; >> + >> +&qup_uart1_rx { >> + /* >> + * Configure a pull-up on RX. This is needed to avoid >> + * garbage data when the TX pin of the Bluetooth module is >> + * in tri-state (module powered off or not driving the >> + * signal yet). >> + */ >> + bias-pull-up; >> +}; >> + >> +&qup_uart1_tx { >> + /* We'll drive TX, so no pull */ >> + drive-strength = <2>; >> + bias-disable; >> +}; > > I recently made some changes to pincfg-node.yaml to detect if there's > conflicting properties used, and these got detected. Should these not > do what has been done on the msm8998-xiaomi-sagit, and delete the > inherited bias-foo from the dtsi? > &blsp1_i2c5_sleep { > /delete-property/ bias-pull-up; > bias-disable; > }; Yes, you're completely right. In the final dtb qup-uart1-{cts,rts,rx,tx}-default-state contain two bias-* properties, this must be wrong. Thanks for pointing this out, I'll prepare a patch soon! Regards Luca ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 4/4] arm64: dts: qcom: sm7225-fairphone-fp4: Add Bluetooth 2026-03-11 8:04 ` Luca Weiss @ 2026-03-11 18:01 ` Conor Dooley 0 siblings, 0 replies; 3+ messages in thread From: Conor Dooley @ 2026-03-11 18:01 UTC (permalink / raw) To: Luca Weiss Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz, Andy Gross, Bjorn Andersson, Konrad Dybcio, Conor Dooley, ~postmarketos/upstreaming, phone-devel, netdev, devicetree, linux-kernel, linux-bluetooth, linux-arm-msm [-- Attachment #1: Type: text/plain, Size: 1811 bytes --] On Wed, Mar 11, 2026 at 09:04:20AM +0100, Luca Weiss wrote: > On Tue Mar 10, 2026 at 7:02 PM CET, Conor Dooley wrote: > > On Fri, May 12, 2023 at 03:58:26PM +0200, Luca Weiss wrote: > > > >> +&qup_uart1_cts { > >> + /* > >> + * Configure a bias-bus-hold on CTS to lower power > >> + * usage when Bluetooth is turned off. Bus hold will > >> + * maintain a low power state regardless of whether > >> + * the Bluetooth module drives the pin in either > >> + * direction or leaves the pin fully unpowered. > >> + */ > >> + bias-bus-hold; > >> +}; > >> + > >> +&qup_uart1_rts { > >> + /* We'll drive RTS, so no pull */ > >> + drive-strength = <2>; > >> + bias-disable; > >> +}; > >> + > >> +&qup_uart1_rx { > >> + /* > >> + * Configure a pull-up on RX. This is needed to avoid > >> + * garbage data when the TX pin of the Bluetooth module is > >> + * in tri-state (module powered off or not driving the > >> + * signal yet). > >> + */ > >> + bias-pull-up; > >> +}; > >> + > >> +&qup_uart1_tx { > >> + /* We'll drive TX, so no pull */ > >> + drive-strength = <2>; > >> + bias-disable; > >> +}; > > > > I recently made some changes to pincfg-node.yaml to detect if there's > > conflicting properties used, and these got detected. Should these not > > do what has been done on the msm8998-xiaomi-sagit, and delete the > > inherited bias-foo from the dtsi? > > &blsp1_i2c5_sleep { > > /delete-property/ bias-pull-up; > > bias-disable; > > }; > > Yes, you're completely right. > > In the final dtb qup-uart1-{cts,rts,rx,tx}-default-state contain two > bias-* properties, this must be wrong. > > Thanks for pointing this out, I'll prepare a patch soon! Cool, guess it just worked for you because of either property ordering or how linux parsed it. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-11 18:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230421-fp4-bluetooth-v2-0-3de840d5483e@fairphone.com>
[not found] ` <20230421-fp4-bluetooth-v2-4-3de840d5483e@fairphone.com>
2026-03-10 18:02 ` [PATCH v2 4/4] arm64: dts: qcom: sm7225-fairphone-fp4: Add Bluetooth Conor Dooley
2026-03-11 8:04 ` Luca Weiss
2026-03-11 18:01 ` Conor Dooley
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox