From: Bhargava Marreddy <bhargava.marreddy@broadcom.com>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
michael.chan@broadcom.com, pavan.chebbi@broadcom.com,
vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com,
Bhargava Marreddy <bhargava.marreddy@broadcom.com>
Subject: [PATCH net-next v10 04/10] bng_en: implement ethtool pauseparam operations
Date: Sat, 28 Mar 2026 01:43:37 +0530 [thread overview]
Message-ID: <20260327201343.16146-5-bhargava.marreddy@broadcom.com> (raw)
In-Reply-To: <20260327201343.16146-1-bhargava.marreddy@broadcom.com>
Implement .get_pauseparam and .set_pauseparam to support flow control
configuration. This allows reporting and setting of autoneg, RX pause,
and TX pause states.
Signed-off-by: Bhargava Marreddy <bhargava.marreddy@broadcom.com>
Reviewed-by: Vikas Gupta <vikas.gupta@broadcom.com>
---
.../net/ethernet/broadcom/bnge/bnge_ethtool.c | 63 +++++++++++++++++++
.../ethernet/broadcom/bnge/bnge_hwrm_lib.c | 6 +-
.../net/ethernet/broadcom/bnge/bnge_link.c | 45 +++++++++----
3 files changed, 100 insertions(+), 14 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_ethtool.c b/drivers/net/ethernet/broadcom/bnge/bnge_ethtool.c
index 6bb74a84ea03..424bf2d6721c 100644
--- a/drivers/net/ethernet/broadcom/bnge/bnge_ethtool.c
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_ethtool.c
@@ -46,6 +46,67 @@ static void bnge_get_drvinfo(struct net_device *dev,
strscpy(info->bus_info, pci_name(bd->pdev), sizeof(info->bus_info));
}
+static void bnge_get_pauseparam(struct net_device *dev,
+ struct ethtool_pauseparam *epause)
+{
+ struct bnge_net *bn = netdev_priv(dev);
+ struct bnge_dev *bd = bn->bd;
+
+ if (bd->phy_flags & BNGE_PHY_FL_NO_PAUSE) {
+ epause->autoneg = 0;
+ epause->rx_pause = 0;
+ epause->tx_pause = 0;
+ return;
+ }
+
+ epause->autoneg = !!(bn->eth_link_info.autoneg &
+ BNGE_AUTONEG_FLOW_CTRL);
+ epause->rx_pause = !!(bn->eth_link_info.req_flow_ctrl &
+ BNGE_LINK_PAUSE_RX);
+ epause->tx_pause = !!(bn->eth_link_info.req_flow_ctrl &
+ BNGE_LINK_PAUSE_TX);
+}
+
+static int bnge_set_pauseparam(struct net_device *dev,
+ struct ethtool_pauseparam *epause)
+{
+ struct bnge_ethtool_link_info old_elink_info, *elink_info;
+ struct bnge_net *bn = netdev_priv(dev);
+ struct bnge_dev *bd = bn->bd;
+ int rc = 0;
+
+ if (!BNGE_PHY_CFG_ABLE(bd) || (bd->phy_flags & BNGE_PHY_FL_NO_PAUSE))
+ return -EOPNOTSUPP;
+
+ elink_info = &bn->eth_link_info;
+ old_elink_info = *elink_info;
+
+ if (epause->autoneg) {
+ if (!(elink_info->autoneg & BNGE_AUTONEG_SPEED))
+ return -EINVAL;
+
+ elink_info->autoneg |= BNGE_AUTONEG_FLOW_CTRL;
+ } else {
+ if (elink_info->autoneg & BNGE_AUTONEG_FLOW_CTRL)
+ elink_info->force_link_chng = true;
+ elink_info->autoneg &= ~BNGE_AUTONEG_FLOW_CTRL;
+ }
+
+ elink_info->req_flow_ctrl = 0;
+ if (epause->rx_pause)
+ elink_info->req_flow_ctrl |= BNGE_LINK_PAUSE_RX;
+ if (epause->tx_pause)
+ elink_info->req_flow_ctrl |= BNGE_LINK_PAUSE_TX;
+
+ if (netif_running(dev)) {
+ rc = bnge_hwrm_set_pause(bn);
+ if (rc)
+ *elink_info = old_elink_info;
+ }
+
+ return rc;
+}
+
static const struct ethtool_ops bnge_ethtool_ops = {
.cap_link_lanes_supported = 1,
.get_link_ksettings = bnge_get_link_ksettings,
@@ -53,6 +114,8 @@ static const struct ethtool_ops bnge_ethtool_ops = {
.get_drvinfo = bnge_get_drvinfo,
.get_link = bnge_get_link,
.nway_reset = bnge_nway_reset,
+ .get_pauseparam = bnge_get_pauseparam,
+ .set_pauseparam = bnge_set_pauseparam,
};
void bnge_set_ethtool_ops(struct net_device *dev)
diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c b/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c
index 1cc62883d3c7..42fa08103df5 100644
--- a/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c
@@ -1054,7 +1054,11 @@ int bnge_hwrm_set_link_setting(struct bnge_net *bn, bool set_pause)
bnge_hwrm_set_link_common(bn, req);
- return bnge_hwrm_req_send(bd, req);
+ rc = bnge_hwrm_req_send(bd, req);
+ if (!rc)
+ bn->eth_link_info.force_link_chng = false;
+
+ return rc;
}
int bnge_update_link(struct bnge_net *bn, bool chng_link_state)
diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_link.c b/drivers/net/ethernet/broadcom/bnge/bnge_link.c
index af2f4466a199..aef06c13f335 100644
--- a/drivers/net/ethernet/broadcom/bnge/bnge_link.c
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_link.c
@@ -302,6 +302,8 @@ int bnge_update_phy_setting(struct bnge_net *bn)
struct bnge_dev *bd = bn->bd;
bool update_pause = false;
bool update_link = false;
+ bool hw_pause_autoneg;
+ bool pause_autoneg;
int rc;
link_info = &bd->link_info;
@@ -313,24 +315,41 @@ int bnge_update_phy_setting(struct bnge_net *bn)
return rc;
}
- if ((elink_info->autoneg & BNGE_AUTONEG_FLOW_CTRL) &&
- (link_info->auto_pause_setting & BNGE_LINK_PAUSE_BOTH) !=
- elink_info->req_flow_ctrl)
+ pause_autoneg = !!(elink_info->autoneg & BNGE_AUTONEG_FLOW_CTRL);
+ hw_pause_autoneg = !!(link_info->auto_pause_setting &
+ PORT_PHY_CFG_REQ_AUTO_PAUSE_AUTONEG_PAUSE);
+
+ /* Check if pause autonegotiation state has changed */
+ if (pause_autoneg != hw_pause_autoneg) {
update_pause = true;
- if (!(elink_info->autoneg & BNGE_AUTONEG_FLOW_CTRL) &&
- link_info->force_pause_setting != elink_info->req_flow_ctrl)
+ } else if (pause_autoneg) {
+ /* If pause autoneg is enabled, check if the
+ * requested RX/TX bits changed
+ */
+ if ((link_info->auto_pause_setting & BNGE_LINK_PAUSE_BOTH) !=
+ elink_info->req_flow_ctrl)
+ update_pause = true;
+ } else {
+ /* If pause autoneg is disabled, check if the
+ * forced RX/TX bits changed
+ */
+ if (link_info->force_pause_setting != elink_info->req_flow_ctrl)
+ update_pause = true;
+ }
+
+ /* Force update if link change is requested */
+ if (elink_info->force_link_chng)
update_pause = true;
+
+ /* Check if link speed or duplex settings have changed */
if (!(elink_info->autoneg & BNGE_AUTONEG_SPEED)) {
- if (BNGE_AUTO_MODE(link_info->auto_mode))
- update_link = true;
- if (bnge_force_speed_updated(bn))
- update_link = true;
- if (elink_info->req_duplex != link_info->duplex_setting)
+ if (BNGE_AUTO_MODE(link_info->auto_mode) ||
+ bnge_force_speed_updated(bn) ||
+ elink_info->req_duplex != link_info->duplex_setting)
update_link = true;
} else {
- if (link_info->auto_mode == BNGE_LINK_AUTO_NONE)
- update_link = true;
- if (bnge_auto_speed_updated(bn))
+ if (link_info->auto_mode == BNGE_LINK_AUTO_NONE ||
+ bnge_auto_speed_updated(bn))
update_link = true;
}
--
2.47.3
next prev parent reply other threads:[~2026-03-27 20:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 20:13 [PATCH net-next v10 00/10] bng_en: add link management and statistics support Bhargava Marreddy
2026-03-27 20:13 ` [PATCH net-next v10 01/10] bng_en: add per-PF workqueue, timer, and slow-path task Bhargava Marreddy
2026-03-27 20:13 ` [PATCH net-next v10 02/10] bng_en: query PHY capabilities and report link status Bhargava Marreddy
2026-03-27 20:13 ` [PATCH net-next v10 03/10] bng_en: add ethtool link settings, get_link, and nway_reset Bhargava Marreddy
2026-03-27 20:13 ` Bhargava Marreddy [this message]
2026-03-27 20:13 ` [PATCH net-next v10 05/10] bng_en: add support for link async events Bhargava Marreddy
2026-03-27 20:13 ` [PATCH net-next v10 06/10] bng_en: add HW stats infra and structured ethtool ops Bhargava Marreddy
2026-03-31 14:03 ` Paolo Abeni
2026-03-27 20:13 ` [PATCH net-next v10 07/10] bng_en: periodically fetch and accumulate hardware statistics Bhargava Marreddy
2026-03-27 20:13 ` [PATCH net-next v10 08/10] bng_en: implement ndo_get_stats64 Bhargava Marreddy
2026-03-27 20:13 ` [PATCH net-next v10 09/10] bng_en: implement netdev_stat_ops Bhargava Marreddy
2026-03-27 20:13 ` [PATCH net-next v10 10/10] bng_en: add support for ethtool -S stats display Bhargava Marreddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260327201343.16146-5-bhargava.marreddy@broadcom.com \
--to=bhargava.marreddy@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=vikas.gupta@broadcom.com \
--cc=vsrama-krishna.nemani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox