From: Paolo Abeni <pabeni@redhat.com>
To: Bhargava Marreddy <bhargava.marreddy@broadcom.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
andrew+netdev@lunn.ch, horms@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
michael.chan@broadcom.com, pavan.chebbi@broadcom.com,
vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com
Subject: Re: [PATCH net-next v10 06/10] bng_en: add HW stats infra and structured ethtool ops
Date: Tue, 31 Mar 2026 16:03:32 +0200 [thread overview]
Message-ID: <3e8bac40-5400-4eb0-9a44-7174efd805f1@redhat.com> (raw)
In-Reply-To: <20260327201343.16146-7-bhargava.marreddy@broadcom.com>
On 3/27/26 9:13 PM, Bhargava Marreddy wrote:
> @@ -1024,10 +1208,12 @@ static int bnge_alloc_core(struct bnge_net *bn)
> txr->bnapi = bnapi2;
> }
>
> - rc = bnge_alloc_ring_stats(bn);
> + rc = bnge_alloc_stats(bn);
> if (rc)
> goto err_free_core;
Sashico says:
---
Does tying the statistics memory allocation to bnge_alloc_core() cause
accumulated statistics to be lost when the interface is toggled down?
When the interface is brought down, bnge_free_core() calls
bnge_free_port_stats() which frees sw_stats and clears the
BNGE_FLAG_PORT_STATS flag. Any ethtool queries made while the interface
is down will then silently abort and return empty statistics, and all
historical counters will be permanently erased.
Should the software accumulators be allocated once at probe time so they
can persist across link state changes?
---
Please have a look at the full report, it could include other relevant
things.
https://sashiko.dev/#/patchset/20260327201343.16146-1-bhargava.marreddy%40broadcom.com
/P
next prev parent reply other threads:[~2026-03-31 14:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 20:13 [PATCH net-next v10 00/10] bng_en: add link management and statistics support Bhargava Marreddy
2026-03-27 20:13 ` [PATCH net-next v10 01/10] bng_en: add per-PF workqueue, timer, and slow-path task Bhargava Marreddy
2026-03-27 20:13 ` [PATCH net-next v10 02/10] bng_en: query PHY capabilities and report link status Bhargava Marreddy
2026-03-27 20:13 ` [PATCH net-next v10 03/10] bng_en: add ethtool link settings, get_link, and nway_reset Bhargava Marreddy
2026-03-27 20:13 ` [PATCH net-next v10 04/10] bng_en: implement ethtool pauseparam operations Bhargava Marreddy
2026-03-27 20:13 ` [PATCH net-next v10 05/10] bng_en: add support for link async events Bhargava Marreddy
2026-03-27 20:13 ` [PATCH net-next v10 06/10] bng_en: add HW stats infra and structured ethtool ops Bhargava Marreddy
2026-03-31 14:03 ` Paolo Abeni [this message]
2026-03-27 20:13 ` [PATCH net-next v10 07/10] bng_en: periodically fetch and accumulate hardware statistics Bhargava Marreddy
2026-03-27 20:13 ` [PATCH net-next v10 08/10] bng_en: implement ndo_get_stats64 Bhargava Marreddy
2026-03-27 20:13 ` [PATCH net-next v10 09/10] bng_en: implement netdev_stat_ops Bhargava Marreddy
2026-03-27 20:13 ` [PATCH net-next v10 10/10] bng_en: add support for ethtool -S stats display Bhargava Marreddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e8bac40-5400-4eb0-9a44-7174efd805f1@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=bhargava.marreddy@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pavan.chebbi@broadcom.com \
--cc=vikas.gupta@broadcom.com \
--cc=vsrama-krishna.nemani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox