public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: netdev@vger.kernel.org
Cc: jiri@resnulli.us, jhs@mojatatu.com, horms@kernel.org,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH v8 net 0/6] netem: bug fixes
Date: Fri, 17 Apr 2026 20:19:38 -0700	[thread overview]
Message-ID: <20260418032027.900913-1-stephen@networkplumber.org> (raw)

These bugs were found when doing AI-assisted review of sch_netem.c
during investigation of the packet duplication recursion problem
addressed in Jamal's series.

The fixes cover:

 - probability gaps in the 4-state Markov loss model
 - queue limit not accounting for reordered packets
 - PRNG reseeded on every tc change, breaking reproducibility
 - slot configuration not validated (inverted ranges, negative
   delays, negative limits)
 - slot delay arithmetic overflow for ranges above ~2.1 seconds
 - negative latency and jitter wrapping to huge time_to_send
   values via u64 arithmetic

v8 - added check for negative TCA_NETEM_LATENCY64 and TCA_NETEM_JITTER64
   - extended slot validation to cover dist_delay, dist_jitter,
     max_packets and max_bytes

Stephen Hemminger (6):
  net/sched: netem: fix probability gaps in 4-state loss model
  net/sched: netem: fix queue limit check to include reordered packets
  net/sched: netem: only reseed PRNG when seed is explicitly provided
  net/sched: netem: validate slot configuration
  net/sched: netem: fix slot delay calculation overflow
  net/sched: netem: check for negative latency and jitter

 net/sched/sch_netem.c | 76 ++++++++++++++++++++++++++++++++++++-------
 1 file changed, 64 insertions(+), 12 deletions(-)

-- 
2.53.0


             reply	other threads:[~2026-04-18  3:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-18  3:19 Stephen Hemminger [this message]
2026-04-18  3:19 ` [PATCH net v8 1/6] net/sched: netem: fix probability gaps in 4-state loss model Stephen Hemminger
2026-04-18  3:19 ` [PATCH net v8 2/6] net/sched: netem: fix queue limit check to include reordered packets Stephen Hemminger
2026-04-21 13:15   ` Simon Horman
2026-04-18  3:19 ` [PATCH net v8 3/6] net/sched: netem: only reseed PRNG when seed is explicitly provided Stephen Hemminger
2026-04-18  3:19 ` [PATCH net v8 4/6] net/sched: netem: validate slot configuration Stephen Hemminger
2026-04-21 13:10   ` Simon Horman
2026-04-18  3:19 ` [PATCH net v8 5/6] net/sched: netem: fix slot delay calculation overflow Stephen Hemminger
2026-04-18  3:19 ` [PATCH net v8 6/6] net/sched: netem: check for negative latency and jitter Stephen Hemminger
2026-04-21 13:16   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260418032027.900913-1-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=horms@kernel.org \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox