From: Jakub Kicinski <kuba@kernel.org>
To: "Tauro, Riana" <riana.tauro@intel.com>
Cc: Raag Jadav <raag.jadav@intel.com>,
<aravind.iddamsetty@linux.intel.com>, <rodrigo.vivi@intel.com>,
<dri-devel@lists.freedesktop.org>, <netdev@vger.kernel.org>,
<anshuman.gupta@intel.com>, <joonas.lahtinen@linux.intel.com>,
<simona.vetter@ffwll.ch>, <airlied@gmail.com>,
<pratik.bari@intel.com>, <joshua.santosh.ranjan@intel.com>,
<ashwin.kumar.kulkarni@intel.com>, <shubham.kumar@intel.com>,
<ravi.kishore.koppuravuri@intel.com>, <anvesh.bakwad@intel.com>,
<maarten.lankhorst@linux.intel.com>,
Zack McKevitt <zachary.mckevitt@oss.qualcomm.com>,
Lijo Lazar <lijo.lazar@amd.com>,
"Hawking Zhang" <Hawking.Zhang@amd.com>,
"David S. Miller" <davem@davemloft.net>,
"Paolo Abeni" <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
<intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH 3/4] drm/drm_ras: Add DRM RAS netlink error event notification
Date: Thu, 23 Apr 2026 09:29:22 -0700 [thread overview]
Message-ID: <20260423092922.6c527d75@kernel.org> (raw)
In-Reply-To: <65c6839f-a92d-4122-b347-a1250dde961d@intel.com>
On Thu, 23 Apr 2026 11:22:45 +0530 Tauro, Riana wrote:
> We had some questions regarding events in netlink
>
> 1) According to netlink spec, "Events are considered less idiomatic for
> netlink and notifications should be preferred."
> Since we currently don't have a response that matches a get operation to
> use notify. Would using an event be acceptable?
I have only glanced at previous messages but would it not work to
include the counter values into the "event" as if it was it was a
counter get?
If it makes no sense - it's fine. We have been adding events in some
places, too, in networking. The thinking is basically that when the app
that does the user space monitoring starts it will often want to know
the state of the world. So we end up with "get state of the world"
and "notify about state of the world" which should really be the same
format.
> 2) Is there a way to check if there are subscribers to a group before
> creating the event message?
> Currently the subscriber check happens in
> netlink_broadcast_filtered, but a reviewer suggested we could
> optimize by skipping message creation if there are no subscribers.
Yes, genl_has_listeners()
next prev parent reply other threads:[~2026-04-23 16:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 10:29 [PATCH 0/4] Add support for clear counter and error event in DRM RAS Riana Tauro
2026-03-11 10:29 ` [PATCH 1/4] drm/drm_ras: Add clear-error-counter netlink command to drm_ras Riana Tauro
2026-03-12 0:29 ` Jakub Kicinski
2026-03-25 12:40 ` Raag Jadav
2026-03-11 10:29 ` [PATCH 2/4] drm/xe/xe_drm_ras: Add support for clear-error-counter in XE DRM RAS Riana Tauro
2026-03-12 10:17 ` Raag Jadav
2026-03-11 10:29 ` [PATCH 3/4] drm/drm_ras: Add DRM RAS netlink error event notification Riana Tauro
2026-03-25 13:31 ` Raag Jadav
2026-04-08 14:29 ` Tauro, Riana
2026-04-09 5:35 ` Raag Jadav
2026-04-10 6:20 ` Tauro, Riana
2026-04-23 5:52 ` Tauro, Riana
2026-04-23 16:29 ` Jakub Kicinski [this message]
2026-03-11 10:29 ` [PATCH 4/4] drm/xe/xe_drm_ras: Add error-event support in XE DRM RAS Riana Tauro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260423092922.6c527d75@kernel.org \
--to=kuba@kernel.org \
--cc=Hawking.Zhang@amd.com \
--cc=airlied@gmail.com \
--cc=anshuman.gupta@intel.com \
--cc=anvesh.bakwad@intel.com \
--cc=aravind.iddamsetty@linux.intel.com \
--cc=ashwin.kumar.kulkarni@intel.com \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=joshua.santosh.ranjan@intel.com \
--cc=lijo.lazar@amd.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pratik.bari@intel.com \
--cc=raag.jadav@intel.com \
--cc=ravi.kishore.koppuravuri@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=shubham.kumar@intel.com \
--cc=simona.vetter@ffwll.ch \
--cc=zachary.mckevitt@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox